From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46C1CCDB483 for ; Thu, 19 Oct 2023 09:15:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C9BDF83B8E; Thu, 19 Oct 2023 09:15:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C9BDF83B8E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1697706929; bh=8SIjYCcKmaHxu9hCCsAd5338bBqdWh7r7BMWODqwwOY=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=OGz8+uKeUo6vBvJj1dMPWJYosF58JoO7wZRU9Wd4NBL+9J9gqZcrtcS3rarpVwcgX 5zT28vs+YNEIaD9Zf/2/wN9t6XuJ+tVHV8EsPaQTDypgPMA4GmLCJWpVMAQaEAzrqX NNW9Sg3KhBprKFwBtd0dgnv93gD5wgWStudXYTQbiNrB/1VdF2Hfj0jyfH81mYbDWZ slW+XKRbsLm5TNfAE2lhmGj1hKd0LBrb4uxD9RkvgOG1Bmb312F0Vj6Pv3toZcoA37 qzyhY2N7cpM8DL8Q5rUMeIRcget09+w7HsgV/TUNJ//xuvqFrlUoe83orAwiuF+wq+ /TSB+d0I8rcng== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EqZPafOW8Wfz; Thu, 19 Oct 2023 09:15:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id DD4E483B8A; Thu, 19 Oct 2023 09:15:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org DD4E483B8A Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C11801BF479 for ; Thu, 19 Oct 2023 09:15:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 91F5E4214D for ; Thu, 19 Oct 2023 09:15:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 91F5E4214D X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ai3kJQi6ANbp for ; Thu, 19 Oct 2023 09:15:25 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4828B4214B for ; Thu, 19 Oct 2023 09:15:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4828B4214B Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8FD51B82737; Thu, 19 Oct 2023 09:15:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1780C433C9; Thu, 19 Oct 2023 09:15:19 +0000 (UTC) Date: Thu, 19 Oct 2023 11:15:17 +0200 From: Simon Horman To: Ivan Vecera Message-ID: <20231019091408.GA2100445@kernel.org> References: <20231018112621.463893-1-ivecera@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231018112621.463893-1-ivecera@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697706921; bh=2akR1+SpClZT3e4hW3GUBKo4hbbNfLPH+FJFcgjS+bQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NDw9mOxaxTwpIG2OLQXoJ0CTEuTsLDqvqLHgBr9mmasIrMuTajY6NHR2Lyp8kgko6 d4U8sANg22+MMNy2oqQ2OSdIgdmMJamlgzMkYRMyp1LiPWEsQFCCXrYG+KB9s9ROA6 xrGm9sIN/VYicmTIOc2PRrZHF0zprsL+JeaHthvLwlsKzaB7CqNBLgHapoVQ0xfmNS fEpb0MVH2Rxi8hOXbP4pIFEwrbKXxQorzEod3798LFEhxycRFVGFPYJO2X/E3npYjx /veSJeNpceDqBEWxRwbj3qneTmQEmzUOwpDBaggyRdFFT7LeLAZjB0uzOvwZ8xtJ3D LHb3jjr7cIK7g== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=NDw9mOxa Subject: Re: [Intel-wired-lan] [PATCH net] i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Jesse Brandeburg , open list , Eric Dumazet , Tony Nguyen , Mateusz Palczewski , Jakub Kicinski , Paolo Abeni , "David S. Miller" , "moderated list:INTEL ETHERNET DRIVERS" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Oct 18, 2023 at 01:26:20PM +0200, Ivan Vecera wrote: > Commit c87c938f62d8f1 ("i40e: Add VF VLAN pruning") added new > PF flag I40E_FLAG_VF_VLAN_PRUNING but its value collides with > existing I40E_FLAG_TOTAL_PORT_SHUTDOWN_ENABLED flag. > > Move the affected flag at the end of the flags and fix its value. > > Cc: Mateusz Palczewski > Signed-off-by: Ivan Vecera Hi Ivan, I agree with the correctness of this patch and that it was introduced by the cited commit. However, I do wonder if, as a fix for 'net': 1) The patch description could include some discussion of what problem is resolved, and, ideally, how I user might get into such a situation. 2) The following fixes tag is appropriate. Fixes: c87c938f62d8 ("i40e: Add VF VLAN pruning") ... _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan