From: kernel test robot <lkp@intel.com>
To: Karol Kolacinski <karol.kolacinski@intel.com>,
intel-wired-lan@lists.osuosl.org
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
jesse.brandeburg@intel.com,
Karol Kolacinski <karol.kolacinski@intel.com>,
anthony.l.nguyen@intel.com, oe-kbuild-all@lists.linux.dev,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove unnecessary discarding of timestamps
Date: Tue, 31 Oct 2023 00:23:35 +0800 [thread overview]
Message-ID: <202310310036.7Cgll3Lm-lkp@intel.com> (raw)
In-Reply-To: <20231026105955.282546-1-karol.kolacinski@intel.com>
Hi Karol,
kernel test robot noticed the following build errors:
[auto build test ERROR on b57a67bab47efc24e7ea7bd626aa517ac76c4fc9]
url: https://github.com/intel-lab-lkp/linux/commits/Karol-Kolacinski/ice-remove-unnecessary-discarding-of-timestamps/20231026-192456
base: b57a67bab47efc24e7ea7bd626aa517ac76c4fc9
patch link: https://lore.kernel.org/r/20231026105955.282546-1-karol.kolacinski%40intel.com
patch subject: [Intel-wired-lan] [PATCH iwl-next] ice: remove unnecessary discarding of timestamps
config: arc-allmodconfig (https://download.01.org/0day-ci/archive/20231031/202310310036.7Cgll3Lm-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231031/202310310036.7Cgll3Lm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310310036.7Cgll3Lm-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/net/ethernet/intel/ice/ice_ptp.c: In function 'ice_ptp_rebuild_owner':
>> drivers/net/ethernet/intel/ice/ice_ptp.c:2509:9: error: implicit declaration of function 'ice_ptp_flush_all_tx_tracker'; did you mean 'ice_ptp_flush_tx_tracker'? [-Werror=implicit-function-declaration]
2509 | ice_ptp_flush_all_tx_tracker(pf);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ice_ptp_flush_tx_tracker
cc1: some warnings being treated as errors
vim +2509 drivers/net/ethernet/intel/ice/ice_ptp.c
0c095c9988dd713 Karol Kolacinski 2023-10-25 2454
4809671015a1bd2 Karol Kolacinski 2021-12-20 2455 /**
9ea8140e2f947cb Jacob Keller 2023-10-25 2456 * ice_ptp_rebuild_owner - Initialize PTP clock owner after reset
4809671015a1bd2 Karol Kolacinski 2021-12-20 2457 * @pf: Board private structure
9ea8140e2f947cb Jacob Keller 2023-10-25 2458 *
9ea8140e2f947cb Jacob Keller 2023-10-25 2459 * Companion function for ice_ptp_rebuild() which handles tasks that only the
9ea8140e2f947cb Jacob Keller 2023-10-25 2460 * PTP clock owner instance should perform.
4809671015a1bd2 Karol Kolacinski 2021-12-20 2461 */
9ea8140e2f947cb Jacob Keller 2023-10-25 2462 static int ice_ptp_rebuild_owner(struct ice_pf *pf)
4809671015a1bd2 Karol Kolacinski 2021-12-20 2463 {
4809671015a1bd2 Karol Kolacinski 2021-12-20 2464 struct ice_ptp *ptp = &pf->ptp;
4809671015a1bd2 Karol Kolacinski 2021-12-20 2465 struct ice_hw *hw = &pf->hw;
4809671015a1bd2 Karol Kolacinski 2021-12-20 2466 struct timespec64 ts;
4809671015a1bd2 Karol Kolacinski 2021-12-20 2467 u64 time_diff;
d695241a0a0ea02 Jacob Keller 2023-10-25 2468 int err;
4809671015a1bd2 Karol Kolacinski 2021-12-20 2469
b2ee72565cd0ee2 Jacob Keller 2021-10-13 2470 err = ice_ptp_init_phc(hw);
4809671015a1bd2 Karol Kolacinski 2021-12-20 2471 if (err)
9ea8140e2f947cb Jacob Keller 2023-10-25 2472 return err;
4809671015a1bd2 Karol Kolacinski 2021-12-20 2473
4809671015a1bd2 Karol Kolacinski 2021-12-20 2474 /* Acquire the global hardware lock */
4809671015a1bd2 Karol Kolacinski 2021-12-20 2475 if (!ice_ptp_lock(hw)) {
4809671015a1bd2 Karol Kolacinski 2021-12-20 2476 err = -EBUSY;
9ea8140e2f947cb Jacob Keller 2023-10-25 2477 return err;
4809671015a1bd2 Karol Kolacinski 2021-12-20 2478 }
4809671015a1bd2 Karol Kolacinski 2021-12-20 2479
4809671015a1bd2 Karol Kolacinski 2021-12-20 2480 /* Write the increment time value to PHY and LAN */
78267d0c9cabf09 Jacob Keller 2021-10-13 2481 err = ice_ptp_write_incval(hw, ice_base_incval(pf));
4809671015a1bd2 Karol Kolacinski 2021-12-20 2482 if (err) {
4809671015a1bd2 Karol Kolacinski 2021-12-20 2483 ice_ptp_unlock(hw);
9ea8140e2f947cb Jacob Keller 2023-10-25 2484 return err;
4809671015a1bd2 Karol Kolacinski 2021-12-20 2485 }
4809671015a1bd2 Karol Kolacinski 2021-12-20 2486
4809671015a1bd2 Karol Kolacinski 2021-12-20 2487 /* Write the initial Time value to PHY and LAN using the cached PHC
4809671015a1bd2 Karol Kolacinski 2021-12-20 2488 * time before the reset and time difference between stopping and
4809671015a1bd2 Karol Kolacinski 2021-12-20 2489 * starting the clock.
4809671015a1bd2 Karol Kolacinski 2021-12-20 2490 */
4809671015a1bd2 Karol Kolacinski 2021-12-20 2491 if (ptp->cached_phc_time) {
4809671015a1bd2 Karol Kolacinski 2021-12-20 2492 time_diff = ktime_get_real_ns() - ptp->reset_time;
4809671015a1bd2 Karol Kolacinski 2021-12-20 2493 ts = ns_to_timespec64(ptp->cached_phc_time + time_diff);
4809671015a1bd2 Karol Kolacinski 2021-12-20 2494 } else {
4809671015a1bd2 Karol Kolacinski 2021-12-20 2495 ts = ktime_to_timespec64(ktime_get_real());
4809671015a1bd2 Karol Kolacinski 2021-12-20 2496 }
4809671015a1bd2 Karol Kolacinski 2021-12-20 2497 err = ice_ptp_write_init(pf, &ts);
4809671015a1bd2 Karol Kolacinski 2021-12-20 2498 if (err) {
4809671015a1bd2 Karol Kolacinski 2021-12-20 2499 ice_ptp_unlock(hw);
9ea8140e2f947cb Jacob Keller 2023-10-25 2500 return err;
4809671015a1bd2 Karol Kolacinski 2021-12-20 2501 }
4809671015a1bd2 Karol Kolacinski 2021-12-20 2502
4809671015a1bd2 Karol Kolacinski 2021-12-20 2503 /* Release the global hardware lock */
4809671015a1bd2 Karol Kolacinski 2021-12-20 2504 ice_ptp_unlock(hw);
4809671015a1bd2 Karol Kolacinski 2021-12-20 2505
b57a67bab47efc2 Jacob Keller 2023-10-25 2506 /* Flush software tracking of any outstanding timestamps since we're
b57a67bab47efc2 Jacob Keller 2023-10-25 2507 * about to flush the PHY timestamp block.
b57a67bab47efc2 Jacob Keller 2023-10-25 2508 */
b57a67bab47efc2 Jacob Keller 2023-10-25 @2509 ice_ptp_flush_all_tx_tracker(pf);
b57a67bab47efc2 Jacob Keller 2023-10-25 2510
3a7496234d179a7 Jacob Keller 2021-10-13 2511 if (!ice_is_e810(hw)) {
3a7496234d179a7 Jacob Keller 2021-10-13 2512 /* Enable quad interrupts */
d695241a0a0ea02 Jacob Keller 2023-10-25 2513 err = ice_ptp_cfg_phy_interrupt(pf, true, 1);
9ea8140e2f947cb Jacob Keller 2023-10-25 2514 if (err)
9ea8140e2f947cb Jacob Keller 2023-10-25 2515 return err;
9ea8140e2f947cb Jacob Keller 2023-10-25 2516
9ea8140e2f947cb Jacob Keller 2023-10-25 2517 ice_ptp_restart_all_phy(pf);
9ea8140e2f947cb Jacob Keller 2023-10-25 2518 }
9ea8140e2f947cb Jacob Keller 2023-10-25 2519
9ea8140e2f947cb Jacob Keller 2023-10-25 2520 return 0;
9ea8140e2f947cb Jacob Keller 2023-10-25 2521 }
9ea8140e2f947cb Jacob Keller 2023-10-25 2522
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2023-10-30 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 10:59 [Intel-wired-lan] [PATCH iwl-next] ice: remove unnecessary discarding of timestamps Karol Kolacinski
2023-10-27 18:19 ` Jacob Keller
2023-10-27 18:20 ` Jacob Keller
2023-10-27 20:58 ` Jacob Keller
2023-10-30 16:23 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310310036.7Cgll3Lm-lkp@intel.com \
--to=lkp@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox