From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9135CC4332F for ; Sat, 11 Nov 2023 18:41:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 112C641DC9; Sat, 11 Nov 2023 18:41:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 112C641DC9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1699728069; bh=Rx324LH4Q9ZeJMW3FJHt/iVk1cf5LqmGLCJQZEdmJ3w=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=vlN9wWAswMqW5uwjz+jhcXerL/np/7H5l7vT+pR2kFbp4+O2aoOvqXzLxEHUyv9S/ fNans1ex/vqj0XdeLWT1TmrgcUTNkEo4CkqpboZ5Vn4MYXOrEVL5X4Jl91pFabJju/ XFWFlFI0Vg0e5ZoM7B1S/zdLy8SseBLoreDOnDRegvTUYKQeUcFI3/ewh48wvcnnSq jdGzkw9hydSuB9ie/JepmWSmvMUnjO/O6plS5sarak79PrQ/lNqsheFbLCSrAdur2l aHeuUvCGeHC3PbiydNLi0eolP/YAA5PQ8Ot/NIU1OH6MljU0UOJGNUdkJdnyST3Jwg de6PW4CMgPIcg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w9Kv9JGoiygu; Sat, 11 Nov 2023 18:41:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 00A7741DCE; Sat, 11 Nov 2023 18:41:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 00A7741DCE Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 558D11BF36A for ; Sat, 11 Nov 2023 18:41:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 28CAA82321 for ; Sat, 11 Nov 2023 18:41:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 28CAA82321 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p8j7Iuxv21yp for ; Sat, 11 Nov 2023 18:41:05 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp1.osuosl.org (Postfix) with ESMTPS id 788FF8231E for ; Sat, 11 Nov 2023 18:41:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 788FF8231E Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 6A80FB80B6F; Sat, 11 Nov 2023 18:41:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3757C433C7; Sat, 11 Nov 2023 18:40:59 +0000 (UTC) Date: Sat, 11 Nov 2023 18:40:52 +0000 From: Simon Horman To: Ivan Vecera Message-ID: <20231111184052.GA705326@kernel.org> References: <20231110081209.189481-1-ivecera@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231110081209.189481-1-ivecera@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699728062; bh=RX3cBdIDKqcF57RnJqTIKKb8tzO0jX/53K43wpZkfaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JX9ST7pmqRLghGLS7zyNC/HocKeBpovpuRqw2Jz/p4XuyrOJsalbi4mZAUH6uMJIb PnOlPrZFvJjmwcOB/NioYCw3uHkliZo6fxI07BuFd1hGgL36EsGTrnd0tEzjcU4s/V rqRPeAXjS5dz6OASQzkqo6NeXtvogL7YYeL3TzuR9/UMJx898K+9nKemVYLo2piWAA 1pp7Mt46U53NRvaIf9Ixp26m58ew93Tw00a6QorCxFgI+XsAG/W+Yq0l5qVbxzTsAW WRda9xI6nX3+Yk3tzHYCDYeFAfWHPEDa4Qs+qP/njhdzwNIrMqJBCJ0+Y8GNuwi1bC OxqSHSguRaqxQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=JX9ST7pm Subject: Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix unexpected MFS warning message X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wojciech Drewek , "open list:NETWORKING DRIVERS" , Jesse Brandeburg , open list , Eric Dumazet , Tony Nguyen , Jeff Kirsher , Jakub Kicinski , Jacob Keller , intel-wired-lan@lists.osuosl.org, Todd Fujinaka , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Nov 10, 2023 at 09:12:09AM +0100, Ivan Vecera wrote: > Commit 3a2c6ced90e1 ("i40e: Add a check to see if MFS is set") added > a warning message that reports unexpected size of port's MFS (max > frame size) value. This message use for the port number local > variable 'i' that is wrong. > In i40e_probe() this 'i' variable is used only to iterate VSIs > to find FDIR VSI: > > > ... > /* if FDIR VSI was set up, start it now */ > for (i = 0; i < pf->num_alloc_vsi; i++) { > if (pf->vsi[i] && pf->vsi[i]->type == I40E_VSI_FDIR) { > i40e_vsi_open(pf->vsi[i]); > break; > } > } > ... > > > So the warning message use for the port number indext of FDIR VSI > if this exists or pf->num_alloc_vsi if not. > > Fix the message by using 'pf->hw.port' for the port number. > > Fixes: 3a2c6ced90e1 ("i40e: Add a check to see if MFS is set") > Signed-off-by: Ivan Vecera Thanks Ivan, I agree with your analysis that this change corrects the port number printed. And that the problem is introduced in the cited commit. Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan