From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73315C61D97 for ; Tue, 21 Nov 2023 23:34:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 25E7040A92; Tue, 21 Nov 2023 23:34:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 25E7040A92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1700609644; bh=zYGHc6C9lgd8lRwaj0M074e3v6vVKt9Kow017fdERfQ=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=dW1oJb2mbihWMHxcZVoe8QuAWR/0PRyWPsa4cWAB+gWlSpDLGQfzWmdtglqJ+KI6C 6uDV3J5czeTkp9NAQ8uhrde5H2zYZiJBxxQtH236ayNkh63/xCEOYRJPELIqw86DNp pYgWfWrTBHQ+aoXJKoymvEXN+2hnr848V5GHlMZLswJ3fJ69GXdS7szxEJ4kxFrI/2 +pr8I/wt4RbMF1T1cPNDkgoiBul1Kn38SbdGZLt0ALuCgaIEXZbLCZAJgQtPXenWLw um1l088m4N7maqxazm3t/JU+NVgO5F6dBOQyIDD/XxJOVBVvN4upjDo+nZIizvo2hg xMnStnQ3dsrnA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3RGAC3Y6QaEZ; Tue, 21 Nov 2023 23:34:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id E7810404A5; Tue, 21 Nov 2023 23:34:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E7810404A5 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 272651BF309 for ; Tue, 21 Nov 2023 23:34:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F1754812FC for ; Tue, 21 Nov 2023 23:34:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F1754812FC X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cC04Lwh6Ydvd for ; Tue, 21 Nov 2023 23:34:01 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 44925812DA for ; Tue, 21 Nov 2023 23:34:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 44925812DA Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7AC7261B9C; Tue, 21 Nov 2023 23:34:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C6C8C433C7; Tue, 21 Nov 2023 23:33:59 +0000 (UTC) Date: Tue, 21 Nov 2023 15:33:58 -0800 From: Jakub Kicinski To: Ahmed Zaki Message-ID: <20231121153358.3a6a09de@kernel.org> In-Reply-To: <20231120205614.46350-3-ahmed.zaki@intel.com> References: <20231120205614.46350-1-ahmed.zaki@intel.com> <20231120205614.46350-3-ahmed.zaki@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700609640; bh=13VVws5PcCjLAP+55UIaYOZrBe+ks7pXu1hqEWmgU6I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IW/0lAkazpPvR2mLvLzKJp3XdexvglQRFUrHW9D4UGKHucfjfAUIv12An/y+VCDZO /b1jAnN2Om/rHZchAYEXeI1JE00fcnnHidlpBDCr3L5cBKeda0p1BKHxYFNa7A5J9E rPyyyowS5TCNfJ8ytWsL4UxeXLDpBg/Nk/YlIRnwAhIbJRWRxqAdnGmkqYChaVwwZL 6EugrLGys8ImFsL7sOGmvd2amiHm9yHIRERUWjvvqoZ7Ce0s8UTrynOl101P9C/tW/ F1VNjTJRHfFBa9GXu5DyPvphkTC0cdqipZdkz+zNsCmHYvFEaAg6SG7lLV6RO02gC4 RSqbFpgWJn5KA== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=IW/0lAka Subject: Re: [Intel-wired-lan] [PATCH net-next v6 2/7] net: ethtool: add support for symmetric-xor RSS hash X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mkubecek@suse.cz, andrew@lunn.ch, willemdebruijn.kernel@gmail.com, Wojciech Drewek , corbet@lwn.net, netdev@vger.kernel.org, gal@nvidia.com, linux-doc@vger.kernel.org, jesse.brandeburg@intel.com, edumazet@google.com, anthony.l.nguyen@intel.com, horms@kernel.org, vladimir.oltean@nxp.com, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 20 Nov 2023 13:56:09 -0700 Ahmed Zaki wrote: > + * @data: Extension for the RSS hash function. Valid values are one of the > + * %RXH_HFUNC_*. @data is way too generic. Can we call this key_xfrm? key_preproc? > +/* RSS hash function data > + * XOR the corresponding source and destination fields of each specified > + * protocol. Both copies of the XOR'ed fields are fed into the RSS and RXHASH > + * calculation. > + */ > +#define RXH_HFUNC_SYM_XOR (1 << 0) We need to mention somewhere that sym-xor is unsafe, per Alex's comments. > +++ b/include/uapi/linux/ethtool_netlink.h You need to fill in the details in: Documentation/networking/ethtool-netlink.rst and Documentation/netlink/specs/ethtool.yaml Last but not least please keep the field check you moved to the drivers in the core. Nobody will remember to check that other drivers added the check as well. -- pw-bot: cr _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan