From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FFA4C61DF4 for ; Fri, 24 Nov 2023 10:59:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B756A60B0B; Fri, 24 Nov 2023 10:59:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B756A60B0B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1700823571; bh=58GdY+2Q1Zsb5CpUCbCX5wgtPv9Cggy4R8WKzIhSiXo=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=tTpHXC1dg3Op9NA5ZAy1jAU4vxzyYyg56BjkHUiDt4HD7N9s4uldUyV1jHxu6U+uW aIRWTjBXfGI3VDF1vW1tmhb3Xbim88TwpmY9YjyS2F6MNi67Bb/sK88MAb4PTSqvlk 2o+7U78X4LmTF2dw46DaRl0BbRVdplLcaEWB719PWrZ5G2Guli4l7FViWBm9d4qADT 25FiG+3ElBr07n1822iZ4dQRzHL9BUii5qB5OGTf4l/BncaZV8/yeWGoA2cV2YIbvX FVbKbIbB25KdAXuxNqZAk83nkCBXvDHY+oMndlkZv/K+tvf4Hiu0HCPh9GpZMfikgH fyjc+3KXli8ZA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZMYHpAG3Gab3; Fri, 24 Nov 2023 10:59:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id C85A9614FD; Fri, 24 Nov 2023 10:59:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C85A9614FD Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id A71331BF20B for ; Fri, 24 Nov 2023 10:59:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 72CBD61501 for ; Fri, 24 Nov 2023 10:59:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 72CBD61501 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x9KYvhyBq0uQ for ; Fri, 24 Nov 2023 10:59:27 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp3.osuosl.org (Postfix) with ESMTPS id B946F614FD for ; Fri, 24 Nov 2023 10:59:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B946F614FD Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id AF513B83011; Fri, 24 Nov 2023 10:59:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 624EFC433C7; Fri, 24 Nov 2023 10:59:24 +0000 (UTC) Date: Fri, 24 Nov 2023 10:59:21 +0000 From: Simon Horman To: Jesse Brandeburg Message-ID: <20231124105921.GA50352@kernel.org> References: <20231121211921.19834-1-jesse.brandeburg@intel.com> <20231121211921.19834-2-jesse.brandeburg@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231121211921.19834-2-jesse.brandeburg@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700823565; bh=EOZkNxRfA9Kl8PAL0nuQ12sqXCLbdky3xV1Jm+uFK78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VPyI3ulwG1+FFG9WtTaXBUAxJKkTxQRoAHT2ldefgsIU7gLM+/LnTDNtqARlyzNzb fLGIUIlqbyJ46myP54n5L4Utk+JPsUNfuNVDasWQgbmhWCkkoNkClSyrv1D1IGCziw 2ayPNlScgRkSURN3sJpmeDsQyNLbqq/vmOEmZHwgSmFixVmFa5oGelfnu6zMecQNpB YaWjmk5tYESzPLvmVZOVDJeXQncVfNiGubRWKG9/askodtUP11o4C8ypaq+67dq6/a 3cRLOvwpCKyVONk4hzhLbXVf1GdW7ScgC2HVVW/xQRlVAHU3eOeGN6Fpq+HF2UeYPa v8Xff9djaxz4w== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=VPyI3ulw Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 01/13] e1000e: make lost bits explicit X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Marcin Szycik , intel-wired-lan@lists.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Nov 21, 2023 at 01:19:09PM -0800, Jesse Brandeburg wrote: > For more than 15 years this code has passed in a request for a page and > masked off that page when read/writing. This code has been here forever, > but FIELD_PREP finds the bug when converted to use it. Change the code > to do exactly the same thing but allow the conversion to FIELD_PREP in a > later patch. To make it clear what we lost when making this change I > left a comment, but there is no point to change the code to generate a > correct sequence at this point. :) > This is not a Fixes tagged patch on purpose because it doesn't change > the binary output. > > Reviewed-by: Marcin Szycik > Signed-off-by: Jesse Brandeburg Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan