From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 218FCC07CB1 for ; Wed, 29 Nov 2023 14:29:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AC7A460AAD; Wed, 29 Nov 2023 14:29:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AC7A460AAD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701268167; bh=Vyh/gLq0BEvC2hyMS2gIg+blnQq90/sk1NqeMAmB/tU=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=BTJXPzWBVzW+B9P05i/2f8SQ1JtnOoEgo1mzGEfNQMTjhRVaqsFzFb7YsiUUKtCBb HZ4wnpXD3XRLvnWogaVkcLQIl1f61+lA8EFzAxVxrXj6q3ckj4SgZrH0N1gh8rDJfZ 1SAaTwMLUe3uFkLjG//FSAdplkbLksJ7zdiGu3dnLOXiRfU55S89qrfmBqtP/jAKXk xG6+Q+8J1z+FFwWJTWyAG8EEZORq/uqS8LRlRFv57UujtU/vH42XUTytjyK3HBsymQ vwd4xB9weXVZ23H/xyEu9mmyEmwMlRvxnvpbW0nPsBnL980UbHo+w4zhpoVb3aNboZ OhjmkkwbY4p/w== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aRo99bATY2su; Wed, 29 Nov 2023 14:29:27 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id C3ADF60ADC; Wed, 29 Nov 2023 14:29:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C3ADF60ADC Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 09C6A1BF283 for ; Wed, 29 Nov 2023 14:29:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D53A5418A8 for ; Wed, 29 Nov 2023 14:29:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D53A5418A8 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LinfOuOg_wa5 for ; Wed, 29 Nov 2023 14:29:23 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7B9054030C for ; Wed, 29 Nov 2023 14:29:23 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7B9054030C Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C8289CE1F13; Wed, 29 Nov 2023 14:29:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 382C7C433C9; Wed, 29 Nov 2023 14:29:15 +0000 (UTC) Date: Wed, 29 Nov 2023 06:29:14 -0800 From: Jakub Kicinski To: Alexander Lobakin Message-ID: <20231129062914.0f895d1c@kernel.org> In-Reply-To: References: <20231124154732.1623518-1-aleksander.lobakin@intel.com> <20231124154732.1623518-14-aleksander.lobakin@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701268155; bh=TeXzHb7rxKXQGXucrw/Ty/eqYEy5dqm0uu/JKO7RDCs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i3O7voHEX9nwvQnJXx+x/l0uWqkVQvdAG5q4p3bznL6GqphqcrWs3xFHrQ8QI/oPi lNmWjgwa9JSdXyIuoBuXqerZJuECGpkCKl+ZH+M4+4WdrDS6HtsTg176EV4ShNUCW5 74vO/32ri773Hg8T1+F7X62xkD1hHHTvOHaVEMEz+B5Pu2Lc94AamDXFejMn5DgGVK 74kTTH2DyszHJFugM9TQ9/a5NIFzY+8wnrbrtwAXkgCspTtViqeF+Mf1HxL2Bs4rzi K1XKEAxa6HRKtIqP31DRapZ0z0qUqTCdIRHAVe/eJoY6N8ZxHzb/zX810zld/zkWC3 feN0/SCLMbyRw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=i3O7voHE Subject: Re: [Intel-wired-lan] [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Menzel , Maciej Fijalkowski , Jesper Dangaard Brouer , Larysa Zaremba , netdev@vger.kernel.org, Alexander Duyck , Ilias Apalodimas , Yunsheng Lin , linux-kernel@vger.kernel.org, Eric Dumazet , Michal Kubiak , intel-wired-lan@lists.osuosl.org, David Christensen , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 29 Nov 2023 14:40:33 +0100 Alexander Lobakin wrote: > > Expand the libie generic per-queue stats with the generic Page Pool > > stats provided by the API itself, when CONFIG_PAGE_POOL_STATS is > > enabled. When it's not, there'll be no such fields in the stats > > structure, so no space wasted. > > Do I get it correctly that after Page Pool Netlink introspection was > merged, this commit makes no sense and we shouln't add PP stats to the > drivers private ones? Yes, 100%. FWIW I am aware that better tooling would be good so non-developers could access to the PP Netlink :( I'm thinking we should clean up YNL lib packaging a little and try to convince iproute2 maintainers to accept simple CLI built on top of it. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan