From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CB11C10DC1 for ; Fri, 1 Dec 2023 06:55:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1515A60745; Fri, 1 Dec 2023 06:55:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1515A60745 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701413732; bh=P7+xHuT3WyK4vrPGkP/9HZEnCaJ5KGMeMaWDmvQJeuo=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=cvWGZDs8KONsxtH4MypD3cruFikXEP27ztzlNTAkqcwYbCZraHzOcm4QHbvWOs0/F H4WOeDWXfFNM0XIOZFWibZ2TZEwf1R/IPYZS6fzqegu6jRvmqkl3Ri63Ht/whYZe2Y BjSWWHMQKNZe0fNG/7EWD1CKir8043+KFa9aXrcHWVC3BPn39ubkDYyj0ULnNGXS5+ 3cc9Nlob1kQBvrAphRmvK3C7iC4vUkBQRf50Sbftvi/yI1VYiLnlNrH613KSfBTUvV TttVMtgvf7qRAuzJYRNLM4qZHXk3L9v9LpPMvR4FAxvejsPZUb2QG3+83+GEgrAENN H8jFwNyq2W4ig== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id htpirXVPZFMh; Fri, 1 Dec 2023 06:55:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 2A5B4607A1; Fri, 1 Dec 2023 06:55:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2A5B4607A1 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id B13FF1BF345 for ; Fri, 1 Dec 2023 06:55:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8463A42084 for ; Fri, 1 Dec 2023 06:55:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8463A42084 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aAYUzVnJbTag for ; Fri, 1 Dec 2023 06:55:28 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id E6D1542083 for ; Fri, 1 Dec 2023 06:55:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E6D1542083 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BD8CD62071; Fri, 1 Dec 2023 06:55:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D93EFC433CA; Fri, 1 Dec 2023 06:55:25 +0000 (UTC) Date: Thu, 30 Nov 2023 22:55:24 -0800 From: Jakub Kicinski To: Alexander Lobakin Message-ID: <20231130225524.76d41381@kernel.org> In-Reply-To: <289bf666-b985-4dc4-bf0a-16b1ae072757@intel.com> References: <20231124154732.1623518-1-aleksander.lobakin@intel.com> <20231124154732.1623518-14-aleksander.lobakin@intel.com> <20231129062914.0f895d1c@kernel.org> <289bf666-b985-4dc4-bf0a-16b1ae072757@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701413726; bh=rvlUpmCWet3DQSETpKuQuIH6X2X3rucwyaSzL3cBqiA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pc0kazKsvlCfPs4Z3xYAx0puK+inFDLkK4qFrkNh8zKe4t1UwmC8qYzYiWmHRUPHJ lcOj9w/9965gZb+M30Y1vBvNU6rkgVBW2tWol+SKtsndToHXvY1LL79b/XeZlWVird HZ2kQbcUuscBK38s/3Vd3Z0lD9d8caViEk02OudksTno6ezB//2npADfKRHfA4w9Kz jqKTO4NWB5faullFHz+7PG8dUi91obE6Mlv4L5GYCm5dYuICUeUov9ll9L3GRLjSn4 HyRxjgh3gKM3QWOitiqCLDCLF+Ro9XzjqmDHH5G18pQXJ7Qi6wDn+01NMhT+EDARgp XWdqR+sSu+/ig== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=pc0kazKs Subject: Re: [Intel-wired-lan] [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Menzel , Maciej Fijalkowski , Jesper Dangaard Brouer , Larysa Zaremba , netdev@vger.kernel.org, Alexander Duyck , Ilias Apalodimas , Yunsheng Lin , linux-kernel@vger.kernel.org, Eric Dumazet , Michal Kubiak , intel-wired-lan@lists.osuosl.org, David Christensen , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 30 Nov 2023 17:45:10 +0100 Alexander Lobakin wrote: > > Meh, this way the stats won't survive ifdown/ifup cycles as usually > > page_pools get destroyed on ifdown :z > > In that patch, I backup the PP stats to a device-lifetime container when > > the pool gets destroyed, maybe we could do something similar? > > I still can pull the PP stats to the driver before destroying it, but > there's no way to tell the PP I have some archived stats for it. Maybe > we could have page_pool_params_slow::get_stats() or smth like this? Why do you think the historic values matter? User space monitoring will care about incremental values. It's not like for page pool we need to match the Rx packet count. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan