From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16F17C4167B for ; Mon, 4 Dec 2023 22:22:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 8416681FFC; Mon, 4 Dec 2023 22:22:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8416681FFC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701728545; bh=rnTeIQ52svSY1QAAXyf3JYFtzCAmabTDVWZnz2xnkb4=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=8lH5+2tWqI/YLw8O7DSxMRns0s+0Yv7cp2g4SRZPDPOQ05WN61en9ehKSQNb1h5po lNG+WHYsQsrrRJwyay463yQEoWl+L8fu8HCAXYFsnbGbER+N7a84JNgnY6F0fQltRx scBHhFlQ5KTwAHJtGzbjIUX8QJTV492g0PpdzIuHC3eAMLhGkCg+0inUHNlHDiCE88 rX6VPjZjfpjHW0o9KKpyqpSlhdYFT9w8eel27fVACD2rO9qamsm/HCZOz8z6PV3GEE SykPXUbPkKXhhgo3L/syyIjWD1ERKUZnYAamrr5jvbWfSrHrNt80MjJD3fZYJrZujm +689aD+5QIdBg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X8FFDAs05lRV; Mon, 4 Dec 2023 22:22:24 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 985708206C; Mon, 4 Dec 2023 22:22:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 985708206C Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C22971BF303 for ; Mon, 4 Dec 2023 22:22:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A6F684173E for ; Mon, 4 Dec 2023 22:22:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org A6F684173E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iR2Zx0oIKAxO for ; Mon, 4 Dec 2023 22:22:22 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp4.osuosl.org (Postfix) with ESMTPS id E52DE41721 for ; Mon, 4 Dec 2023 22:22:21 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E52DE41721 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 4C6DCB811BF; Mon, 4 Dec 2023 22:22:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BB28C433C8; Mon, 4 Dec 2023 22:22:18 +0000 (UTC) Date: Mon, 4 Dec 2023 14:22:17 -0800 From: Jakub Kicinski To: Johannes Berg Message-ID: <20231204142217.176ed99f@kernel.org> In-Reply-To: <69c0fa67c2b0930f72e99c19c72fc706627989af.camel@sipsolutions.net> References: <20231204200710.40c291e60cea.I2deb5804ef1739a2af307283d320ef7d82456494@changeid> <20231204200038.GA9330@merlins.org> <20231204203622.GB9330@merlins.org> <24577c9b8b4d398fe34bd756354c33b80cf67720.camel@sipsolutions.net> <20231204205439.GA32680@merlins.org> <20231204212849.GA25864@merlins.org> <69c0fa67c2b0930f72e99c19c72fc706627989af.camel@sipsolutions.net> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701728538; bh=keW5i8qebroJtN8Z6PS/TiYKwWuHQIjV6wam4mPyNsI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WORYnH/2G61hGitGbL/VX0CUdq2C3ir2YM3iq+lAEOW3m4uhP9BqJvG7jpzljumzn DKPhrKj42dPuYZW+/f1g9cZZ4Bgtuvi8Ja0SlhyUhyNNKuMmap/f205KqCKeJ+rSk+ nXx1mkNx9EHilNd1VHUohfJ1zeWVVeXqAgzBhbkYFQW1UqLI/GSK60woG2CIm8clvi GTcNDErjYJHF6Xl6Vb2l5ioa1RnsiSdifLjQAotWeDPf8S6WGvc6SvLRVjiimIg/7N y3e4qBcW9a/AINb42RtyctTvVzl8MDlzwtmmO/wd2xYMJh/zbpqzfEonk79fkwIvs2 vu6SHEA0x0yAw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=WORYnH/2 Subject: Re: [Intel-wired-lan] [RFC PATCH] net: ethtool: do runtime PM outside RTNL X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Marc MERLIN , Jesse Brandeburg , Tony Nguyen , intel-wired-lan@lists.osuosl.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 04 Dec 2023 22:32:25 +0100 Johannes Berg wrote: > Well, I was hoping that > > (a) ethtool folks / Jakub would comment if this makes sense, but I > don't see a good reason to do things the other way around (other > than "code is simpler"); and My opinion on RPM is pretty uneducated. But taking rtnl_lock to resume strikes me as shortsighted. RPM functionality should be fairly self-contained, and deserving of a separate lock. Or at the very least having looked at the igc RPM code in the past, I'm a bit cautious about bending the core to fit it, as it is hardly a model... > (b) Intel wired folks could help out with getting the patch across the > finish line, seeing how their driver needs it :) I think the dev > get/put needs to use the newer API, but I didn't immediately see > how that works locally in a function without an allocated tracker _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan