From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F6C9C4167B for ; Tue, 5 Dec 2023 20:49:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BAE1560EED; Tue, 5 Dec 2023 20:49:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BAE1560EED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701809349; bh=+eryzdLUYfzg+PPh/VQeygQB3wQ7FE6zEAK+Qx5A2u8=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Sg0JQtbL4v2M76SMfQ3aQefW9Aco27ig9bNNnRGvaMSpVyVuVMO6pcWKF44yAjOsr So2C8PwlquJVP++aErjIj88Jj6Hg5dqZk2JedM0PsaK1dlcWFvVFuzv9A4ugqhts5u h47jWG6nbImB3yQt4O1GLJwf7qFCGXCSqZq4GSytyZopIE7N7S6QCiQ6gd9ekG7aZY 0O6NBLKEfEnigErBXN7VQxuynRVSxch94vrfIpaFKEpaYXJOsrLh8pmGolFK5cfWDO Lvj4c4rS4j8nZZKJnTf3hEZ89Cq2qhUWk8Wj7EFzH/qHdSv88wsSJwDijZRe733SCx fAxO7GguZWo8A== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tSXgTwT7iMIc; Tue, 5 Dec 2023 20:49:09 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id CA24861067; Tue, 5 Dec 2023 20:49:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CA24861067 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 6B9C91BF593 for ; Tue, 5 Dec 2023 20:49:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3D17282AF5 for ; Tue, 5 Dec 2023 20:49:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3D17282AF5 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Lu2HpCQ21PU for ; Tue, 5 Dec 2023 20:49:05 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id 044448126B for ; Tue, 5 Dec 2023 20:49:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 044448126B Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BD2F7617AB; Tue, 5 Dec 2023 20:49:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83137C433C7; Tue, 5 Dec 2023 20:49:00 +0000 (UTC) Date: Tue, 5 Dec 2023 20:48:58 +0000 From: Simon Horman To: Ivan Vecera Message-ID: <20231205204858.GY50400@kernel.org> References: <20231130193135.1580284-1-ivecera@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231130193135.1580284-1-ivecera@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701809342; bh=fed1Khe3LcDNw8l1xszLr/0ELbkoHU+0quBAU6lvWFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U4wAHStvUOAeCeta1YoWNlWxK5F+9eKD9UjWj2vao2iGNiI2rq+ii1dbijNu8FVXD /ElX0695XmWiW2gKNDytWMDyF1gcWq1MnwuIiZallMJAbMhAZdcV8BywQshbFveNgg OjMWttWxesqigO7tQqKMKI+83MxJKY/VQrROV42lhW0vQ9lkCZVKDyA9Zl5yCibn54 OGK7qPLs/CSP08WwFLJb2X3QEESeNNoXe8RywB6U3kqjAUhbC3tiWk3syeUlK7lxc0 HfSRl6YNyBlCRMqgkg383gGVjT/vMpZqNmvS6TUk6oCRBxSSyYRv/EvjheM/HW+Cio Wry5devnCRNDw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=U4wAHStv Subject: Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix wrong mask used during DCB config X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Jesse Brandeburg , Arkadiusz Kubalewski , Aleksandr Loktionov , Eric Dumazet , Tony Nguyen , "moderated list:INTEL ETHERNET DRIVERS" , Jakub Kicinski , Paolo Abeni , "David S. Miller" , open list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Nov 30, 2023 at 08:31:34PM +0100, Ivan Vecera wrote: > Mask used for clearing PRTDCB_RETSTCC register in function > i40e_dcb_hw_rx_ets_bw_config() is incorrect as there is used > define I40E_PRTDCB_RETSTCC_ETSTC_SHIFT instead of define > I40E_PRTDCB_RETSTCC_ETSTC_MASK. > > The PRTDCB_RETSTCC register is used to configure whether ETS > or strict priority is used as TSA in Rx for particular TC. > > In practice it means that once the register is set to use ETS > as TSA then it is not possible to switch back to strict priority > without CoreR reset. > > Fix the value in the clearing mask. > > Fixes: 90bc8e003be2 ("i40e: Add hardware configuration for software based DCB") > Signed-off-by: Ivan Vecera Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan