From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41D0DC4167B for ; Wed, 6 Dec 2023 21:25:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C0D8540267; Wed, 6 Dec 2023 21:25:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C0D8540267 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701897922; bh=hC7DGtd/3+brhDPeBljDderyJe+0DcInn69Zs+yiNmU=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=WU+4+aYVKfxvKcRRgN+GpjU00wVR8CM2eDJrgu1DtHdiwcooLxtv7hCkWSRn3y/gU aNCMlTmyvuUQmy9Sk8BqmaUoY6KPu3tDTBrNydsEnVz/DMFo8KxaqsC1o+klf0ycSC ch56d8UIpeI/qmVti+ZK5lV7RAwDcF2W8wL1de9NPwDPiF190U5abe0gULCAZ4miDX WtUPigFXyxrDruT4OeyZ1FqqeccdQIrYox+uZAjizm796IrmTzQcwxYuj0JFON4SaO 1sSvZDs1aURRq/YmLkert4mrKZlUe+rbcooRPE3Ul2u+HbNvsx7TIbUQtcWTCsLgyY yer0UnnC3+BVw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gumw0-zRfOFZ; Wed, 6 Dec 2023 21:25:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id B4BC240907; Wed, 6 Dec 2023 21:25:21 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B4BC240907 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5CBA01BF2C1 for ; Wed, 6 Dec 2023 21:25:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2BD5040339 for ; Wed, 6 Dec 2023 21:25:20 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2BD5040339 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZWCXZdRtPRh4 for ; Wed, 6 Dec 2023 21:25:19 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp2.osuosl.org (Postfix) with ESMTPS id CF2A3400C8 for ; Wed, 6 Dec 2023 21:25:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org CF2A3400C8 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A8F84CE20C3; Wed, 6 Dec 2023 21:25:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85679C433C8; Wed, 6 Dec 2023 21:25:12 +0000 (UTC) Date: Wed, 6 Dec 2023 21:25:09 +0000 From: Simon Horman To: Aleksandr Loktionov Message-ID: <20231206212509.GA50400@kernel.org> References: <20231129102311.2780151-1-aleksandr.loktionov@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231129102311.2780151-1-aleksandr.loktionov@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701897913; bh=0K/Q3+TV9b4ZKPISgc1t6BvtY9or0a9QPAxTEXr8000=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UqiOM5j1vK8ZL65l8ntjuTP2qD/pl+mPCCUKXQO4+X4mU06JmF7+kfojbILGrQEKJ WQOLIdfTwdhzvy7DJUH2FvEKOsVSA59/qpvtbpMeLUjiCLvr8xx/nbyMF/5qsDMETN wve6Jmvz+K1ThHXfTHVc23uQqJfQNxou+jSwX9uDnjMVKmjQNqGav2HqAjqSzYJL6/ yfOcpX+eWQMD5MomJT9QOVGKoKl+QbAhv/WYIJdL6pg9iBS4qmaKDne0AD3BI1cW/X F3E4gCGapW/P/iOB5N8mLXvK89vM1qtK2dXoHBr48IuzYR1ZvDIi/B90OF3Kl2W63b 1bGWuI2xHlIyw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=UqiOM5j1 Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] i40e:Fix filter input checks to prevent config with invalid values X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: anthony.l.nguyen@intel.com, Sudheer Mogilappagari , Andrii Staikov , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Nov 29, 2023 at 11:23:11AM +0100, Aleksandr Loktionov wrote: > From: Sudheer Mogilappagari > > Prevent VF from configuring filters with unsupported actions or use > REDIRECT action with invalid tc number. Current checks could cause > out of bounds access on PF side. > > Fixes: e284fc280473 ("i40e: Add and delete cloud filter") > Reviewed-by: Andrii Staikov > Signed-off-by: Sudheer Mogilappagari > Signed-off-by: Aleksandr Loktionov > --- > v1->v2 add 'Fixes:' tag into commit message Hi Aleksandr and Sudheer, Some minor nits from my side: * Probably there should be a space after 'i40e:' in the subject. * v2 was posted not long after v1. Please consider allowing 24h between posts. Link: https://docs.kernel.org/process/maintainer-netdev.html The above notwithstanding, this looks good to me. Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan