From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4777C4332F for ; Tue, 12 Dec 2023 10:01:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 748CA60B69; Tue, 12 Dec 2023 10:01:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 748CA60B69 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1702375309; bh=tKI8if3NQm1r25IxA7ri+02Xa/Hh4Lc8KiZaOVBnLIA=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=oZpuELcW98UMKE+YB9NEMQZfqErrg08CrXqzN41p3NCxTlKyXKKW8PnzIlnRnhmLI P1WFxEXx15ErBrdCpW6ppP736KgEMsv3F0h8iP/WColwQSVqGlBjgH+Dw0R+Rm/GkC aNxpKe15DkSbIuPQUP12sHYYc5VunUWO5STzey1xGTH/oyvNVBS7Mx5VBc8xquhp1t qJgTw/RKAWTDoUXt9VpxBzM8gmEOSQbkRfoU8mcu9aJjXRGPrtFEM8JfLohXJEB5UE Iv+mZ0Nmiqy4KoZ5YTS81M8g4t1/KmZ70CrJSMQpjRLrHtBRJEDNyjINQTn0wY2b2N vslZHAKEFaoYw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N0h0ibQTj2HU; Tue, 12 Dec 2023 10:01:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 7BE1D60E13; Tue, 12 Dec 2023 10:01:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7BE1D60E13 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D89AA1BF383 for ; Tue, 12 Dec 2023 10:01:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AFA1040266 for ; Tue, 12 Dec 2023 10:01:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org AFA1040266 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nd98WiZiyemx for ; Tue, 12 Dec 2023 10:01:46 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 1C04240267 for ; Tue, 12 Dec 2023 10:01:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1C04240267 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CB03D6176A; Tue, 12 Dec 2023 10:01:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C1C6C433C8; Tue, 12 Dec 2023 10:01:43 +0000 (UTC) Date: Tue, 12 Dec 2023 10:01:41 +0000 From: Simon Horman To: Grzegorz Nitka Message-ID: <20231212100141.GV5817@kernel.org> References: <20231206192919.3826128-1-grzegorz.nitka@intel.com> <20231206192919.3826128-3-grzegorz.nitka@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231206192919.3826128-3-grzegorz.nitka@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702375304; bh=B+5T+s4PK5i1mJ0rTjs0h4mORh1VsN0iffa+WjrSqB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BPz4BfaBbLa4e3su/aPgC6VkI/bt02KQ5FkakG1gxwWir+3rfjIo8IQ/vVFpQSRAA nQYbAGXs0reTFq8IwAnD0Ks3Rk3yoqos8S3b/pyZlBzoQPYmPXVQYE3EsSFwOozeeH SrMnBlq7Cr5R3Yq77t1XRqR5EAAA+LQgQtY2czmdPP1jKMcECXfw0uhZxi2iIw3ONQ +EK2UIHT77JcMuTN0GbKUlMaRLmEtSTgFbwQoNLYH/xET9rjGAhZIgd/HmzGK9teuO DZ3avsu66QOSF/7VyTxS2hp7dK4L02OgPSIXOfm2DYdWA+Q2dG+HTJpcpvRt47T+RL yJKD+LiS1JV1g== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=BPz4BfaB Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/3] ice: Add helper function ice_is_generic_mac X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Anirudh Venkataramanan , intel-wired-lan@lists.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Dec 06, 2023 at 08:29:18PM +0100, Grzegorz Nitka wrote: > E800 series devices have a couple of quirks: > 1. Sideband control queues are not supported > 2. The registers that the driver needs to program for the "Precision > Time Protocol (PTP)" feature are different for E800 series devices > compared to other devices supported by this driver. > > Both these require conditional logic based on the underlying device we > are dealing with. > > The function ice_is_sbq_supported added by commit 8f5ee3c477a8 > ("ice: add support for sideband messages") addresses (1). > The same function can be used to address (2) as well > but this just looks weird readability wise in cases that have nothing > to do with sideband control queues: > > if (ice_is_sbq_supported(hw)) > /* program register A */ > else > /* program register B */ > > For these cases, the function ice_is_generic_mac introduced by this > patch communicates the idea/intention better. Also rework > ice_is_sbq_supported to use this new function. > As side-band queue is supported for E825C devices, it's mac_type is > considered as generic mac_type. > > Co-developed-by: Anirudh Venkataramanan > Signed-off-by: Anirudh Venkataramanan > Signed-off-by: Grzegorz Nitka Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan