From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44F9BC4332F for ; Thu, 14 Dec 2023 09:56:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 019EC61B11; Thu, 14 Dec 2023 09:56:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 019EC61B11 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1702547813; bh=42+q5lTL0C8d5tU+1ykDDLRys5pmSUEj3cvsWPIKL0s=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=tOM1NuZse/wZH+pq/Cno/4FEYS2Ytyi/Y1NCb/j9LCpsgcVguhrd+4xyy7BGNYWJm C2s36cZjHW/uuxgap+4OMLPFwewoBCzEO5bb6oSSEe3tfDN2WDEOrpVWqPZ22A2tTS nsz+sFTNfETe0QUBeEV+Cg27EL+bGGu0d0ELPfZ5B4EhgDEJryNsuEC52n4OylUr+j Jct3A5vLuAMW+Hj8KVUTwUIv5WmA2Nwug2nmD1n1cmtvh+Nie0o1X/Giahisb+MmYM 4omIA6khvjfbjTMZlUUNi/KdsJmCkb5HM45to8d7kXihC1d5bWwmJHdTsidEdckOKR 3L8jjOqSVcEJQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1LSgUjVIpzgt; Thu, 14 Dec 2023 09:56:52 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id F205C61B19; Thu, 14 Dec 2023 09:56:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org F205C61B19 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C7F131BF59D for ; Thu, 14 Dec 2023 09:56:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9F277420AA for ; Thu, 14 Dec 2023 09:56:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9F277420AA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pzil6Imgnsh6 for ; Thu, 14 Dec 2023 09:56:50 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp4.osuosl.org (Postfix) with ESMTPS id D68EF420A8 for ; Thu, 14 Dec 2023 09:56:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D68EF420A8 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 38E6BB8218C; Thu, 14 Dec 2023 09:56:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44180C433C7; Thu, 14 Dec 2023 09:56:45 +0000 (UTC) Date: Thu, 14 Dec 2023 09:56:42 +0000 From: Simon Horman To: Jedrzej Jagielski Message-ID: <20231214095642.GK5817@kernel.org> References: <20231212104642.316887-1-jedrzej.jagielski@intel.com> <20231212104642.316887-3-jedrzej.jagielski@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231212104642.316887-3-jedrzej.jagielski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702547806; bh=W3wMJj/fE7ypeh3zjGSazjPb1WJfR/FlhxIOKm/d7cw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nCP9cDXorxisgUlARQcNK735G1z84WztdwB2hGQeUosm9qig4fRoIkCTRSe7XdJPE JOX85LENwe/8vOiI/YxaaMwM7c1b958CGph+hMb1JIg2X50rfky5wfKZJhQNtUMGOX ljYAGm3+Ymajp1k71gcSNJCyKLBp+6k4R18JiGOoc2UuXWkx6TCaiEVIjoW2wTPDro zrSLNVip6U+qdJxETGP1yMdm0nxlUYVKuJqIGL9P5fjO3Xb53wv0xTrB5QRPotZYhC RL4Lxtkaz576t+XaRhKshgVGitzfRCwzYnXtjI8j/huTCvNo1ZwmdiAjJKLDs6+2+o nfxb4Z/WGQIEg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=nCP9cDXo Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 2/2] ixgbe: Refactor returning internal error codes X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jacob Keller , anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, Przemek Kitszel , netdev@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Dec 12, 2023 at 11:46:42AM +0100, Jedrzej Jagielski wrote: > Change returning codes to the kernel ones instead of > the internal ones for the entire ixgbe driver. > > Reviewed-by: Jacob Keller > Reviewed-by: Przemek Kitszel > Signed-off-by: Jedrzej Jagielski > --- > v3: do not use ENOSYS; rebase > --- > .../net/ethernet/intel/ixgbe/ixgbe_82598.c | 36 ++--- > .../net/ethernet/intel/ixgbe/ixgbe_82599.c | 61 ++++---- > .../net/ethernet/intel/ixgbe/ixgbe_common.c | 145 ++++++++---------- > .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 26 ++-- > drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c | 34 ++-- > drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 1 - > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 84 +++++----- > .../net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 39 ----- > drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 44 +++--- > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 109 ++++++------- > 12 files changed, 266 insertions(+), 317 deletions(-) Thanks Jedrzej, this is a nice cleanup. Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan