From: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
To: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
aleksandr.loktionov@intel.com
Cc: netdev@vger.kernel.org, Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: [Intel-wired-lan] [PATCH iwl-next] i40e: add trace events related to SFP module IOCTLs
Date: Thu, 14 Dec 2023 15:10:12 +0100 [thread overview]
Message-ID: <20231214141012.224894-1-aleksandr.loktionov@intel.com> (raw)
Add trace events related to SFP module IOCTLs for troubleshooting.
Riewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
---
src/CORE/i40e_ethtool.c | 5 +++++
src/CORE/i40e_trace.h | 18 ++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/src/CORE/i40e_ethtool.c b/src/CORE/i40e_ethtool.c
index 0838566..e9d9d4b 100644
--- a/src/CORE/i40e_ethtool.c
+++ b/src/CORE/i40e_ethtool.c
@@ -1057,6 +1057,7 @@ static int i40e_get_link_ksettings(struct net_device *netdev,
ethtool_link_ksettings_zero_link_mode(ks, supported);
ethtool_link_ksettings_zero_link_mode(ks, advertising);
+ i40e_trace(ioctl_get_link_ksettings, pf, hw_link_info->link_info);
if (link_up)
i40e_get_settings_link_up(hw, ks, netdev, pf);
else
@@ -7219,9 +7220,12 @@ static int i40e_get_module_info(struct net_device *netdev,
modinfo->eeprom_len = I40E_MODULE_QSFP_MAX_LEN;
break;
default:
+ i40e_trace(ioctl_get_module_info, pf, ~0UL);
netdev_dbg(vsi->netdev, "SFP module type unrecognized or no SFP connector used.\n");
return -EOPNOTSUPP;
}
+ i40e_trace(ioctl_get_module_info, pf, (((u64)modinfo->type) << 32) |
+ modinfo->eeprom_len);
return 0;
}
@@ -7244,6 +7248,7 @@ static int i40e_get_module_eeprom(struct net_device *netdev,
u32 value = 0;
int i;
+ i40e_trace(ioctl_get_module_eeprom, pf, ee ? ee->len : 0U);
if (!ee || !ee->len || !data)
return -EINVAL;
diff --git a/src/CORE/i40e_trace.h b/src/CORE/i40e_trace.h
index cac0f7c..f54fc36 100644
--- a/src/CORE/i40e_trace.h
+++ b/src/CORE/i40e_trace.h
@@ -428,6 +428,24 @@ DEFINE_EVENT(
TP_ARGS(pf, val));
+DEFINE_EVENT(
+ i40e_ioctl_template, i40e_ioctl_get_module_info,
+ TP_PROTO(struct i40e_pf *pf, u64 val),
+
+ TP_ARGS(pf, val));
+
+DEFINE_EVENT(
+ i40e_ioctl_template, i40e_ioctl_get_module_eeprom,
+ TP_PROTO(struct i40e_pf *pf, u64 val),
+
+ TP_ARGS(pf, val));
+
+DEFINE_EVENT(
+ i40e_ioctl_template, i40e_ioctl_get_link_ksettings,
+ TP_PROTO(struct i40e_pf *pf, u64 val),
+
+ TP_ARGS(pf, val));
+
DECLARE_EVENT_CLASS(
i40e_nvmupd_template,
--
2.31.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next reply other threads:[~2023-12-14 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 14:10 Aleksandr Loktionov [this message]
2023-12-14 14:20 ` [Intel-wired-lan] [PATCH iwl-next] i40e: add trace events related to SFP module IOCTLs Paul Menzel
2023-12-14 17:05 ` Loktionov, Aleksandr
2023-12-18 23:08 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214141012.224894-1-aleksandr.loktionov@intel.com \
--to=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox