From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BCA7C35274 for ; Fri, 15 Dec 2023 12:07:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 984E940883; Fri, 15 Dec 2023 12:07:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 984E940883 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1702642039; bh=dAWb9FUXTuCmhtavmLGn+9OGxmU3w1yn/wyFayXlCro=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=8FOddUOVyTxZD69su+nxtJOTL4OMsx6uIK22EsC6zvSnlibX/EZTREomk1uQtzwb9 OZzMAaR/pv17oanLejZBmy2WTdYwzdmRw3dPGnGwkOpB7aU4q18JM4Ip6aLRCHaCP0 HkHkNz3NhS/ofBaQwu2DMMTfyV4iiVCDJF8kvUYFvHsCJXAo85w/paxdo3bRaCqbJL fwSpGhagVn46D0buNfV0zuVsUbYeAu1D/K9Iomt6Lh2JEP1KK9tTfOBpzxHJoHqJVt f/VyIG6xXHoeUBJgyr2aQ9y/flV0Xjn0acQBkzyKS5QAc5Wn/oz53sJCHO+37Cnhpn FoAsW4uJ7M0/w== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2W-3KS03zmve; Fri, 15 Dec 2023 12:07:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id EE47C409AB; Fri, 15 Dec 2023 12:07:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EE47C409AB Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 00AA61BF338 for ; Fri, 15 Dec 2023 12:07:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D8E4F60F2A for ; Fri, 15 Dec 2023 12:07:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D8E4F60F2A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g_kXzgTMWPIC for ; Fri, 15 Dec 2023 12:07:14 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id 722CE61003 for ; Fri, 15 Dec 2023 12:07:14 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 722CE61003 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CABEDCE2DA3; Fri, 15 Dec 2023 12:07:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CBCDC433C7; Fri, 15 Dec 2023 12:07:07 +0000 (UTC) Date: Fri, 15 Dec 2023 12:07:05 +0000 From: Simon Horman To: Dave Ertman Message-ID: <20231215120705.GI6288@kernel.org> References: <20231211211928.2261079-1-david.m.ertman@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231211211928.2261079-1-david.m.ertman@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702642029; bh=4tWBusSmYJLXRPcmH1m3PdCWbkmgh9r9Ow3XFChuPbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MhhcqzWFthAIlZ+JK7dmrjjP06nDzIhoI1jUNBVORrRM2JI2PZEeTMTsG3wzoXl8w DWj1k7093eDUWJZH63j8c+/TRvL0Y0eqrZ1dTkWTRTmgPm92aud0RMCLjaOoVwu9EV 6Q4IqXqLXMdYk6Qj79lTb/PeRgJDvZFaPl/AcmAEfpBm87zOYKisQ5udBtZlvLcR6K 8bfXuRqVsq1vYlCwXbDX8ufhANUfvdZobkKVGNeSZZfT8HTKLyhGwTFrQzrjda1hg2 CeOsZFTo1Cq2dfBmzNDXzQivWIzp3LORgSmfZ+eYalSYrv+gvo+r9ImzSgwtKl/nDf d0BZwNdHPBrxg== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=MhhcqzWF Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: alter feature support check for SRIOV and LAG X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jesse Brandeburg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Dec 11, 2023 at 01:19:28PM -0800, Dave Ertman wrote: > Previously, the ice driver had support for using a hanldler for bonding > netdev events to ensure that conflicting features were not allowed to be > activated at the same time. While this was still in place, additional > support was added to specifically support SRIOV and LAG together. These > both utilized the netdev event handler, but the SRIOV and LAG feature was > behind a capabilities feature check to make sure the current NVM has > support. > > The exclusion part of the event handler should be removed since there are > users who have custom made solutions that depend on the non-exclusion of > features. > > Wrap the creation/registration and cleanup of the event handler and > associated structs in the probe flow with a feature check so that the > only systems that support the full implementation of LAG features will > initialize support. This will leave other systems unhindered with > functionality as it existed before any LAG code was added. > > Fixes: bb52f42acef6 ("ice: Add driver support for firmware changes for LAG") > Reviewed-by: Jesse Brandeburg > Signed-off-by: Dave Ertman Hi Dave, I'm interpreting this as fixing a regression of an existing feature. In that context: Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan