From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3542C4167B for ; Sat, 16 Dec 2023 04:54:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3A8A642178; Sat, 16 Dec 2023 04:54:20 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3A8A642178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1702702460; bh=FIvaZNjUQiThhexG5hPzHi+w1ZuMF3bi9jUJ3b+Jm4o=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=8Q35jZcXf/+feei2my7EOp29iCgoZCDla11jdy+DGQe1MYqVCRZ6rbc4kWrqUFHgv 260WFN85/GDM6B2dKzgWsnQGpp1Fz5ZJ2Ddhli9Pr6WrJ3q30/gA/g+GgECn79x80M bhmNGcu5IdZapXF95kZmZAezZj6zB8EwSyH6ZejCv8KE7uQWYjUsqCbmV0U2yU5Zra 2Fu5y3T+o8ohI1ZoJ0ctJvFqa7m2NByu9RULJZUTDC509VmzGFYi+QyJzz/tkDswbo HvtYb0S7na2VX6iT2gYPF4el4UHhy31cqgUjOi+9ULxkb8BeopZYJ7/GtrqRMTZD71 YCp7I0KFer6mA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2tmCjWIErhWG; Sat, 16 Dec 2023 04:54:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 46E28421CB; Sat, 16 Dec 2023 04:54:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 46E28421CB Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 4ED6D1BF2FB for ; Sat, 16 Dec 2023 04:54:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 28DAE61026 for ; Sat, 16 Dec 2023 04:54:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 28DAE61026 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yo6pm8wXj2Y8 for ; Sat, 16 Dec 2023 04:54:13 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3439C60B42 for ; Sat, 16 Dec 2023 04:54:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3439C60B42 X-IronPort-AV: E=McAfee;i="6600,9927,10925"; a="385777638" X-IronPort-AV: E=Sophos;i="6.04,280,1695711600"; d="scan'208";a="385777638" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2023 20:54:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10925"; a="751162050" X-IronPort-AV: E=Sophos;i="6.04,280,1695711600"; d="scan'208";a="751162050" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 15 Dec 2023 20:54:04 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rEMga-0001Ac-1s; Sat, 16 Dec 2023 04:54:01 +0000 Date: Sat, 16 Dec 2023 12:53:43 +0800 From: kernel test robot To: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Message-ID: <202312161212.D5tju5i6-lkp@intel.com> References: <20231215171020.687342-21-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231215171020.687342-21-bigeasy@linutronix.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702702453; x=1734238453; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hbCzV9FRyfR9WQHmArq5wOV7koxOXpFFbjy3k1iOVwE=; b=ATQSAxiNUZlxiXxOAsPXv7Pg+hAZe8eznhzIuVM2oWjF1QN8W9b0YAGN bKc4tBxClMbaMQCHdnyHPHhk7jF7DQutwuuN/S2N4kXTovQL4u04N2h3J iDXXWw7d0U6lcvFZCx6VSEMFoXn2IY30RyMYEi20NlBEhB3suM7l5KOTJ 36Wa99rXCCMDwC8AatCbOOnbeqjTg5xJ6yhIkKINsLMtABJSFNV+JpgNO kvubtB37vWENApwBWDpJaHfpe3hDnOxJVMe62UIT65MQddC4KgE5mDm7b nSbE1L2tzfGL9pQWIVCyT4RHo9vk8S7glDp0aSZZ8XxlUxwbeei6/Wd+Z g==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ATQSAxiN Subject: Re: [Intel-wired-lan] [PATCH net-next 20/24] net: intel: Use nested-BH locking for XDP redirect. X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jesper Dangaard Brouer , Daniel Borkmann , Peter Zijlstra , intel-wired-lan@lists.osuosl.org, Frederic Weisbecker , llvm@lists.linux.dev, John Fastabend , Alexei Starovoitov , bpf@vger.kernel.org, Jesse Brandeburg , Eric Dumazet , Ingo Molnar , Tony Nguyen , Waiman Long , oe-kbuild-all@lists.linux.dev, Jakub Kicinski , Thomas Gleixner , Paolo Abeni , Will Deacon , Boqun Feng , Sebastian Andrzej Siewior Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hi Sebastian, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/locking-local_lock-Introduce-guard-definition-for-local_lock/20231216-011911 base: net-next/main patch link: https://lore.kernel.org/r/20231215171020.687342-21-bigeasy%40linutronix.de patch subject: [PATCH net-next 20/24] net: intel: Use nested-BH locking for XDP redirect. config: arm-defconfig (https://download.01.org/0day-ci/archive/20231216/202312161212.D5tju5i6-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231216/202312161212.D5tju5i6-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312161212.D5tju5i6-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/net/ethernet/intel/igb/igb_main.c:8620:3: error: cannot jump from this goto statement to its label goto xdp_out; ^ drivers/net/ethernet/intel/igb/igb_main.c:8624:2: note: jump bypasses initialization of variable with __attribute__((cleanup)) guard(local_lock_nested_bh)(&bpf_run_lock.redirect_lock); ^ include/linux/cleanup.h:142:15: note: expanded from macro 'guard' CLASS(_name, __UNIQUE_ID(guard)) ^ include/linux/compiler.h:180:29: note: expanded from macro '__UNIQUE_ID' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE' #define ___PASTE(a,b) a##b ^ :52:1: note: expanded from here __UNIQUE_ID_guard753 ^ 1 error generated. vim +8620 drivers/net/ethernet/intel/igb/igb_main.c b1bb2eb0a0deb0 Alexander Duyck 2017-02-06 8608 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8609 static struct sk_buff *igb_run_xdp(struct igb_adapter *adapter, 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8610 struct igb_ring *rx_ring, 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8611 struct xdp_buff *xdp) 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8612 { 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8613 int err, result = IGB_XDP_PASS; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8614 struct bpf_prog *xdp_prog; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8615 u32 act; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8616 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8617 xdp_prog = READ_ONCE(rx_ring->xdp_prog); 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8618 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8619 if (!xdp_prog) 9cbc948b5a20c9 Sven Auhagen 2020-09-02 @8620 goto xdp_out; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8621 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8622 prefetchw(xdp->data_hard_start); /* xdp_frame write */ 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8623 d568b111738dbb Sebastian Andrzej Siewior 2023-12-15 8624 guard(local_lock_nested_bh)(&bpf_run_lock.redirect_lock); 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8625 act = bpf_prog_run_xdp(xdp_prog, xdp); 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8626 switch (act) { 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8627 case XDP_PASS: 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8628 break; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8629 case XDP_TX: 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8630 result = igb_xdp_xmit_back(adapter, xdp); 74431c40b9c5fa Magnus Karlsson 2021-05-10 8631 if (result == IGB_XDP_CONSUMED) 74431c40b9c5fa Magnus Karlsson 2021-05-10 8632 goto out_failure; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8633 break; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8634 case XDP_REDIRECT: 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8635 err = xdp_do_redirect(adapter->netdev, xdp, xdp_prog); 74431c40b9c5fa Magnus Karlsson 2021-05-10 8636 if (err) 74431c40b9c5fa Magnus Karlsson 2021-05-10 8637 goto out_failure; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8638 result = IGB_XDP_REDIR; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8639 break; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8640 default: c8064e5b4adac5 Paolo Abeni 2021-11-30 8641 bpf_warn_invalid_xdp_action(adapter->netdev, xdp_prog, act); 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8642 fallthrough; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8643 case XDP_ABORTED: 74431c40b9c5fa Magnus Karlsson 2021-05-10 8644 out_failure: 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8645 trace_xdp_exception(rx_ring->netdev, xdp_prog, act); 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8646 fallthrough; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8647 case XDP_DROP: 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8648 result = IGB_XDP_CONSUMED; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8649 break; 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8650 } 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8651 xdp_out: 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8652 return ERR_PTR(-result); 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8653 } 9cbc948b5a20c9 Sven Auhagen 2020-09-02 8654 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan