From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3FFEC3DA6E for ; Mon, 25 Dec 2023 09:36:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9B0B341521; Mon, 25 Dec 2023 09:36:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9B0B341521 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1703496979; bh=9qQelG5KM9+J/PABmenz9Lq7j3KjruBPA5sadfELbjA=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=MtMhRAMhbwKelhb82I21k1GwMF8vQ9glz+slJS3VeOQNKPTZRcFUE97Y+WMmqe3e3 6ZCsfziTmBfnUj7Nxr2WTbqUywKTI2vB3xM5LU6xPNHv+y1HMBbY/1UCu6Nwxh4xdu FrUHPkdJ6JED9e93mC7YJiVJSzOuKpJPUCKXPcg9bgtjQqRiIYhdl1zAxT2A9T8qmX 3eAFgrhDN5gK+LoPlgKauteB+XQGRM090chaIOI1apD/kxD2kwW2WgXkWvorC4ucJL 4JVDo/ipZoAi3fVxLmHbsUgHk4doGql9pOHWPx9ag5bCCHJCSo51gXOx5nWwOb3lOl CVpaD3uWbl7Qw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ROEI7NmNkP6Z; Mon, 25 Dec 2023 09:36:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 9494F415FD; Mon, 25 Dec 2023 09:36:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9494F415FD Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 899891BF573 for ; Mon, 25 Dec 2023 09:36:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 612AC81A12 for ; Mon, 25 Dec 2023 09:36:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 612AC81A12 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cbCSg7FUGspa for ; Mon, 25 Dec 2023 09:36:15 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id B1E59818C2 for ; Mon, 25 Dec 2023 09:36:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B1E59818C2 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 58CC7B80B0A; Mon, 25 Dec 2023 09:36:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CF67C433C7; Mon, 25 Dec 2023 09:36:11 +0000 (UTC) Date: Mon, 25 Dec 2023 09:36:08 +0000 From: Simon Horman To: Jesse Brandeburg Message-ID: <20231225093608.GE5962@kernel.org> References: <20231206010114.2259388-1-jesse.brandeburg@intel.com> <20231206010114.2259388-2-jesse.brandeburg@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231206010114.2259388-2-jesse.brandeburg@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703496972; bh=pn3mm75zzR2E6GKudky68lgSS4ky7Wdi7kq7bHXdAbQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WCKZ6+EIX7x3icGOSG1PVXG9sHVDdzESu49U5FnsEZrKFsxY4TQdYifoU2AoZqIfD mbd7l0uNYYvdO9Jp1xKxWXwH5oL3HJkCkr51jHnAGTzKKOGChQIYC3Gw9ra7Ae7Zx0 REVsfHnj/MADAUmxEgas/BL8fr5oxCHIHzqkmdteePxi7pQ4DdTMw4T80i+Se5A9EM hFMjG9Rimr65IGbUuvvDh7pLO0qqwoVYcgzI8Tmtn2tttdbP4QowyZyfz5ajm8nkTx 9Jf3VTn+Ah9wrWxLJL6XxuH2qPpB4I1vKdUmNDA6RP9RcEGHiU4vTfOk3Q44fGkcdI NfEsSOR1864Fg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=WCKZ6+EI Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 01/15] e1000e: make lost bits explicit X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, marcin.szycik@linux.intel.com, intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, aleksander.lobakin@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Dec 05, 2023 at 05:01:00PM -0800, Jesse Brandeburg wrote: > For more than 15 years this code has passed in a request for a page and > masked off that page when read/writing. This code has been here forever, > but FIELD_PREP finds the bug when converted to use it. Change the code > to do exactly the same thing but allow the conversion to FIELD_PREP in a > later patch. To make it clear what we lost when making this change I > left a comment, but there is no point to change the code to generate a > correct sequence at this point. > > This is not a Fixes tagged patch on purpose because it doesn't change > the binary output. > > Reviewed-by: Marcin Szycik > Signed-off-by: Jesse Brandeburg Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan