From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1806AC4725D for ; Mon, 22 Jan 2024 11:07:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AA80B416B1; Mon, 22 Jan 2024 11:07:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org AA80B416B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1705921651; bh=nU5rYGS3itVFIYSFlq4h7KTmfnCa0z8VRwez/GcVW+Q=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=BbfcSvUTHmT6fxQFVg3XypvWZ4kKg2VmluQ1ALBOmAC6fDdMME8e5TOafsnkBG48L gvvZa7wajJMVcd1fk/4COzvjmVniPXhsxJL8Oz9DGMHITxyqZpUdnA6wh/iwn6ANvl vS7RWLXfKNYb62/KaOfTjEyi8F96jJnEICcGbjvsmlxwZMQfWeoVDcR8zh/t1O02+o WZAZ+7oak1FE/AatpwtKZ51NY4zaMQQo6i7kSPQ8cX/muV4bv9QWIyry759CsxQL6s 6xCY9LOMXNHoBB+NwXNqlwUG23zDySxGv18mrPVDjjfgMyFqqARCJs88Aar8+A5mYU F4gNkj9kWREJw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m7Uc8jb8Mf-s; Mon, 22 Jan 2024 11:07:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 00F82416C5; Mon, 22 Jan 2024 11:07:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 00F82416C5 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 82D031BF3DC for ; Mon, 22 Jan 2024 11:07:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5A21F60EE0 for ; Mon, 22 Jan 2024 11:07:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5A21F60EE0 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8RQz_fxAvzjS for ; Mon, 22 Jan 2024 11:07:28 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id 98CB460B99 for ; Mon, 22 Jan 2024 11:07:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 98CB460B99 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 855F9B80A26; Mon, 22 Jan 2024 11:07:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0B4DC433F1; Mon, 22 Jan 2024 11:07:21 +0000 (UTC) Date: Mon, 22 Jan 2024 11:07:19 +0000 From: Simon Horman To: Christophe JAILLET Message-ID: <20240122110719.GC126470@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705921644; bh=5gE+Km5fi/TLlf+ZbAr7bjFoCBGdCvtbA843YDHnPdo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IuKILk40lppFwkQ3einuh+aBf9EHDFc+HzB4nd9+TtD9RD8cFXoLb9uH0b4wcO+l5 ZgLolbB4kBvfbwMSNrdrt/DX6AdvlyCth5hF6iWkiIlyoyIRSFCRRp25OxYZNLH3y+ hS6J8bEWWqa7aGoYc/N0uJ5A58jQBo7moXbm94fXOfi+eVUfAEAHY2Rr8blocQIcsO ajf6rqjrYgNlqJcKQ4SMOOBsFcXbNNRAsSAo+eNg6ghbMwFRi9I2q34o76bh7w4Q7n VTvdOtNITDJ0/WmwMVcBlOzG7leefF8TlyW8g72DnSu42/vcq2xUuXF7Zzg8g9L7g8 KhDKkzWdD59sA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=IuKILk40 Subject: Re: [Intel-wired-lan] [PATCH] ixgbe: Fix an error handling path in ixgbe_read_iosf_sb_reg_x550() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-wired-lan@lists.osuosl.org, kernel-janitors@vger.kernel.org, Jesse Brandeburg , linux-kernel@vger.kernel.org, Eric Dumazet , Tony Nguyen , Jeff Kirsher , netdev@vger.kernel.org, Jakub Kicinski , Mark Rustad , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, Jan 20, 2024 at 06:25:36PM +0100, Christophe JAILLET wrote: > All error handling paths, except this one, go to 'out' where > release_swfw_sync() is called. > This call balances the acquire_swfw_sync() call done at the beginning of > the function. > > Branch to the error handling path in order to correctly release some > resources in case of error. > > Fixes: ae14a1d8e104 ("ixgbe: Fix IOSF SB access issues") > Signed-off-by: Christophe JAILLET Reviewed-by: Simon Horman