From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17590C46CD2 for ; Mon, 22 Jan 2024 21:10:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9B7B540108; Mon, 22 Jan 2024 21:10:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9B7B540108 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1705957856; bh=QQuxlIZQ7Oogvx0qykRNuSzmJ0WSw6if2F8B62AR6b4=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=m9Ku1/NLCWHWLKmTmSo2ac4ljMJH75ZU3k6jQWYShmAVVN7LI3r9LJLBdzBRLrWy1 ekIet68tqVHKzaaz/DNVr9MalP+cUeRvHvOoqV5p5iReKKJ3/mmzkZzsYpZnoABaK1 +6m9ZohfcbN/TJLEgrAs7VC5m2pcfdBlZ2USMf5JrTgITwh3DRZyQJHbWveysu6FrP f4PUxlqiPueczNdiPRIDf8mcTAVoN2hnSDBlxsBwdDRqoLx7nOCBEuVTf2ECIChhv4 rv93TDNDB3WyyEVSgqy0HSmA0YLwyVHUkzFaEbTsafsGsVRBL0HApJG0fPtLV4aNo3 1sS0npP+pTbIA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HO5h_UEZVY3d; Mon, 22 Jan 2024 21:10:56 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id B03AC4097C; Mon, 22 Jan 2024 21:10:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B03AC4097C Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5C7FB1BF3A4 for ; Mon, 22 Jan 2024 21:10:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2EE7141A08 for ; Mon, 22 Jan 2024 21:10:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2EE7141A08 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aN7A5sH-s11U for ; Mon, 22 Jan 2024 21:10:53 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6AAC54097C for ; Mon, 22 Jan 2024 21:10:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6AAC54097C Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4D9FF61AF5; Mon, 22 Jan 2024 21:10:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F1D7C43390; Mon, 22 Jan 2024 21:10:49 +0000 (UTC) Date: Mon, 22 Jan 2024 21:10:46 +0000 From: Simon Horman To: Zhipeng Lu Message-ID: <20240122211046.GK126470@kernel.org> References: <20240122173633.3843715-1-alexious@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122173633.3843715-1-alexious@zju.edu.cn> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705957851; bh=TDViGXXDF62YHlJpIBlrEc0F5ODj676gbujRwRqKUtY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L5wjLa6gOcizqQtkvIgi2lycdDBDD1WQZBJR5QPDfYTBF5FHJKR4h3z+x1XnyxSHf +gBBIrzMsUiibgEP7xUUXakoEbnrzasfK6DPRix7wfJbcGjoFHTHoqZWdHohsyMOfB //BfYKXdio7Px8XckjFam7Ko0P2jas24o/UI4r93TPzx5Xxpaf8GtEvlU7ORdwWS/8 XoP4MYf+9KdSUYqMQzqPHazQK4/W7Fvn2R8i5lYJZzTrHWImGB0ANygxK16vYvn/nN TS2OegnnyGrOMjjuhhj4S9BKTfpC6IEDUCjWRx5S/ZBaUzMPme2C61S4+102pwecXi Hn3fMN+zHurKw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=L5wjLa6g Subject: Re: [Intel-wired-lan] [PATCH] i40e: fix a memleak in i40e_init_recovery_mode X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alice Michael , intel-wired-lan@lists.osuosl.org, Jesse Brandeburg , linux-kernel@vger.kernel.org, Eric Dumazet , netdev@vger.kernel.org, Tony Nguyen , Jeff Kirsher , Piotr Marczak , Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jan 23, 2024 at 01:36:33AM +0800, Zhipeng Lu wrote: > In i40e_init_recovery_mode, pf->vsi is allocated without free, causing > a memleak. This patch adds deallocation operations for pf->vsi in each > and every error-handling paths after pf->vsi's. > > Fixes: 4ff0ee1af016 ("i40e: Introduce recovery mode support") > Signed-off-by: Zhipeng Lu Reviewed-by: Simon Horman