From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D558FC47DDB for ; Tue, 23 Jan 2024 17:07:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7F62C4048A; Tue, 23 Jan 2024 17:07:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7F62C4048A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1706029657; bh=mzFunG/m5Xk8Rkt2IYd6rHZjb8+OZpPUGieytD2xXbs=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=VlS1eJgkVgOYEhZOk+r893k4wHCupe8lozGFHzhfynI7cYREN7vn9UgI+HGCHvJeB TEmrfGFQwkXBlvj7PyoVW030v7DDk8AHSMm/dnsCc5JIYtqsbycaxwSv/ztCcSuZ7E SqjcpT8iJMgpNGoEQc6ZvfDoEdwbtRZYLBZEUyUN9ZJPHVq332u86G0/n+oHYbP2Y2 4ZrAJqD12ccDAUkRcTj+CV/xLgBl+203KGC/n+4jfQxgigVNiNEcntR8KoVVIMDHcq F4Ln+sa3IJzFJ+wum52D2GGHZcp0ydj/2ReifetDld4KFF/ntJf+D70kAd5qUV+ZC2 5ZUXvYAMjlC7g== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id StYPrR9MLQGg; Tue, 23 Jan 2024 17:07:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 87A3540491; Tue, 23 Jan 2024 17:07:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 87A3540491 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 9DDA01BF3AE for ; Tue, 23 Jan 2024 17:07:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7629A4191B for ; Tue, 23 Jan 2024 17:07:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7629A4191B X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f_E3o_4x_IYk for ; Tue, 23 Jan 2024 17:07:34 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id EA5E34191A for ; Tue, 23 Jan 2024 17:07:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EA5E34191A Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4373561C0A; Tue, 23 Jan 2024 17:07:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 855C1C433F1; Tue, 23 Jan 2024 17:07:31 +0000 (UTC) Date: Tue, 23 Jan 2024 17:07:29 +0000 From: Simon Horman To: Karol Kolacinski Message-ID: <20240123170729.GM254773@kernel.org> References: <20240123105131.2842935-1-karol.kolacinski@intel.com> <20240123105131.2842935-8-karol.kolacinski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240123105131.2842935-8-karol.kolacinski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706029652; bh=y05+6U/j3fJ0ntOJAyCTQ2S/MJtrJuT/kbavnLl+T2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nGJbio0OGdmtmKdgZlzUjT6+5cJlWI0WnZofCnh3QbgEV5jG2+GxWwD4G5OluOjfr gz2xjbYcUduAvxZ9heWCEmuz+Y9VmCfiXQ5DQpwD/wmLsdMBStVGJIuTuVZc2XDk/v kqt0Uxb1qL+HKBtULxPcWsSb9KV3zwcdkyE5chccvQWR5jPFD77cvdJ3wRYLiqoGk6 k79TqXOBZ+kqYYm2S/MVTu/IL75CNUfwIPu9FUso/44Hsu0fk8mX284QSmbtofJMP2 INt1Rg3d7b77o0VXJHKonJOzAYIFVHdnCrzxCRaBuvzjmYzzkiSHp35iDenodOlAvK 5j3xgBZPCleDg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=nGJbio0O Subject: Re: [Intel-wired-lan] [PATCH v7 iwl-next 7/7] ice: stop destroying and reinitalizing Tx tracker during reset X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jacob Keller , netdev@vger.kernel.org, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jan 23, 2024 at 11:51:31AM +0100, Karol Kolacinski wrote: > From: Jacob Keller > > The ice driver currently attempts to destroy and re-initialize the Tx > timestamp tracker during the reset flow. The release of the Tx tracker > only happened during CORE reset or GLOBAL reset. The ice_ptp_rebuild() > function always calls the ice_ptp_init_tx function which will allocate > a new tracker data structure, resulting in memory leaks during PF reset. > > Certainly the driver should not be allocating a new tracker without > removing the old tracker data, as this results in a memory leak. > Additionally, there's no reason to remove the tracker memory during a > reset. Remove this logic from the reset and rebuild flow. Instead of > releasing the Tx tracker, flush outstanding timestamps just before we > reset the PHY timestamp block in ice_ptp_cfg_phy_interrupt(). > > Signed-off-by: Jacob Keller > Signed-off-by: Karol Kolacinski > Reviewed-by: Jacob Keller Reviewed-by: Simon Horman