From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BAEAC46CD2 for ; Wed, 24 Jan 2024 21:09:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 96E1A40591; Wed, 24 Jan 2024 21:09:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 96E1A40591 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1706130545; bh=tXia9XiqsM8kLitPz0hReQf3P4YJM2LFAmtRzg1DiyY=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=jPrOFBSjl9yrTOS11Uzo4wfLlr4TRytWJlHSBEHLKJ5N8A0juehk7abK2pFm7fbnU r6cfI+KSoV50zrQe2o42kkHG2gH7NeoDOyjXgTDmPHg/FeMBn2h1JM6E/s8PIsNPAA wrTmYmk7v7tRGCq0VF6XfX/pkNCr445iW96zMwlJytAUOwYY25VGp+U85ZRL9Wg9Nv UhYmTnZ3gHNbXSX3nETVgRuD0Bt/JYuuDwXfEkBeHuDzUE5Ig01YNggT9TtnYT1ymZ FDKbJZOe1yg5rGN7NxmW+ApLonLv39xVVT13gY7yj3rkQ8cjku8Recv5ZDGpbzaZBs tyv0BtzN4otEQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QaLLjhO_Sq02; Wed, 24 Jan 2024 21:09:05 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id AB28B40181; Wed, 24 Jan 2024 21:09:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org AB28B40181 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0E2831BF3BF for ; Wed, 24 Jan 2024 21:09:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D5B6F81DFD for ; Wed, 24 Jan 2024 21:09:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D5B6F81DFD X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9b8k0aB92u4T for ; Wed, 24 Jan 2024 21:09:02 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4373C81DF7 for ; Wed, 24 Jan 2024 21:09:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4373C81DF7 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6005A61E91; Wed, 24 Jan 2024 21:09:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90652C433C7; Wed, 24 Jan 2024 21:08:58 +0000 (UTC) Date: Wed, 24 Jan 2024 21:08:55 +0000 From: Simon Horman To: Kurt Kanzenbach Message-ID: <20240124210855.GC217708@kernel.org> References: <20240124082408.49138-1-kurt@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240124082408.49138-1-kurt@linutronix.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706130541; bh=OwqhiirMXNXI3ECk46Nz8ZChmmdmevlnfCw/AuOJ2Do=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o8UhNJRz0hfEcmfLtHLEYE4SKXgEMhIQDPe/he45noNkcGPAK8iEcOLvmb4O/mcw8 uBp+Aop5NdoC0a6TTtMoLHUrp4v7t/61OfQoVL1kAVctzrua0FKMPt3MGEaQaugRHm V/qNjoIV7ujuYYMdHrEw35JIVmAhQEADBwVdDq7r+IA/qm7OR7w4Jd4librmz8m898 9SKkkH8eq/6n0iUnfJlIgzGFrsiwRa+nnWl1P4oChya7GSdw7RtUad+6Clxk0yI7SB Id6bZvKu4JiTO/QAjHz2P8FqWzMtDaunJQpOTLxCxKkGvddlYFv1+t9zFzt/HJ21FD JON5+jjwyEJJg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=o8UhNJRz Subject: Re: [Intel-wired-lan] [PATCH v1 iwl-next] igc: Add support for LEDs on i225/i226 X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, Sebastian Andrzej Siewior , Jesse Brandeburg , Eric Dumazet , Tony Nguyen , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote: ... > +static int igc_led_hw_control_set(struct led_classdev *led_cdev, > + unsigned long flags) > +{ > + struct igc_led_classdev *ldev = lcdev_to_igc_ldev(led_cdev); > + struct igc_adapter *adapter = netdev_priv(ldev->netdev); > + bool blink = false; > + u32 mode; > + > + if (flags & BIT(TRIGGER_NETDEV_LINK_10)) > + mode = IGC_LEDCTL_MODE_LINK_10; > + if (flags & BIT(TRIGGER_NETDEV_LINK_100)) > + mode = IGC_LEDCTL_MODE_LINK_100; > + if (flags & BIT(TRIGGER_NETDEV_LINK_1000)) > + mode = IGC_LEDCTL_MODE_LINK_1000; > + if (flags & BIT(TRIGGER_NETDEV_LINK_2500)) > + mode = IGC_LEDCTL_MODE_LINK_2500; > + if ((flags & BIT(TRIGGER_NETDEV_TX)) || > + (flags & BIT(TRIGGER_NETDEV_RX))) > + mode = IGC_LEDCTL_MODE_ACTIVITY; Hi Kurt, I guess this can't happen in practice, but if none of the conditions above are met, then mode is used uninitialised below. Flagged by Smatch. > + > + /* blink is recommended for activity */ > + if (mode == IGC_LEDCTL_MODE_ACTIVITY) > + blink = true; > + > + igc_led_set(adapter, ldev->index, mode, blink); > + > + return 0; > +} ...