From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EFCAC46CD2 for ; Wed, 24 Jan 2024 21:27:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E20A540181; Wed, 24 Jan 2024 21:27:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E20A540181 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1706131623; bh=CkxtFHbjk2B8uv/Bp7rwir4anSOwgO1625h1RichXdc=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=z4l6lkL18qJxOGMm9rVqQ1gVg/PW99O0xA/E6oq3++HUm1NSpQ7zO+zfW67FwxrE/ EqD8S2hzXPMFVjGhFKJC+WsnJzXQVokyuRrL/ZJpVIWjLX4chuiM0So+dCJJRQ+IkX /+4jfltQeFaVvayMbYnT/tDd05BGE6MSwqoud8cBPebT3WgkBkuj9KTfByAyz5hKNg tYedeczJSAfK1AvcRJFKi9yj5IDrofFr+5O0/aHwhE3Cko4Y9QJqVrdEcc95XuXwbx DrPD4QA+Bq2FGg/QhWpPn7hTD2YOAQ9qm+6YgkJLcic46fzRUgRw/kKKxbZNrZF9mY JRujeC1Q7Cyjw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sm31PmZp2jHO; Wed, 24 Jan 2024 21:27:02 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id BDCFE40199; Wed, 24 Jan 2024 21:27:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org BDCFE40199 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id C327C1BF3BF for ; Wed, 24 Jan 2024 21:27:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9A24781B0A for ; Wed, 24 Jan 2024 21:27:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9A24781B0A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5Tj-cAujQ16Y for ; Wed, 24 Jan 2024 21:27:00 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id 0B1CE81778 for ; Wed, 24 Jan 2024 21:26:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0B1CE81778 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EFD8861E57; Wed, 24 Jan 2024 21:26:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69485C433C7; Wed, 24 Jan 2024 21:26:57 +0000 (UTC) Date: Wed, 24 Jan 2024 21:26:54 +0000 From: Simon Horman To: Tony Nguyen Message-ID: <20240124212654.GA348897@kernel.org> References: <20240122182419.889727-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122182419.889727-1-anthony.l.nguyen@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706131618; bh=lCOjQOk7wxMizEVQCLQ7fNTuC0MebLxnMQwmgJUQwb4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OzaGWpM7ggNujGT2ILNyXDOxpDxaPfJ6oDnDbvC3QwR3RzPzbcaUEf+Vbeo+FN+1e xlw3j8av8cwhrJtpjIazRp9AYsLcW3MzRahzsxBVYl16tybSoNpWm+w+Gsn5xsAPnM YCTBVPonkr2cvk3n+bhRXMk0FiTFErjUOSXocFF6wmnpIYdXaAO+uN5sHPSSM3A2+f JnBI7unAq8gbSI2vR+hcIyGqF0pY6vFDaXZ21Pa74ZJntiQDqDQYB0bCORfV9RdJeb C0pbGCbtqwFBYOAkFKpaLWykX7ltVrilqh9REMGu3JYinvx9m8q4PtqDVjwA86mHdq xyyTwpGtXieUw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=OzaGWpM7 Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove duplicate comment X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Paul M Stillwell Jr , Przemek Kitszel Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Jan 22, 2024 at 10:24:17AM -0800, Tony Nguyen wrote: > From: Paul M Stillwell Jr > > Remove a comment that was not correct; this structure has nothing > to do with FW alignment. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Paul M Stillwell Jr Sure, but the subject doesn't seem to match the patch description. And, Tony, your Sob seems to be missing. > --- > drivers/net/ethernet/intel/ice/ice_debugfs.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c > index c2bfba6b9ead..85aa31dd86b1 100644 > --- a/drivers/net/ethernet/intel/ice/ice_debugfs.c > +++ b/drivers/net/ethernet/intel/ice/ice_debugfs.c > @@ -64,9 +64,6 @@ static const char * const ice_fwlog_level_string[] = { > "verbose", > }; > > -/* the order in this array is important. it matches the ordering of the > - * values in the FW so the index is the same value as in ice_fwlog_level > - */ > static const char * const ice_fwlog_log_size[] = { > "128K", > "256K",