From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: wojciech.drewek@intel.com, marcin.szycik@intel.com,
przemyslaw.kitszel@intel.com, sridhar.samudrala@intel.com,
horms@kernel.org, netdev@vger.kernel.org,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: [Intel-wired-lan] [iwl-next v2 0/8] ice: use less resources in switchdev
Date: Fri, 2 Feb 2024 15:59:20 +0100 [thread overview]
Message-ID: <20240202145929.12444-1-michal.swiatkowski@linux.intel.com> (raw)
Hi,
Switchdev is using one queue per created port representor. This can
quickly lead to Rx queue shortage, as with subfunction support user
can create high number of PRs.
Save one MSI-X and 'number of PRs' * 1 queues.
Refactor switchdev slow-path to use less resources (even no additional
resources). Do this by removing control plane VSI and move its
functionality to PF VSI. Even with current solution PF is acting like
uplink and can't be used simultaneously for other use cases (adding
filters can break slow-path).
In short, do Tx via PF VSI and Rx packets using PF resources. Rx needs
additional code in interrupt handler to choose correct PR netdev.
Previous solution had to queue filters, it was way more elegant but
needed one queue per PRs. Beside that this refactor mostly simplifies
switchdev configuration.
v1 --> v2 [1]:
* more idiomatic error handling in config LAG
[1] https://lore.kernel.org/netdev/20240125125314.852914-1-michal.swiatkowski@linux.intel.com/
Michal Swiatkowski (8):
ice: remove eswitch changing queues algorithm
ice: do Tx through PF netdev in slow-path
ice: default Tx rule instead of to queue
ice: control default Tx rule in lag
ice: remove switchdev control plane VSI
ice: change repr::id values
ice: do switchdev slow-path Rx using PF VSI
ice: count representor stats
drivers/net/ethernet/intel/ice/ice.h | 7 -
drivers/net/ethernet/intel/ice/ice_base.c | 44 +--
drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 4 +-
drivers/net/ethernet/intel/ice/ice_eswitch.c | 362 +++---------------
drivers/net/ethernet/intel/ice/ice_eswitch.h | 13 +-
drivers/net/ethernet/intel/ice/ice_lag.c | 51 ++-
drivers/net/ethernet/intel/ice/ice_lag.h | 3 +-
drivers/net/ethernet/intel/ice/ice_lib.c | 49 +--
drivers/net/ethernet/intel/ice/ice_main.c | 10 +-
drivers/net/ethernet/intel/ice/ice_repr.c | 126 +++---
drivers/net/ethernet/intel/ice/ice_repr.h | 24 +-
drivers/net/ethernet/intel/ice/ice_sriov.c | 3 -
drivers/net/ethernet/intel/ice/ice_switch.c | 4 +
drivers/net/ethernet/intel/ice/ice_switch.h | 5 +-
drivers/net/ethernet/intel/ice/ice_txrx.h | 1 +
drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 11 +-
drivers/net/ethernet/intel/ice/ice_type.h | 1 -
.../net/ethernet/intel/ice/ice_vsi_vlan_ops.c | 1 -
18 files changed, 230 insertions(+), 489 deletions(-)
--
2.42.0
next reply other threads:[~2024-02-02 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 14:59 Michal Swiatkowski [this message]
2024-02-02 14:59 ` [Intel-wired-lan] [iwl-next v2 1/8] ice: remove eswitch changing queues algorithm Michal Swiatkowski
2024-02-16 12:13 ` Buvaneswaran, Sujai
2024-02-02 14:59 ` [Intel-wired-lan] [iwl-next v2 2/8] ice: do Tx through PF netdev in slow-path Michal Swiatkowski
2024-02-02 14:59 ` [Intel-wired-lan] [iwl-next v2 3/8] ice: default Tx rule instead of to queue Michal Swiatkowski
2024-02-02 14:59 ` [Intel-wired-lan] [iwl-next v2 4/8] ice: control default Tx rule in lag Michal Swiatkowski
2024-02-02 14:59 ` [Intel-wired-lan] [iwl-next v2 5/8] ice: remove switchdev control plane VSI Michal Swiatkowski
2024-02-02 14:59 ` [Intel-wired-lan] [iwl-next v2 6/8] ice: change repr::id values Michal Swiatkowski
2024-02-02 14:59 ` [Intel-wired-lan] [iwl-next v2 7/8] ice: do switchdev slow-path Rx using PF VSI Michal Swiatkowski
2024-02-02 14:59 ` [Intel-wired-lan] [iwl-next v2 8/8] ice: count representor stats Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202145929.12444-1-michal.swiatkowski@linux.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox