From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D23EC4828F for ; Fri, 2 Feb 2024 17:18:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 93190613C2; Fri, 2 Feb 2024 17:18:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 93190613C2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1706894296; bh=vgaegNq0ZEFkbpkqVTL7AfQLw/wHbFiGW6bQkt+zPgs=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Y3GkQc5SDVpLK9gThKBraVGhW+AUUFFVFLCLXDAIomSIiMWx1aEz13X/VGfw8+Uur mHjzZkklL2HlWqARohwGzRALjPSdhhZmJwjP6CPD6f/p9/IIdj+04lo81Up/7KbEgN xGaTMfnydPLLk6Puw6ALuAsfq4gOJTd9faoJCaQFXQyTFOpfxlN+auMrTcpTlMXkxE Mqjp8iQ9IpwMN/rWFZ3Wr+zk0e8ZmsM7HXfFkIIoG87CNLlClEXz/RM3dwD2K89Ntc xjDDov0ybv+za6cIkl53cPJhY4OVdibG7PTpXCBdB4As3yAZJw2RiJeuCJ7ItQ2tI6 e5IU6DymDkxrg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kZN7Qhp9LH9F; Fri, 2 Feb 2024 17:18:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id C1073613C5; Fri, 2 Feb 2024 17:18:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C1073613C5 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id D3DF21BF3A3 for ; Fri, 2 Feb 2024 17:18:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id ABB23613ED for ; Fri, 2 Feb 2024 17:18:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org ABB23613ED X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sx1XDnt16Kz5 for ; Fri, 2 Feb 2024 17:18:13 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id 05429613C2 for ; Fri, 2 Feb 2024 17:18:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 05429613C2 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CE8AD62505; Fri, 2 Feb 2024 17:18:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4AAEC433F1; Fri, 2 Feb 2024 17:18:08 +0000 (UTC) Date: Fri, 2 Feb 2024 18:18:05 +0100 From: Simon Horman To: Michal Swiatkowski Message-ID: <20240202171805.GS530335@kernel.org> References: <20240125125314.852914-1-michal.swiatkowski@linux.intel.com> <20240125125314.852914-5-michal.swiatkowski@linux.intel.com> <20240129105541.GH401354@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706894291; bh=mTQpAVj7Ewz7qRcOhpB8XMamGD5kDsPz+5ZWXExfk9k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ofEWPwwtqDkSqZIOv2vLm45rJ/UEXBWf2MUUNgpMkSPDt8EakRtXkBob4QnyVg6gq cYPZHriD97iFyR1hvqV4BI23G382E8+YOnrHptmNz1BURXZcwmYo2hnj9p36hfHX9i k2MYM2fkLAu5QmHMCdYVynjO6TqVD/6qqnQDs460lkfL0Df0tXyJ9P4KIa9PXgq8m4 SgtgAc5GrWD4O9PMqX97LeS74LEFrS/yVNNlcgnfKjxt/ChgBmh0ue+t8jTP7SHljZ et0oqbXD+Uyy3JJGHB1NOBrFUr+gi6z/eIU089C2C58e1cXrTHgMyXb0DAECssXPhj +a0xg3MJ0bL4A== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ofEWPwwt Subject: Re: [Intel-wired-lan] [iwl-next v1 4/8] ice: control default Tx rule in lag X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wojciech.drewek@intel.com, marcin.szycik@intel.com, Marcin Szycik , netdev@vger.kernel.org, sridhar.samudrala@intel.com, intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Feb 01, 2024 at 08:05:06AM +0100, Michal Swiatkowski wrote: > On Mon, Jan 29, 2024 at 10:55:41AM +0000, Simon Horman wrote: > > On Thu, Jan 25, 2024 at 01:53:10PM +0100, Michal Swiatkowski wrote: > > > Tx rule in switchdev was changed to use PF instead of additional control > > > plane VSI. Because of that during lag we should control it. Control > > > means to add and remove the default Tx rule during lag active/inactive > > > switching. > > > > > > It can be done the same way as default Rx rule. > > > > Hi Michal, > > > > Can I confirm that LAG TX/RX works both before and after this patch? > > > > Hi Simon, > > This part of LAG code is related to the LAG + switchdev feature (it > isn't chaning LAG core code). Hope that normal LAG also works well. This > is the scenario when you have PF in switchdev, bond created of two PFs > connected to the bridge with representors. Switching between interfaces > from bond needs to add default Rx rule, and after my changes also > default Tx rule. > > Do you think I should add this description to commit message? Thanks Michal, I think that might be a good idea. But my question was a bit different: I'm asking if this patch addresses a regression introduced earlier in the series. Sorry for not being clearer the first time around.