From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2AA4C4828D for ; Mon, 5 Feb 2024 11:13:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7E91140B7E; Mon, 5 Feb 2024 11:13:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7E91140B7E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1707131624; bh=XKxakwHPyS2XoHn/ERK+AeaLjAbtEyNowJVlriqJt5w=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=w0/mhI8ksmbhbWZ8owixd0hEr/VJr5I76dZZEYB9rScxsAhoPw8seIrTlv0cXle2U +Bs3WHVBHwRTK8QC0rOOgZu0n2hh+e0iJjuw+vwYsqDlScxkhIE8l5CvWJl+6UlKG5 UrM2oIxWv5Xnag1GJRgEn2pWN6pL1tltSd8yUYPlqobY/SEj/s13f5GCW5iuFsAvli KfW+k5dozSF3ArW9fdwkjF639ItE03CctD4pg8IRivkf4E1n06ZGX+rdDPle26Hi6y yDTdsUiuGMfmgR7mv2g9pJjUp0RPwzom82GL0eHxaLLKJ6PPhYwgFwMZh/UYkRcp5A 05bUJfdwfxcdg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zjaWZgFU7lqR; Mon, 5 Feb 2024 11:13:43 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 769DD4174D; Mon, 5 Feb 2024 11:13:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 769DD4174D Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 3B4B01BF281 for ; Mon, 5 Feb 2024 11:13:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1F28440266 for ; Mon, 5 Feb 2024 11:13:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1F28440266 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uC0bxhXjTkBh for ; Mon, 5 Feb 2024 11:13:37 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8298A418B1 for ; Mon, 5 Feb 2024 11:13:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8298A418B1 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 59BF060FEC; Mon, 5 Feb 2024 11:13:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D77B6C433C7; Mon, 5 Feb 2024 11:13:34 +0000 (UTC) Date: Mon, 5 Feb 2024 11:13:32 +0000 From: Simon Horman To: Maciej Fijalkowski Message-ID: <20240205111332.GH960600@kernel.org> References: <20240201154219.607338-1-maciej.fijalkowski@intel.com> <20240201154219.607338-2-maciej.fijalkowski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240201154219.607338-2-maciej.fijalkowski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707131616; bh=qiyJcgmXr99ZarDMYq7VLCkuujzBIzl3EqIkNIzXRhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sn8jNGpHH/MLlXJThUYm7xb917OyH2VY7m8M+bLEnFKBBiNHS8qFqbhsXjq59pcR9 NvrTIwhjXOLBN1yHFdzOdv/BW8KDn5Uu3TaQcJI+3gpSYN2i+GmGR8rpeuyHyOn1Xc mz87kxGDILwXHkhhFzneKT6NXnzCwvRdzl60lJH6GI7iUY7rXL+k2J8NCxJnmZQYOG SWC63lCXTpon7o10Qt3XnQ7tDkePAkaxSQSLi5y04roI88m7tu4bvfX4tQjoCbOqDS 1WAAoHcctsj/QHT5K3e5x6VPe2cNVym8R/iU9tNL+BDPtSrStCP0DpIeyWEK1EJ1L/ il8NId+MlPWEw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=sn8jNGpH Subject: Re: [Intel-wired-lan] [PATCH iwl-net 1/2] i40e: avoid double calling i40e_pf_rxq_wait() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, magnus.karlsson@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Feb 01, 2024 at 04:42:18PM +0100, Maciej Fijalkowski wrote: > Currently, when interface is being brought down and > i40e_vsi_stop_rings() is called, i40e_pf_rxq_wait() is called two times, > which is wrong. To showcase this scenario, simplified call stack looks > as follows: > > i40e_vsi_stop_rings() > i40e_control wait rx_q() > i40e_control_rx_q() > i40e_pf_rxq_wait() > i40e_vsi_wait_queues_disabled() > i40e_pf_rxq_wait() // redundant call > > To fix this, let us s/i40e_control_wait_rx_q/i40e_control_rx_q within > i40e_vsi_stop_rings(). > > Fixes: 65662a8dcdd0 ("i40e: Fix logic of disabling queues") > Signed-off-by: Maciej Fijalkowski Reviewed-by: Simon Horman