From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA720C4828D for ; Tue, 6 Feb 2024 03:46:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A80AD41B3F; Tue, 6 Feb 2024 03:46:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org A80AD41B3F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1707191177; bh=l/ttVKm63GGMzOOEz68py22rmi6Urc5MzwsAt0AJGJU=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=8rR7BaniwQS0TS1snw0nd14zGib694cIXBOgmiK7Uhy9g0gXFrx2UJhxjy7Uk7bj0 DPswDSdlD8qR1X5hmWkPmUqc526VHeKxHBqZM0MVAuQjJ1auOz1wZi2CCxtsi2HwRp TsmhtvW/4zmk3JlAOSIPTDMR2cnVk2XddDo7J45qzABjKmiq+a2GWb5jIKLWuzBukF WhQogHuDN3tCrBXrSmgrftI5i3Xeb7+MbuiCIXc+HO+qWh75pXPbAjpT/C9xa3/ye9 7oJekd7D9oB27yzGsw71gbU51TvY6SUNXInieRTxwGzjP5BvtnNEt7y+sSJckRVJ7n uUvNxJSEy68PQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HA2xe5vct0z1; Tue, 6 Feb 2024 03:46:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id B61FB41D6C; Tue, 6 Feb 2024 03:46:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B61FB41D6C Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E37851BF215 for ; Tue, 6 Feb 2024 03:45:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D0D8A81F99 for ; Tue, 6 Feb 2024 03:45:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yJANyDgL95iH for ; Tue, 6 Feb 2024 03:45:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16; helo=mgamail.intel.com; envelope-from=alan.brady@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 2DFBA81F97 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2DFBA81F97 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by smtp1.osuosl.org (Postfix) with ESMTPS id 2DFBA81F97 for ; Tue, 6 Feb 2024 03:45:51 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="824879" X-IronPort-AV: E=Sophos;i="6.05,246,1701158400"; d="scan'208";a="824879" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 19:38:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,246,1701158400"; d="scan'208";a="5653958" Received: from dev1-atbrady.jf.intel.com ([10.166.241.35]) by orviesa004.jf.intel.com with ESMTP; 05 Feb 2024 19:38:43 -0800 From: Alan Brady To: intel-wired-lan@lists.osuosl.org Date: Mon, 5 Feb 2024 19:38:04 -0800 Message-Id: <20240206033804.1198416-11-alan.brady@intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240206033804.1198416-1-alan.brady@intel.com> References: <20240206033804.1198416-1-alan.brady@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707191151; x=1738727151; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LII/pxHUmQjvXxWY8Nop+EybCOMdIUqmiemtNt9IPU4=; b=oFhekOLiPtJlRJO30fVGCoaIxfrOI8m0F03jvrdkvdmLDtu+IeK1DUx9 ZqO2nz8T0CcIHgsRMfhFEhlnCqxsZVMq6e8OWWJ/4Ia91t0G3igaJepdY A/KEOmrJjoEOBShQhpg6HFvnJ8UTyvpS2l1SID6HExp1NHI1fI1rVzB0O l0m/BM43y/Mq+SJIpVwKGL+HWt2xpRQW25nv47gTwiNfyCdksgYcX1p+R +LjrKyWCO8Vm7m5QDr/MoBNfmuNwIiyCoOdaLlvlCAE4KWg8EIaYYKaly IrCQJcgxD3Wc3hNR9894FGx+mIfqabxT2Ynff6Sn2YHE520synNDAbjv7 g==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=oFhekOLi Subject: [Intel-wired-lan] [PATCH v4 10/10 iwl-next] idpf: remove dealloc vector msg err in idpf_intr_rel X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: willemdebruijn.kernel@gmail.com, netdev@vger.kernel.org, aleksander.lobakin@intel.com, Alan Brady , przemyslaw.kitszel@intel.com, igor.bagnucki@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This error message is at best not really helpful and at worst misleading. If we're here in idpf_intr_rel we're likely trying to do remove or reset. If we're in reset, this message will fail because we lose the virtchnl on reset and HW is going to clean up those resources regardless in that case. If we're in remove and we get an error here, we're going to reset the device at the end of remove anyway so not a big deal. Just remove this message it's not useful. Signed-off-by: Alan Brady --- drivers/net/ethernet/intel/idpf/idpf_lib.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c index 1aae6963628b..1e30ef98cd68 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c @@ -78,19 +78,12 @@ static void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter) */ void idpf_intr_rel(struct idpf_adapter *adapter) { - int err; - if (!adapter->msix_entries) return; idpf_mb_intr_rel_irq(adapter); pci_free_irq_vectors(adapter->pdev); - - err = idpf_send_dealloc_vectors_msg(adapter); - if (err) - dev_err(&adapter->pdev->dev, - "Failed to deallocate vectors: %d\n", err); - + idpf_send_dealloc_vectors_msg(adapter); idpf_deinit_vector_stack(adapter); kfree(adapter->msix_entries); adapter->msix_entries = NULL; -- 2.40.1