From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBFC5C48297 for ; Tue, 6 Feb 2024 18:57:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 570CD82F39; Tue, 6 Feb 2024 18:57:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CxqYNKZbn2YS; Tue, 6 Feb 2024 18:57:45 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D4E3D82F20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1707245865; bh=idaw42VzVYgmTWJWmc6dWKh3k74ScDTb8FzUcW99z+4=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=SZKJ1NtSK7vJHJkWIicBdy8DocwRd25rQDWr9KPe5494igin6V0WYfcMnG4FHVFQJ Ijf9i5kxOlZVHbhEocIZoPh5xIcWed8YRoyYWhnmUxcd4eLPco2rE56TRCoLhNeN1Q /Daj96zI+7ipf52Z+NVRYWRJ4i7pE4rCyjEdimdCmAIHqauPhJbAMoQ2Zj1/ZqNZ2O 868Ech2qCSHH37fZT+aNrEckUVVtgvJTupg8GGxuipjXgIhq+K4rsIHy4OjLB4/fLb JpDzE1J/J5eRQ3Pi6+Kw/jj7NareGVLyds7R7DMrqe70iAKGX0u+vMSiyMi7tziRHp iyFQ44mlC8RpA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id D4E3D82F20; Tue, 6 Feb 2024 18:57:45 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 852431BF31F for ; Tue, 6 Feb 2024 18:57:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6FEBB41F93 for ; Tue, 6 Feb 2024 18:57:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iEfH1lKZAkIF for ; Tue, 6 Feb 2024 18:57:44 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org B05D641F91 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B05D641F91 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id B05D641F91 for ; Tue, 6 Feb 2024 18:57:43 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B7E86CE1732; Tue, 6 Feb 2024 18:57:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF973C433C7; Tue, 6 Feb 2024 18:57:38 +0000 (UTC) Date: Tue, 6 Feb 2024 10:57:37 -0800 From: Jakub Kicinski To: Alan Brady Message-ID: <20240206105737.50149937@kernel.org> In-Reply-To: <20240206033804.1198416-1-alan.brady@intel.com> References: <20240206033804.1198416-1-alan.brady@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707245859; bh=yze97PLevIR5v5XRlpkb6itN7k0C+IJTA+1uqBGxofg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F0rw0CywJvwA3cBGlQfIHZFVlwvZN+QeuP4XY56WqASoW6FGkpR8t4Wl4mqQde3Di z8R91edHgliluDlQJjeoLt6uVgNwJ+AG64sAkTxDJekYm5IzTN7eBzUj2vvetaFUWH YUhmWhTAyNEe5bHxULEt+CYkOSykLxDYlO/RWALcDzdJr+KgXEKZ3ILHBwW17YH/zG csfCzRaxTlzjPAVRoIHIxn16QAdntibW1cCmQ0xFZhyUJwxhhL+bfUuao0k1otlJwe B0Uchxiw4UaxRiGwIBo9rbZ7ZGLq4uo46hEl+7ukQEbL2QF1xSTDaLaXQEmfRv/WZq qVi0tcVOzp9ZQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=F0rw0Cyw Subject: Re: [Intel-wired-lan] [PATCH v4 00/10 iwl-next] idpf: refactor virtchnl messages X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: willemdebruijn.kernel@gmail.com, netdev@vger.kernel.org, aleksander.lobakin@intel.com, intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, igor.bagnucki@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 5 Feb 2024 19:37:54 -0800 Alan Brady wrote: > The motivation for this series has two primary goals. We want to enable > support of multiple simultaneous messages and make the channel more > robust. The way it works right now, the driver can only send and receive > a single message at a time and if something goes really wrong, it can > lead to data corruption and strange bugs. Coccinelle points out some potential places to use min() testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1956:17-18: WARNING opportunity for min() testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1271:17-18: WARNING opportunity for min() testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1319:17-18: WARNING opportunity for min() testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:2640:17-18: WARNING opportunity for min() testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:1295:17-18: WARNING opportunity for min() testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:2157:17-18: WARNING opportunity for min() testing/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c:3582:17-18: WARNING opportunity for min() -- pw-bot: au