From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02CEFC4828D for ; Thu, 8 Feb 2024 00:43:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8337961AF6; Thu, 8 Feb 2024 00:43:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RbpB1dHBlU6Z; Thu, 8 Feb 2024 00:43:02 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 675B561ADD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1707352982; bh=YWbfHZ75EjGpuxKSU6jm8JK1qlYWl747kDGWMN02g2M=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=Dp8e0/p6UKwhyBG8pmyIygDZNGgjVjbtS9/u4idjjtHZ8I1vtEHOTEq5siWUhFCDA Kh4+vRaIVTJvXrm/zoTk6/RE+13/WfSdKecdqw2UihGkHg1wY7p73tDi4eRGKNN8hk K3it4/EjdkIxz14GaiFdK/PB6R8tt+lgUMV5AA3fx3AJ8n43n8TF4ucldB6sFiKPP7 0qhx6WBK33upXcBB+cHOWDuKu52e+rrHcopzyQOXv8QuZ0diOpXhvRbaAtRQJzkw2o 3YR+PCR6muqi6giM48M/DEEEgzYpAD9btAEiU/rl1g6SaQRWxMwtiGUHV14aH1cACV 8Cg4QgwgWp2bw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 675B561ADD; Thu, 8 Feb 2024 00:43:02 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id AC3331BF28A for ; Thu, 8 Feb 2024 00:43:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A42308510A for ; Thu, 8 Feb 2024 00:43:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R1O2RXMu2hq5 for ; Thu, 8 Feb 2024 00:43:00 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.10; helo=mgamail.intel.com; envelope-from=alan.brady@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org D1D7485099 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D1D7485099 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by smtp1.osuosl.org (Postfix) with ESMTPS id D1D7485099 for ; Thu, 8 Feb 2024 00:42:59 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="12470118" X-IronPort-AV: E=Sophos;i="6.05,252,1701158400"; d="scan'208";a="12470118" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 16:42:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="910168063" X-IronPort-AV: E=Sophos;i="6.05,252,1701158400"; d="scan'208";a="910168063" Received: from dev1-atbrady.jf.intel.com ([10.166.241.35]) by fmsmga002.fm.intel.com with ESMTP; 07 Feb 2024 16:42:58 -0800 From: Alan Brady To: intel-wired-lan@lists.osuosl.org Date: Wed, 7 Feb 2024 16:42:43 -0800 Message-ID: <20240208004243.1762223-1-alan.brady@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707352980; x=1738888980; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=jEyCQpqCsP+w6uiCCI1xLzXp4P9t7xwd5YUEwCWLgTs=; b=WAhUUPo35tF1tvnvQ7+A2Dac0BS7A6B2U3kAG+s/RvO+RIsdhka4k/4r 6EQnXn2xtaQZoihYWeDjVPT/cSugF/hWKDHSHf7rgmZ/Oe98bi/xkJ1mB 73krHB0B9vLCsvermWOmW5dF5R4542pIZdA6gYvzARI44c3rNMVAAsv/X 8sVkZQxPNoPz9E8ntcycxSe+VCA4bGoW1PVGcU14DK4FZWwxXzvy7RJc3 fkhHGPvzGxq7K/7WC8OWBMtDc6P7AEApD7w6ZqokIM+EIVCCe3dda73Xh TzPkwrU3RtGvVqEdwRMf+Qt5udUj+q+Ul4THwFsfs2OevVoDs19EY+KnV w==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WAhUUPo3 Subject: [Intel-wired-lan] [PATCH 1/1 iwl-net] idpf: disable local BH when scheduling napi for marker packets X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Przemek Kitszel , netdev@vger.kernel.org, Emil Tantilov , Alan Brady , Jesse Brandeburg Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" From: Emil Tantilov Fix softirq's not being handled during napi_schedule() call when receiving marker packets for queue disable by disabling local bottom half. The issue can be seen on ifdown: NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!! Using ftrace to catch the failing scenario: ifconfig [003] d.... 22739.830624: softirq_raise: vec=3 [action=NET_RX] -0 [003] ..s.. 22739.831357: softirq_entry: vec=3 [action=NET_RX] No interrupt and CPU is idle. After the patch, with BH locks: ifconfig [003] d.... 22993.928336: softirq_raise: vec=3 [action=NET_RX] ifconfig [003] ..s1. 22993.928337: softirq_entry: vec=3 [action=NET_RX] Fixes: c2d548cad150 ("idpf: add TX splitq napi poll support") Reviewed-by: Jesse Brandeburg Reviewed-by: Przemek Kitszel Signed-off-by: Emil Tantilov Signed-off-by: Alan Brady --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c index d0cdd63b3d5b..390977a76de2 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -2087,8 +2087,10 @@ int idpf_send_disable_queues_msg(struct idpf_vport *vport) set_bit(__IDPF_Q_POLL_MODE, vport->txqs[i]->flags); /* schedule the napi to receive all the marker packets */ + local_bh_disable(); for (i = 0; i < vport->num_q_vectors; i++) napi_schedule(&vport->q_vectors[i].napi); + local_bh_enable(); return idpf_wait_for_marker_event(vport); } -- 2.43.0