From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82D14C48260 for ; Mon, 19 Feb 2024 09:22:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 343BA40751; Mon, 19 Feb 2024 09:22:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 213o-HQOKKpd; Mon, 19 Feb 2024 09:22:24 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6431540736 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1708334544; bh=7nlB9kTiW551c1uhV269PifLlRanP+p/PkrngkuvCLM=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Xt1AfW9vSEnM2aS4/tbuLdnr9pp8zjZhynYG1x1Mvq8FkfjC67/kMbIvenXqIjHRS i87a3NPmX6mX61uqd5skB4mF7jOWeBk2rC/gsg6NthKV0vg96R1lZ6bDDiRlA+8QbC LfKDWy3aim+bOc44tmWfjDax19EaCVLwq3+NXN5ySsKtjPrQRVBJNyNUpQtM+gA44W ESUKZUFFRZHagtWmcR6b1HrDbpm/CjqVdOLMOwrDsiODSpowgWWnurodgq463thxCO 5Td78vJL9qe6JB6Mnvd7NgpVuKL9tJOoSxQobVpLUB5CguK3gls3gpjJdz5++brNZq 6DpgEv7hpaWTw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 6431540736; Mon, 19 Feb 2024 09:22:24 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 10AC31BF5E9 for ; Mon, 19 Feb 2024 09:22:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EFC5540736 for ; Mon, 19 Feb 2024 09:22:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 94jHQZbrG060 for ; Mon, 19 Feb 2024 09:22:22 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4C5EC40720 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4C5EC40720 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4C5EC40720 for ; Mon, 19 Feb 2024 09:22:21 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CD26960204; Mon, 19 Feb 2024 09:22:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B5CAC433C7; Mon, 19 Feb 2024 09:22:18 +0000 (UTC) Date: Mon, 19 Feb 2024 09:22:16 +0000 From: Simon Horman To: Jesse Brandeburg Message-ID: <20240219092216.GT40273@kernel.org> References: <20240210220109.3179408-1-jesse.brandeburg@intel.com> <20240210220109.3179408-3-jesse.brandeburg@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240210220109.3179408-3-jesse.brandeburg@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708334540; bh=cqhT+74jMS/y3CvA29elHMcdXkWm7rk1p2NPRXtt7Jg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YVjO1g5qgZhdv5kKrgNWOVv9jQadckfvjZbQKGe8FI4Y7QUlkLA0W+jM1P56nCHu0 XPNF7PNzlnaykbCFmUSMdmFVQMgWkgmDhcBzzAcvtwGbdMljPkUrXYCIT0iZb8EcGx u+du8QtWtY2hfuiutoHbY+977duM8+37Hv7dsezPQP3vwvDf5txqLRpCv8gRjsCH5R ZWtJ536c7lD/wllWWkpgPMGPoqnGPp716fsDGqM38NlLO6iMsQjq/4clZDmh4wLcgz Wdn0UL/QTFgqsS6W1qUAQS3NAwup9z6ErQx+jegpiTfadwHSzFcJmHIYJbO1SGYykl jZsJh7VhgzOxQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YVjO1g5q Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement modern PM ops declarations X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Eric Dumazet , Tony Nguyen , Alan Brady , Jakub Kicinski , intel-wired-lan@lists.osuosl.org, Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, Feb 10, 2024 at 02:01:09PM -0800, Jesse Brandeburg wrote: > Switch the Intel networking drivers to use the new power management ops > declaration formats and macros, which allows us to drop __maybe_unused, > as well as a bunch of ifdef checking CONFIG_PM. > > This is safe to do because the compiler drops the unused functions, > verified by checking for any of the power management function symbols > being present in System.map for a build without CONFIG_PM. > > If a driver has runtime PM, define the ops with pm_ptr(), and if the > driver has Simple PM, use pm_sleep_ptr(), as well as the new versions of > the macros for declaring the members of the pm_ops structs. > > Checked with network-enabled allnoconfig, allyesconfig, allmodconfig on > x64_64. > > Reviewed-by: Alan Brady > Signed-off-by: Jesse Brandeburg Reviewed-by: Simon Horman