From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D4C4C54764 for ; Wed, 21 Feb 2024 00:51:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1434741740; Wed, 21 Feb 2024 00:51:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id szx3nE7dLMWK; Wed, 21 Feb 2024 00:51:04 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 585814172F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1708476664; bh=oXEmUfOUB9czbDkPplD/VmqSg5eAFz1T88Yu1cb+ea0=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=fY/MLh5ko16Tt3vt2eBc50xI8Aa28MAD9naK4WL3wyIe2Y0G8dLmPa4/C2/EcPpn5 132Yw9FrOsaM8puNFDz69wktOnkwXQmqJK/fUMXBYa8wsEyWcmI+OdsEI9YP2/PjyY u/jHkL9ZffTuRth7ey1ekvmqZuo/xHWPes/SYjuHVJyfPUb6SybbgRd2oNtLmU5HrQ y655nJiMoiPlCghVQOZ2u7JzepxVeIumi4K1tV2CrjqRtfRalSob5ME5f6KjPT7e+W +OBTU5HxeRWyd8kVqOY7yPZ6FItUGfGk/rxej4CNlpZgCvunkcXXbNBXMR95kgGC65 ENflsfVa1GEww== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 585814172F; Wed, 21 Feb 2024 00:51:04 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id D56501BF39D for ; Wed, 21 Feb 2024 00:51:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D029460876 for ; Wed, 21 Feb 2024 00:51:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Cm7OjupFE6IZ for ; Wed, 21 Feb 2024 00:51:01 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.18; helo=mgamail.intel.com; envelope-from=alan.brady@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 291DA607A4 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 291DA607A4 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by smtp3.osuosl.org (Postfix) with ESMTPS id 291DA607A4 for ; Wed, 21 Feb 2024 00:51:01 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10990"; a="2500826" X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="2500826" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2024 16:51:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="9551006" Received: from dev1-atbrady.jf.intel.com ([10.166.241.35]) by fmviesa004.fm.intel.com with ESMTP; 20 Feb 2024 16:51:00 -0800 From: Alan Brady To: intel-wired-lan@lists.osuosl.org Date: Tue, 20 Feb 2024 16:49:49 -0800 Message-ID: <20240221004949.2561972-11-alan.brady@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240221004949.2561972-1-alan.brady@intel.com> References: <20240221004949.2561972-1-alan.brady@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708476661; x=1740012661; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=P3ldWfnbctUdIGUueUJiC1QMP2t3BC8zgPf77u8WyaI=; b=WyWD2gCC+mSbICm0A9qs6gzv1T/e/Nn/S1m0wYMgMRVxCpJ+GZOBdonR saN70fmX+4w3H+IAVkrl4l61SPK4ZqgpkRjUM/u0fMzzYlfl20qUnLSSx zvO5rCLC/mFpZCUSk5l6QP1aMalqZSmS3TXSD3hkvD/g66D39Weu3FniJ 5yFsE0RecbVEUJfUJb1V9C8vyD7JDTlJ3oQ0Yf2k0zMp91zb8Tq89XV5P NvHGD2RQQFTeBmxQGLZrjWwnZGQXfozydXEyIICyNhU3fX77oK2vBizpC zweO3xTIDXjp9qgTmHIJNd5rIgLUwjgYomTDD7iwRQf665QvZz+W8xNBb A==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WyWD2gCC Subject: [Intel-wired-lan] [PATCH v5 10/10 iwl-next] idpf: remove dealloc vector msg err in idpf_intr_rel X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Alan Brady , Alexander Lobakin Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This error message is at best not really helpful and at worst misleading. If we're here in idpf_intr_rel we're likely trying to do remove or reset. If we're in reset, this message will fail because we lose the virtchnl on reset and HW is going to clean up those resources regardless in that case. If we're in remove and we get an error here, we're going to reset the device at the end of remove anyway so not a big deal. Just remove this message it's not useful. Tested-by: Alexander Lobakin Signed-off-by: Alan Brady --- drivers/net/ethernet/intel/idpf/idpf_lib.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c index 1aae6963628b..1e30ef98cd68 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c @@ -78,19 +78,12 @@ static void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter) */ void idpf_intr_rel(struct idpf_adapter *adapter) { - int err; - if (!adapter->msix_entries) return; idpf_mb_intr_rel_irq(adapter); pci_free_irq_vectors(adapter->pdev); - - err = idpf_send_dealloc_vectors_msg(adapter); - if (err) - dev_err(&adapter->pdev->dev, - "Failed to deallocate vectors: %d\n", err); - + idpf_send_dealloc_vectors_msg(adapter); idpf_deinit_vector_stack(adapter); kfree(adapter->msix_entries); adapter->msix_entries = NULL; -- 2.43.0