From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41B2CC48BF6 for ; Wed, 21 Feb 2024 23:38:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C991D418E8; Wed, 21 Feb 2024 23:38:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OhYk05LhN8Ua; Wed, 21 Feb 2024 23:38:11 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 31EB6418E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1708558691; bh=r0ixIQ7SfhnjHSNmtPy37Dxhc1HmdomsLnr+HFTACKU=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=hOT8YTlq0EsdzNfp3Fjxucc1PL3HDwRxTTD1rYzV4lng7/5vuBQ/7cxOzi5hNsriN Ri/jF2xWtpesuhXeX3g4QM/dnaYFv21xsvr7OtivYGweXzbdZAZt8NYpTUrZh6UoyT z+GqWQQ77iKtaOA4mEjSsdwfrhK+rShavgx2WwYoqK/LjjjTZ5L7Cn3L5Ayc6n5Etc uHzAYscrWpjfL1yw6UTbMcp4GQk05H1oYmfk8hzcZQOkyMnILdANdZJZM2ZizSRJ84 UEZ3FULUpxQXRrepT9ckt7U0TJFtrZEW1ostiMywv8k8OsI2H0C9xf0jWY14EJr0Qf paivy6mSBWkLg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 31EB6418E2; Wed, 21 Feb 2024 23:38:11 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id A6BE11BF429 for ; Wed, 21 Feb 2024 23:38:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9F024417D3 for ; Wed, 21 Feb 2024 23:38:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id koQucRHTeAra for ; Wed, 21 Feb 2024 23:38:08 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org BFFF9415AD DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org BFFF9415AD Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id BFFF9415AD for ; Wed, 21 Feb 2024 23:38:08 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 43160616AB; Wed, 21 Feb 2024 23:38:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3D42C433F1; Wed, 21 Feb 2024 23:38:06 +0000 (UTC) Date: Wed, 21 Feb 2024 15:38:05 -0800 From: Jakub Kicinski To: Jiri Pirko Message-ID: <20240221153805.20fbaf47@kernel.org> In-Reply-To: References: <20240219100555.7220-1-mateusz.polchlopek@intel.com> <20240219100555.7220-5-mateusz.polchlopek@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708558687; bh=2QrUFdv9xHtNdIxwF2NAF1ID/1pi4TfXta05K36OQos=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BWJviSidnR8R0G4NLdwmejlYiJ998b7XbMOBADJz8ac/lXte32lHpVylJ26wrKgbZ r+xH/ocxJ+S2B1CgzEWhGlJvAjJTBQlD4eXvjLDyL84y6IrEdHl7zJhoVqFRZyn6y0 SVleTCFFDDBlT7VyatPkhFCMoQ06MU2w9oRclrjnBqOrmXudWNGtOMqHMiXhy6zUZy UxeiKbhxMKmI9olSsf3xXzp1cVr0vlCzw2mDZp305g7exKdojPnOk9/18ETiCdMUYg BVD9QSHV0+5Lvc5AG9JbyuPeflqoX9MBmdMWqlpjF4wyJc7oAU0YMuFWyienWLxlEe bCZ2FKoeoTedQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=BWJviSid Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mateusz Polchlopek , netdev@vger.kernel.org, Lukasz Czapnik , intel-wired-lan@lists.osuosl.org, horms@kernel.org, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 19 Feb 2024 13:37:36 +0100 Jiri Pirko wrote: > >devlink dev param show pci/0000:4b:00.0 name tx_scheduling_layers > >pci/0000:4b:00.0: > > name tx_scheduling_layers type driver-specific > > values: > > cmode permanent value 9 > > > >Set: > >devlink dev param set pci/0000:4b:00.0 name tx_scheduling_layers value 5 > >cmode permanent It's been almost a year since v1 was posted, could you iterate quicker? :( > This is kind of proprietary param similar to number of which were shot > down for mlx5 in past. Jakub? I remain somewhat confused about what this does. Specifically IIUC the problem is that the radix of each node is limited, so we need to start creating multi-layer hierarchies if we want a higher radix. Or in the "5-layer mode" the radix is automatically higher?