From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DC25C54E67 for ; Thu, 14 Mar 2024 15:12:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 684314109D; Thu, 14 Mar 2024 15:12:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nzfjNHvwa8LE; Thu, 14 Mar 2024 15:12:02 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6BB93410A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1710429122; bh=0OL4LzRBFl80pfUqgwbmr9DML9X2re08EQDheZVyXs8=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=H2KnV49ifUik67CL0XiJIZXQly9hfwz3dZCEh5R2FpLnXLavDCvYix/liBAFwdyDv GPVSjmtIXW/gyvhYensRuSg9p5ZxU9P54yRojh67hqysZOuPEUREPpK7ulhQ5UAo9A t0h9eD/TeSKagUxgKgKQSnQEj2CeicaaJcjCkLTfLdXAW6Dnxu0rMSzGjsUJvc2m+e ouek1TBVdfKtqf7O960TNCctetfoPV70PUIZGYNWgYm3E+Vnw9WJ2qF7x3q9lbQpz3 4noSCx8TU1IOKaVd2WhSKQcV6fILLqp9GSz7gqEC3RIZ3Tb0EF/B4sxEdLdtc8Mbw3 sVQjY3Cdl0jmQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 6BB93410A3; Thu, 14 Mar 2024 15:12:02 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id BE0651BF267 for ; Thu, 14 Mar 2024 10:55:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A92CC81318 for ; Thu, 14 Mar 2024 10:55:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Du2Og1ThaFBf for ; Thu, 14 Mar 2024 10:55:09 +0000 (UTC) X-Greylist: delayed 1160 seconds by postgrey-1.37 at util1.osuosl.org; Thu, 14 Mar 2024 10:55:08 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org E2EC2812F7 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E2EC2812F7 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.142.43.55; helo=galois.linutronix.de; envelope-from=bigeasy@linutronix.de; receiver= Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by smtp1.osuosl.org (Postfix) with ESMTPS id E2EC2812F7 for ; Thu, 14 Mar 2024 10:55:08 +0000 (UTC) Date: Thu, 14 Mar 2024 11:35:45 +0100 From: Sebastian Andrzej Siewior To: Przemek Kitszel Message-ID: <20240314103545.Ljj-g-iS@linutronix.de> References: <20240313-igc_txts_comment-v1-1-4e8438739323@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Thu, 14 Mar 2024 15:11:58 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1710412546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0OL4LzRBFl80pfUqgwbmr9DML9X2re08EQDheZVyXs8=; b=r+HbErt/F+5Gy8G53OnnF6CbJ72Yan3ossy7LKaGnU5DkTJ1TgrXsSrb3PMb4m4N7QWmFb dJATEIE8EZdz1VjVVGXcb7TBEps7ycRpDFILGPtiQMd+rv4o8i8MvTEP/WL+Di913oDGIx RHUggNgw9XbvWQImP6fOb7ZogmGswHbaWRYwCwCHkAmru2JFsmmqTrcCiOzudfFc1acCH4 vKC4MfZslrpTnOumkZETpKYpJBcG84U49TlG2bUdh6PpXKRZlx9pODB5FjhjJQ6OUwcKVl PcgVdUM+M6JwWLkxFsAVMEVz5JjuRx+PRbvE7Wy0mBD8gI9kC9buyh/9KCTn5A== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1710412546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0OL4LzRBFl80pfUqgwbmr9DML9X2re08EQDheZVyXs8=; b=Zo7EGD0L2JlZp/xDGcf7aSMkWDJGphoZ5Q2pD49k2TQCix70rv5pLjW9tYtuZiCVC4+5v2 6H8IpOplKfyWw8Dw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=linutronix.de X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=r+HbErt/; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=Zo7EGD0L Subject: Re: [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Muhammad Husaini Zulkifli , Vinicius Costa Gomes , Vladimir Oltean , Kurt Kanzenbach , Eric Dumazet , netdev@vger.kernel.org, Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 2024-03-14 11:21:38 [+0100], Przemek Kitszel wrote: > On 3/13/24 14:03, Kurt Kanzenbach wrote: > > The initial igc Tx timestamping implementation used only one register for > > retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for > > multiple in-flight TX timestamps") added support for utilizing all four of > > them e.g., for multiple domain support. Remove the stale comment/FIXME. > > > > Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps") > > I would remove fixes tag (but keep the mention in commit msg). > And I would also target it to iwl-next when the window will open. > > Rationale: it's really not a fix. It is a fix as it removes something that is not accurate. But it only changes a comment so it has not outcome in the binary. I think what you mean is that you wish that it will not be backported stable. Still people reading the code of a v6.6 kernel might get confused. Sebastian