From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2897C4345F for ; Tue, 16 Apr 2024 11:22:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5660F605E2; Tue, 16 Apr 2024 11:22:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id uXEawJJ9z4oD; Tue, 16 Apr 2024 11:22:42 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BDB2660781 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713266562; bh=dL7hSrjU+MNAbb6shME/wtBb2UpMjS05OhEFRwqfjIU=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=YIYCFA37gubhNcbyvHkOVDqK/C1MfChTKJTKwkRnXuTbonFAA+BNctbBxrelZ9/N9 CsY6NpEp+9Fh/faVOG2s/oV+lJgrjSE8dUtNsNHO2IVSzHP01biDFBHyIV3V9hB7mw OyI4DOHYx76akdgCHK/h+cXd6IT08wq6qqvU09r9btlNI/St94Jm0biKLs9SGPfed7 UNkrtMVJfH4fugeoX4GztLgb8tanAMoQwCAUk72Tn+HkOj3XI11fN3kY2sar+Mvjii Yfot+G7Av4l9Q6FPdJr9W2pOUHFoHC5djvb/pR5Nrs6iDw1xfiuDUEQDHsrAIvjh+V h6t4qVviA80ig== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id BDB2660781; Tue, 16 Apr 2024 11:22:42 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 568BF1BF3AE for ; Tue, 16 Apr 2024 11:22:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 412C440120 for ; Tue, 16 Apr 2024 11:22:41 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id iQ5csDJ4EtfG for ; Tue, 16 Apr 2024 11:22:40 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 3F74B4006D DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3F74B4006D Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 3F74B4006D for ; Tue, 16 Apr 2024 11:22:40 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 397CFCE01B6; Tue, 16 Apr 2024 11:22:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF64EC113CE; Tue, 16 Apr 2024 11:22:33 +0000 (UTC) Date: Tue, 16 Apr 2024 12:22:31 +0100 From: Simon Horman To: Marcin Szycik Message-ID: <20240416112231.GL2320920@kernel.org> References: <20240415084907.613777-1-marcin.szycik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415084907.613777-1-marcin.szycik@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713266555; bh=buAkJOJzt+8xTKcpzoowXvt/D0os9Lg49hZuBSgdhoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dq5V+jY7yI/6GSaQv6dvec7hYEc2h0doxm/nJZ4dOKXEls9qW6wQ5H/ztqKBmLiOE tvWR8iwT9pCQXb9xYGF/j5HbjG7pPJKEG1I8iqtcNAVlondkYLBqnVIaSLhybQrK/3 jtYEGdcsDoCCrIQh7k4a4XRVrfnla7gcXswYGc0CPcvRrxUxLVRpjlXSsLqRS4mUfA BFa5MIRs582qeNg73T8LBXMzYDzVC5Bm1+FhBP/NIdpKHdzLFcbydRnNFE+x/BOqOZ A2BdmSxEBRCFCx2fCsFYpMCQwlhoctjeoeZJvlxENdL1FqduCw79k52kIWZCWSw4Mx UniLEvVNnWLvQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Dq5V+jY7 Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: Deduplicate tc action setup X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Mateusz Polchlopek , intel-wired-lan@lists.osuosl.org, andrii.staikov@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Apr 15, 2024 at 10:49:07AM +0200, Marcin Szycik wrote: > ice_tc_setup_redirect_action() and ice_tc_setup_mirror_action() are almost > identical, except for setting filter action. Reduce them to one function > with an extra param, which handles both cases. > > Reviewed-by: Mateusz Polchlopek > Signed-off-by: Marcin Szycik > --- > drivers/net/ethernet/intel/ice/ice_tc_lib.c | 56 ++++++--------------- > 1 file changed, 15 insertions(+), 41 deletions(-) Less is more :) Reviewed-by: Simon Horman