From: kernel test robot <lkp@intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
intel-wired-lan@lists.osuosl.org
Cc: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
larysa.zaremba@intel.com, netdev@vger.kernel.org,
michal.kubiak@intel.com, anthony.l.nguyen@intel.com,
oe-kbuild-all@lists.linux.dev, magnus.karlsson@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 08/11] ice: xsk: fix txq interrupt mapping
Date: Wed, 29 May 2024 03:52:57 +0800 [thread overview]
Message-ID: <202405290301.TKfQE09f-lkp@intel.com> (raw)
In-Reply-To: <20240528131429.3012910-9-maciej.fijalkowski@intel.com>
Hi Maciej,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tnguy-net-queue/dev-queue]
url: https://github.com/intel-lab-lkp/linux/commits/Maciej-Fijalkowski/ice-respect-netif-readiness-in-AF_XDP-ZC-related-ndo-s/20240528-211914
base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue
patch link: https://lore.kernel.org/r/20240528131429.3012910-9-maciej.fijalkowski%40intel.com
patch subject: [Intel-wired-lan] [PATCH iwl-net 08/11] ice: xsk: fix txq interrupt mapping
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240529/202405290301.TKfQE09f-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240529/202405290301.TKfQE09f-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405290301.TKfQE09f-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/intel/ice/ice_xsk.c:117: warning: Function parameter or struct member 'qid' not described in 'ice_qvec_cfg_msix'
drivers/net/ethernet/intel/ice/ice_xsk.c:479: warning: Function parameter or struct member 'xsk_pool' not described in '__ice_alloc_rx_bufs_zc'
drivers/net/ethernet/intel/ice/ice_xsk.c:528: warning: Function parameter or struct member 'xsk_pool' not described in 'ice_alloc_rx_bufs_zc'
drivers/net/ethernet/intel/ice/ice_xsk.c:983: warning: Function parameter or struct member 'xsk_pool' not described in 'ice_xmit_pkt'
drivers/net/ethernet/intel/ice/ice_xsk.c:1008: warning: Function parameter or struct member 'xsk_pool' not described in 'ice_xmit_pkt_batch'
drivers/net/ethernet/intel/ice/ice_xsk.c:1041: warning: Function parameter or struct member 'xsk_pool' not described in 'ice_fill_tx_hw_ring'
vim +117 drivers/net/ethernet/intel/ice/ice_xsk.c
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 109
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 110 /**
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 111 * ice_qvec_cfg_msix - Enable IRQ for given queue vector
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 112 * @vsi: the VSI that contains queue vector
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 113 * @q_vector: queue vector
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 114 */
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 115 static void
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 116 ice_qvec_cfg_msix(struct ice_vsi *vsi, struct ice_q_vector *q_vector, u16 qid)
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 @117 {
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 118 u16 reg_idx = q_vector->reg_idx;
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 119 struct ice_pf *pf = vsi->back;
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 120 struct ice_hw *hw = &pf->hw;
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 121 int q, _qid = qid;
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 122
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 123 ice_cfg_itr(hw, q_vector);
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 124
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 125 for (q = 0; q < q_vector->num_ring_tx; q++) {
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 126 ice_cfg_txq_interrupt(vsi, _qid, reg_idx, q_vector->tx.itr_idx);
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 127 _qid++;
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 128 }
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 129
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 130 _qid = qid;
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 131
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 132 for (q = 0; q < q_vector->num_ring_rx; q++) {
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 133 ice_cfg_rxq_interrupt(vsi, _qid, reg_idx, q_vector->rx.itr_idx);
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 134 _qid++;
d77176d15a1b0ed Maciej Fijalkowski 2024-05-28 135 }
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 136
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 137 ice_flush(hw);
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 138 }
2d4238f55697221 Krzysztof Kazimierczak 2019-11-04 139
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-05-28 19:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 13:14 [Intel-wired-lan] [PATCH iwl-net 00/11] ice: fix AF_XDP ZC timeout and concurrency issues Maciej Fijalkowski
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 01/11] ice: respect netif readiness in AF_XDP ZC related ndo's Maciej Fijalkowski
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 02/11] ice: don't busy wait for Rx queue disable in ice_qp_dis() Maciej Fijalkowski
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 03/11] ice: replace synchronize_rcu with synchronize_net Maciej Fijalkowski
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 04/11] ice: modify error handling when setting XSK pool in ndo_bpf Maciej Fijalkowski
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 05/11] ice: toggle netif_carrier when setting up XSK pool Maciej Fijalkowski
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 06/11] ice: improve updating ice_{t, r}x_ring::xsk_pool Maciej Fijalkowski
2024-05-28 17:44 ` kernel test robot
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 07/11] ice: add missing WRITE_ONCE when clearing ice_rx_ring::xdp_prog Maciej Fijalkowski
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 08/11] ice: xsk: fix txq interrupt mapping Maciej Fijalkowski
2024-05-28 19:52 ` kernel test robot [this message]
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 09/11] ice: move locking outside of ice_qp_ena and ice_qp_dis Maciej Fijalkowski
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 10/11] ice: lock with PF state instead of VSI state in ice_xsk_pool_setup() Maciej Fijalkowski
2024-05-28 13:14 ` [Intel-wired-lan] [PATCH iwl-net 11/11] ice: protect ring configuration with a mutex Maciej Fijalkowski
2024-05-28 14:11 ` Larysa Zaremba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405290301.TKfQE09f-lkp@intel.com \
--to=lkp@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=larysa.zaremba@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox