From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8602CC27C6E for ; Fri, 14 Jun 2024 10:40:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4943E843EE; Fri, 14 Jun 2024 10:40:45 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id qss7OAASWElH; Fri, 14 Jun 2024 10:40:44 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9FF6F843E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1718361644; bh=qDg4O3H8RlI5ZS4Q279g5o/jrSo7vnXb099jBVZYfs4=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=qMy3aBO73c5TCFmD6bJ/EtCVzNHef9yMzdT9wjZ81tDYxMEjoSEGWrGWXfzZgrOGg cRqrMbRnhMegIC3w/r19JHAGH1iZn85A5J3Qqw9vHAdzwLSp+9bsfx9e6/weUEROJ+ 83SoFVQG7l3Jr/loAnT3HaWyu950qA43RcQ2/96vAFGYCYN+eiWQXnpluAeFaXIwat u4FDpMlfisGU6WHoBdlH1//pRh1pBItFLTj3CV2uH+hKTyaxCjPQk5Z/tkar7NfU92 McJeH7AjVnwLx+FJg7LnCa5jcu6Fr944Hq4dm27I3LkodINA+yAcPYVgfXYNoTJAyt 2eDWk6W7mKSpw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 9FF6F843E9; Fri, 14 Jun 2024 10:40:44 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id A83E01BF33E for ; Fri, 14 Jun 2024 10:40:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 94BB3410EC for ; Fri, 14 Jun 2024 10:40:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id zdXi_s5G5gUd for ; Fri, 14 Jun 2024 10:40:43 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org CC139409C5 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org CC139409C5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id CC139409C5 for ; Fri, 14 Jun 2024 10:40:42 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1E0BB61F0E; Fri, 14 Jun 2024 10:40:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 176BAC2BD10; Fri, 14 Jun 2024 10:40:39 +0000 (UTC) Date: Fri, 14 Jun 2024 11:40:37 +0100 From: Simon Horman To: Jesse Brandeburg Message-ID: <20240614104037.GE8447@kernel.org> References: <20240606224701.359706-1-jesse.brandeburg@intel.com> <20240606224701.359706-3-jesse.brandeburg@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240606224701.359706-3-jesse.brandeburg@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718361641; bh=ub95+rc8EQDLycc7ngH9VSDLKcfdT6+T1cS4ojnuVkM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gzC8a44RKY3IGTRB0xApvqaNQhw+E7jPoiyxFdzAs6FFfzHrLzQVmN2OThroNkq4B is8PU/3GhB80W8g6jbbYB/jazHfBkCdx73X84/CwEGKCSy6ZkKrNwGKocUitnseHBU iMx+ipjNgn+E5cK4onCB2DhnQYmR1kR0r5EpBCs+0bNTLUSEBA5VkuJ8nDFKTp6Ls2 CH+1dd37Si+c9wZ1lYFbVFDqMNEKfkIGxg7GE/Zlf5X48N16W1kkTTZlg+mCd84w8x vrpo/nYhPsK0fNP6ni0FVKx4Vov4HorFZD1luK14JsRVLhGwVvSfiHKtwDKbak7XMD +K2Ra1Hngrq9w== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=gzC8a44R Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 2/5] ice: implement ethtool standard stats X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, netdev@vger.kernel.org, corbet@lwn.net, Marcin Szycik , intel-wired-lan@lists.osuosl.org, Jacob Keller , Jakub Kicinski Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jun 06, 2024 at 03:46:56PM -0700, Jesse Brandeburg wrote: > Add support for MAC/pause/RMON stats. This enables reporting hardware > statistics in a common way via: > > ethtool -S eth0 --all-groups > and > ethtool --include-statistics --show-pause eth0 > > While doing so, add support for one new stat, receive length error > (RLEC), which is extremely unlikely to happen since most L2 frames have > a type/length field specifying a "type", and raw ethernet frames aren't > used much any longer. > > NOTE: I didn't implement Ctrl aka control frame stats because the > hardware doesn't seem to implement support. > > Reviewed-by: Marcin Szycik > Reviewed-by: Jacob Keller > Reviewed-by: Jakub Kicinski > Signed-off-by: Jesse Brandeburg Reviewed-by: Simon Horman