From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 308E4C2BA15 for ; Mon, 17 Jun 2024 14:01:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4981F405AD; Mon, 17 Jun 2024 14:01:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AycU-eLJbWzi; Mon, 17 Jun 2024 14:01:40 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 75B524051C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1718632900; bh=PWQxEhdeQpwfbsPA5/qehe8dXBUhH0oo55ETqmZXy7U=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=zaLbXWKhPWNufTb47Fm5ZLL9CGKBLY/KOv42y2qGFhUwAF/1+4ikeDOe9SdpPugjC SwLOlIKPBU5qBbRdTe1Hah/QnaNhC8YeB9BXOd326HjVJ1S/pU0sUOMSXTFOPb4mbc DVWFH8LAA2bdWVnB2PZYpDrnBnROnvb8R6gF6G/Wzmh0KuaYooEkS51n1s4YtV3vva t68PIT2FfCfLgNjjQQZIPYGsBfYnhilA3hXV1X+Qql+ll0Jinic9dpRWYt+hA7wLqc JmtLm2KF5ztnQTGAWIlF0bqWznx+VHq5kgRGtOvGw/p72AQH5Cg/3FkXOTVnJS0WdX axiff2/aKIzXw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 75B524051C; Mon, 17 Jun 2024 14:01:40 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id D96A21BF2C1 for ; Mon, 17 Jun 2024 14:01:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id D0B1A408C4 for ; Mon, 17 Jun 2024 14:01:38 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id EHcbyp5ud_K4 for ; Mon, 17 Jun 2024 14:01:38 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 042C94061F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 042C94061F Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id 042C94061F for ; Mon, 17 Jun 2024 14:01:37 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A47B660C74; Mon, 17 Jun 2024 14:01:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21EBDC2BD10; Mon, 17 Jun 2024 14:01:34 +0000 (UTC) Date: Mon, 17 Jun 2024 15:01:33 +0100 From: Simon Horman To: Marcin Szycik Message-ID: <20240617140133.GT8447@kernel.org> References: <20240614103811.1178779-1-marcin.szycik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240614103811.1178779-1-marcin.szycik@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718632896; bh=ZSTtpCZOHnxjZs6PTQF1g7rTOoGh1x9yJulQj1I5kaI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ClXaVSFwFP7ZVVO8UtNNj7LEODi+6OKSidaaCQRIubS3jSz8JIMZP46ZVITX3O8ik KwGfFy5geGZ1YMj+hU5xL//UTdI7TCDepgIfKyCo5ydbokYMvnqpF3i7cI3tuOk/6B b39DzeuyIDyt7Is0YqngA4U8y6DQi/uZlFfGQC/RRblnP/ul236XWu6TXpWZJ/R4bl inFyd52cmhN+3kT8aAGFua7HcCcZmu2a8vJCpHhCtpweYlJoUu2ipEMEd3VOLpl96X ZT80t8pbCT2FAbhCrPv2lJklQUON+v4dDilY7rBj8iW9P14N/XsWXA+DnF8l7egLjP 1XRCz8hjXCoKw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ClXaVSFw Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: Distinguish driver reset and removal for AQ shutdown X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Piotr Gardocki , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Ahmed Zaki , Przemek Kitszel Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Jun 14, 2024 at 12:38:11PM +0200, Marcin Szycik wrote: > From: Piotr Gardocki > > Admin queue command for shutdown AQ contains a flag to indicate driver > unload. However, the flag is always set in the driver, even for resets. It > can cause the firmware to consider driver as unloaded once the PF reset is > triggered on all ports of device, which could lead to unexpected results. > > Add an additional function parameter to functions that shutdown AQ, > indicating whether the driver is actually unloading. > > Reviewed-by: Ahmed Zaki > Reviewed-by: Przemek Kitszel > Signed-off-by: Piotr Gardocki > Signed-off-by: Marcin Szycik Reviewed-by: Simon Horman