From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB8DBC3064D for ; Fri, 28 Jun 2024 12:41:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A2DE6417C5; Fri, 28 Jun 2024 12:41:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id xhC-69ANoQU0; Fri, 28 Jun 2024 12:41:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org AF31D419BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1719578494; bh=J6CGAraPmwMY727tAAIWGw0QBWQ6RIWN0XweS8FVSKg=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=ckNvKJ5Q8DSnJPJJirgYqWcVr6c1Phs2ayyD6Cb0l0XH2kl+fnuFjiW5UYSAkBYWe ABfjdYAXGEUMWhj33mfGyiR5kj0H8PYdCSYnRrFVSzlZOsAFaNlikgVO2+zD48VtSM w93tPhS/iJXImVjUk/pI4KU8hHr3w5Y+eOceyu14dpHYz5Lydt/qOM33oMGdfoEmCg Jrq3cKPnG4p9ox4tfyp5G/OmOidW1B36hw2JitoP7tL6F8tHkLT/f+7qcIiPIfRvem Pmmeq4QCbMzCPM78CgtuhNI6boXONq+Aej8RZ+bKM2NfLy4ypEcfvDLNzwww2WBx4j 8kgJeqTGvAGrw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id AF31D419BE; Fri, 28 Jun 2024 12:41:34 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id ED4041BF41C for ; Fri, 28 Jun 2024 12:41:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DAEC36078D for ; Fri, 28 Jun 2024 12:41:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OH1KpICpMceJ for ; Fri, 28 Jun 2024 12:41:33 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 243BB6077F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 243BB6077F Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id 243BB6077F for ; Fri, 28 Jun 2024 12:41:33 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 57DA96216C; Fri, 28 Jun 2024 12:41:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC6C5C116B1; Fri, 28 Jun 2024 12:41:30 +0000 (UTC) Date: Fri, 28 Jun 2024 13:41:28 +0100 From: Simon Horman To: Marcin Szycik Message-ID: <20240628124128.GC783093@kernel.org> References: <20240618141157.1881093-1-marcin.szycik@linux.intel.com> <20240618141157.1881093-5-marcin.szycik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240618141157.1881093-5-marcin.szycik@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719578492; bh=Q3suI3/uSoSrj6ynfxHKkNKN26AZN/vpAs3rVKR4cMU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ym4Idk9Y1MgnjWmeTlzbm4DaUbXbQvF5R/n4DnJc0rGYa+JIiOrigb5i9Z/sBp5Qj 1mzNSHo84/D2BHY7TbhQDFvtJnzQpkwpGW5WoDH3MxurrE0XnqVLz6pcFBE0UohPBm xrqNYkf1Ad8XzCEXcOES20Q+JCnV2NvliMTeOeagUz7K6byQK7etX55kMCMzVI8YZx oo8D5nbb5UrZ9FLHG8wdddMUMhz/yeHLcqaL2cX3+rdFPcljw+iUa1GSMxdzZcHcTv kAI//e3iszcWurbZRHfCu3y+p1/nGQUGFH5CRWToB1n8UdSNcrCWq7kHFIiAdG5a/6 zbHkeWsIlwZww== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Ym4Idk9Y Subject: Re: [Intel-wired-lan] [PATCH iwl-next 4/6] ice: remove unused recipe bookkeeping data X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, michal.swiatkowski@linux.intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jun 18, 2024 at 04:11:55PM +0200, Marcin Szycik wrote: > From: Michal Swiatkowski > > Remove root_buf from recipe struct. Its only usage was in ice_find_recp(), > where if recipe had an inverse action, it was skipped, but actually the > driver never adds inverse actions, so effectively it was pointless. > > Without root_buf, the recipe data element in ice_add_sw_recipe() does > not need to be persistent and can also be automatically deallocated with > __free, which nicely simplifies unroll. > > Signed-off-by: Michal Swiatkowski > Reviewed-by: Przemek Kitszel > Signed-off-by: Marcin Szycik Reviewed-by: Simon Horman