From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28B77C2BD09 for ; Mon, 1 Jul 2024 13:25:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A7FF340DD0; Mon, 1 Jul 2024 13:25:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Nj57fhFq7uHv; Mon, 1 Jul 2024 13:25:12 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org AAFAF40495 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1719840312; bh=zB2SvMoqNufq32y+7+S8ciYBTCaynthO2jF+5FS0wKA=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=vdiJ2TWmEa7pq+GAgwwZKihOhTp6HVWog6LsYAv9LvsbOduV8NzksGZMsswUQ/lEl SEaEK8MtdJj/UBOocD/2/ZvOcLbdMsagt7Gve937WFEOKk0Re0CMl4tAGzvNCQqCo9 qOHL6RcCEYnV0GOdP3RpS+0XE8t9jMzSwrbbiFBA3r49JucU8tsSIRGP1ZXMg9FKdU oD8sUMSEm/aOijlGbZAnFBA7TNrME7KvPc72NiykyJmV9r02GrEYQ0rMBhKWRl5NJW XnCuS0W5W1aHOjJL4OEQX5qEAOK5jslL2VzaLIMAuWprdFYgDxpsnGNAAYcNMmGTKY J10IBi/MnSRAQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id AAFAF40495; Mon, 1 Jul 2024 13:25:12 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id B9BC31BF338 for ; Mon, 1 Jul 2024 13:25:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B240C40495 for ; Mon, 1 Jul 2024 13:25:11 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id bFud9GefXJwa for ; Mon, 1 Jul 2024 13:25:11 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org C408740275 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C408740275 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id C408740275 for ; Mon, 1 Jul 2024 13:25:10 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A5ECD61312; Mon, 1 Jul 2024 13:25:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03A2DC32786; Mon, 1 Jul 2024 13:25:07 +0000 (UTC) Date: Mon, 1 Jul 2024 14:25:05 +0100 From: Simon Horman To: Karol Kolacinski Message-ID: <20240701132505.GZ17134@kernel.org> References: <20240627151127.284884-9-karol.kolacinski@intel.com> <20240627151127.284884-11-karol.kolacinski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627151127.284884-11-karol.kolacinski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719840309; bh=D0/CEWGuvJGscf/vD5LTGqz5DliN0mtBJpu5nzWNAZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LNrE6wytoUV/09ibIITG72zc0LjbS/U4Ce3PCRFa4hs3ruq04Tuob6Z3LgP4NfnRr 9/3cayn5GqkOhXGsj9A+Rq8mvyrHB3ZIFS2yNW/aeHSHJkg0myOfyYtuIuiCs7b+ME S2RsVJjpf8cOZpTADp8t7y+NysoMQETRTywj7zfVrLJUKK3UEs6ORM/o6ywRNWwRpz eEeuvUzFP3MqaVgW38WFLip9VVxVRSD+1ix9shY1TeOAJZnyW6YlMfmu8DHbmIfZIM JwoDeeUhMtebl+GsJYjYG76VB/B6sLCgbf6/+yfTChlhIlf3Cku+5MP2ATUfgiwixf LjqjEQ0gZSI/A== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=LNrE6wyt Subject: Re: [Intel-wired-lan] [PATCH iwl-next 2/7] ice: Add SDPs support for E825C X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com, Arkadiusz Kubalewski , intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, Jun 27, 2024 at 05:09:26PM +0200, Karol Kolacinski wrote: > Add support of PTP SDPs (Software Definable Pins) for E825C products. > > Reviewed-by: Arkadiusz Kubalewski > Signed-off-by: Karol Kolacinski ... > @@ -2623,9 +2633,13 @@ static void ice_ptp_set_funcs_e82x(struct ice_pf *pf) > pf->ptp.info.getcrosststamp = ice_ptp_getcrosststamp_e82x; > > #endif /* CONFIG_ICE_HWTS */ > - pf->ptp.info.enable = ice_ptp_gpio_enable; > - pf->ptp.info.verify = ice_verify_pin; > - pf->ptp.ice_pin_desc = ice_pin_desc_e82x; > + if (ice_is_e825c(&pf->hw)) { > + pf->ptp.ice_pin_desc = ice_pin_desc_e825c; > + pf->ptp.info.n_pins = ICE_PIN_DESC_ARR_LEN(ice_pin_desc_e825c); > + } else { > + pf->ptp.ice_pin_desc = ice_pin_desc_e82x; > + pf->ptp.info.n_pins = ICE_PIN_DESC_ARR_LEN(ice_pin_desc_e82x); > + } > pf->ptp.info.n_pins = ICE_PIN_DESC_ARR_LEN(ice_pin_desc_e82x); Hi Karol, Maybe I'm reading it wrong, but should the line immediately above be remove to avoid overwriting the value for pf->ptp.info.n_pins set in the new if/else condition above? > ice_ptp_setup_pin_cfg(pf); > } > @@ -2673,6 +2687,8 @@ static void ice_ptp_set_caps(struct ice_pf *pf) > info->settime64 = ice_ptp_settime64; > info->n_per_out = GLTSYN_TGT_H_IDX_MAX; > info->n_ext_ts = GLTSYN_EVNT_H_IDX_MAX; > + info->enable = ice_ptp_gpio_enable; > + info->verify = ice_verify_pin; > > if (ice_is_e810(&pf->hw)) > ice_ptp_set_funcs_e810(pf, info); Moving these assignments seems unnecessary, but ok.