From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: sasha.neftin@intel.com,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
netdev@vger.kernel.org, richardcochran@gmail.com,
kurt@linutronix.de, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
daiweili@gmail.com, anthony.l.nguyen@intel.com,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: [Intel-wired-lan] [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts for 82580
Date: Fri, 9 Aug 2024 17:23:02 -0700 [thread overview]
Message-ID: <20240810002302.2054816-1-vinicius.gomes@intel.com> (raw)
It was reported that 82580 NICs have a hardware bug that makes it
necessary to write into the TSICR (TimeSync Interrupt Cause) register
to clear it.
Add a conditional so only for 82580 we write into the TSICR register,
so we don't risk losing events for other models.
This (partially) reverts commit ee14cc9ea19b ("igb: Fix missing time sync events").
Fixes: ee14cc9ea19b ("igb: Fix missing time sync events")
Reported-by: Daiwei Li <daiweili@gmail.com>
Closes: https://lore.kernel.org/intel-wired-lan/CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w@mail.gmail.com/
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
---
@Daiwei Li, I don't have a 82580 handy, please confirm that the patch
fixes the issue you are having.
drivers/net/ethernet/intel/igb/igb_main.c | 27 ++++++++++++++++++-----
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 11be39f435f3..edb34f67ae03 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -6960,31 +6960,48 @@ static void igb_extts(struct igb_adapter *adapter, int tsintr_tt)
static void igb_tsync_interrupt(struct igb_adapter *adapter)
{
struct e1000_hw *hw = &adapter->hw;
- u32 tsicr = rd32(E1000_TSICR);
+ u32 ack = 0, tsicr = rd32(E1000_TSICR);
struct ptp_clock_event event;
if (tsicr & TSINTR_SYS_WRAP) {
event.type = PTP_CLOCK_PPS;
if (adapter->ptp_caps.pps)
ptp_clock_event(adapter->ptp_clock, &event);
+ ack |= TSINTR_SYS_WRAP;
}
if (tsicr & E1000_TSICR_TXTS) {
/* retrieve hardware timestamp */
schedule_work(&adapter->ptp_tx_work);
+ ack |= E1000_TSICR_TXTS;
}
- if (tsicr & TSINTR_TT0)
+ if (tsicr & TSINTR_TT0) {
igb_perout(adapter, 0);
+ ack |= TSINTR_TT0;
+ }
- if (tsicr & TSINTR_TT1)
+ if (tsicr & TSINTR_TT1) {
igb_perout(adapter, 1);
+ ack |= TSINTR_TT1;
+ }
- if (tsicr & TSINTR_AUTT0)
+ if (tsicr & TSINTR_AUTT0) {
igb_extts(adapter, 0);
+ ack |= TSINTR_AUTT0;
+ }
- if (tsicr & TSINTR_AUTT1)
+ if (tsicr & TSINTR_AUTT1) {
igb_extts(adapter, 1);
+ ack |= TSINTR_AUTT1;
+ }
+
+ if (hw->mac.type == e1000_82580) {
+ /* 82580 has a hardware bug that requires a explicit
+ * write to clear the TimeSync interrupt cause.
+ */
+ wr32(E1000_TSICR, ack);
+ }
}
static irqreturn_t igb_msix_other(int irq, void *data)
--
2.45.2
next reply other threads:[~2024-08-10 0:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 0:23 Vinicius Costa Gomes [this message]
2024-08-10 4:21 ` [Intel-wired-lan] [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts for 82580 Paul Menzel
2024-08-10 5:04 ` Richard Cochran
2024-08-10 15:55 ` Daiwei Li
2024-08-12 17:59 ` Vinicius Costa Gomes
2024-08-13 3:35 ` [Intel-wired-lan] [PATCH iwl-net v2] " Daiwei Li
2024-08-13 22:26 ` Vinicius Costa Gomes
2024-08-14 4:58 ` Daiwei Li
2024-08-13 4:12 ` [Intel-wired-lan] [PATCH iwl-net v1] " Ratheesh Kannoth
2024-08-13 15:02 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240810002302.2054816-1-vinicius.gomes@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=daiweili@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox