From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F817C3DA4A for ; Fri, 16 Aug 2024 09:38:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EFD4D605A8; Fri, 16 Aug 2024 09:38:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Aoz3TkMtk65a; Fri, 16 Aug 2024 09:38:44 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 594E160605 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1723801124; bh=4A0ncITU7sK44pZjbb9IGN+bBgHKoi/AYwMNN3yoM3w=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=PtHk5sAO3X9NWGEp19RSv8LyNSSTBUfMABd9Oxc6OXUDlSB9fyysEK7nFuFOOJlvI 3/9jbERGGhP94EAQMutuQucwJyPpSxgIkp6aUi/B+CBFYXOHaI+je4sELUcD1UFB03 lzomMFG1sLbzX1XgqxklsZYlCtPWZLy5tdykEXgho6prJbIJdcEGfFWN3uJ4XtzLtT PD9PiVkYnYOtU1n4r4izJKxXN96UJoo+vCm8yREcbH+8yUWHxdty9JNOYwDXRfPtHZ qvEfEM4L3E+I3rFWkhCzIF/NhswTe1cTfu/Nv1IHTr3RKsmvlRwUlm5L7lYvhcmudd Y08mSmxt67IuA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 594E160605; Fri, 16 Aug 2024 09:38:44 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 186FB1BF292 for ; Fri, 16 Aug 2024 09:38:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7325460605 for ; Fri, 16 Aug 2024 09:38:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id I2R_3LG29DKb for ; Fri, 16 Aug 2024 09:38:42 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=193.142.43.55; helo=galois.linutronix.de; envelope-from=bigeasy@linutronix.de; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org BC7F5605A8 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BC7F5605A8 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by smtp3.osuosl.org (Postfix) with ESMTPS id BC7F5605A8 for ; Fri, 16 Aug 2024 09:38:41 +0000 (UTC) Date: Fri, 16 Aug 2024 11:38:38 +0200 From: Sebastian Andrzej Siewior To: Kurt Kanzenbach Message-ID: <20240816093838.ZpGD38t-@linutronix.de> References: <20240711-b4-igb_zero_copy-v6-0-4bfb68773b18@linutronix.de> <20240711-b4-igb_zero_copy-v6-1-4bfb68773b18@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240711-b4-igb_zero_copy-v6-1-4bfb68773b18@linutronix.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1723801119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4A0ncITU7sK44pZjbb9IGN+bBgHKoi/AYwMNN3yoM3w=; b=YlheqFlOvIePYCb9WAVjljhc+ynBrUApZXQYXstjqBQ7JagjcVNlO+vjOsbGY9L1NVxIAx IV+KSpFvO+znRhG6IxxP3nUhqgJ28WQtgf3sSZaNOb/cnXlADWaqt+9qTFQmZ2T+N0BPt5 FVQzZZ4VD0w5f4FZ9c3UhGukjaPzOQVighKCAZWSti+Jv8fmsbY6Zyw2+tsWUqHbwuQ3Ty fMxzr9TDCn0iUt1zyno+pTIuehwETgdedOnAUPjAoRVG5RFXicOc7LBqyIt90zwPUfMMnp VIKV2uqUSPbHBCVHrfSJAfe2ojce9h+j2yMzf+nNvmtoeY7++fuLaJoEO9GpaA== X-Mailman-Original-DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1723801119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4A0ncITU7sK44pZjbb9IGN+bBgHKoi/AYwMNN3yoM3w=; b=TkwzjobRKZQFsqAnvwafio5sXYbUAd8gBXbxX7QN60OTP2eVC0uiXRduOEJ8cNZr3QPkm5 tL6wBeB4koKMWrAw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=linutronix.de X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=YlheqFlO; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=TkwzjobR Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 1/6] igb: Always call igb_xdp_ring_update_tail() under Tx lock X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maciej Fijalkowski , Jesper Dangaard Brouer , Daniel Borkmann , Sriram Yagnaraman , Przemek Kitszel , Richard Cochran , John Fastabend , Alexei Starovoitov , Sriram Yagnaraman , Benjamin Steinke , Eric Dumazet , netdev@vger.kernel.org, Tony Nguyen , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , bpf@vger.kernel.org, Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 2024-08-16 11:24:00 [+0200], Kurt Kanzenbach wrote: > index 11be39f435f3..4d5e5691c9bd 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -2914,6 +2914,7 @@ static int igb_xdp(struct net_device *dev, struct netdev_bpf *xdp) > } > } > > +/* This function assumes __netif_tx_lock is held by the caller. */ > static void igb_xdp_ring_update_tail(struct igb_ring *ring) > { > /* Force memory writes to complete before letting h/w know there This lockdep_assert_held(txring_txq(ring)->_xmit_lock); would be more powerful than the comment ;) Sebastian