From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1161C5321D for ; Fri, 23 Aug 2024 20:33:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7D31B41307; Fri, 23 Aug 2024 20:33:48 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OykVyHqSSCz3; Fri, 23 Aug 2024 20:33:47 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7E27241302 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1724445227; bh=hI8eS6AirCJNgGieTTUBTviIU/S3XybYWf2Yv3HqnCA=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=nuJTfWHMw9IxrrwAgcfX75BoTKB9aBEJV3LUD0+RwmeXUIWuiuonn52HLRa5MfQ41 Npm0U7YI3Kbf3bSmW0TDS8isHr/92KxatsEi2N1TPWBZL+BlhvQ8fbeygEOaE2Wulo JnF87Jjzs4ux68jZ231B8a+TQk/a+lYLLeonlQXo19WfxjmjV+bRQ1pCh1vyhtjMqr KHP15r09yfxg41UFTvkR9EsaJ8h54IhGAVpoWIRfgN0pcaR2V9Gl0KovYDiQ25JVn6 WI6VFZ9h6tprOgSHfi8k3E3SS6x54UaNvVE9q7yFLY4bAt2IF1BjtiqNZO1wTqYEcf /OvH58L+gqKNQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 7E27241302; Fri, 23 Aug 2024 20:33:47 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 28A461BF2F1 for ; Fri, 23 Aug 2024 20:33:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2356241302 for ; Fri, 23 Aug 2024 20:33:46 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id IG0kVlRvKyb3 for ; Fri, 23 Aug 2024 20:33:45 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org D806D412FA DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D806D412FA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id D806D412FA for ; Fri, 23 Aug 2024 20:33:44 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6B53FCE125F; Fri, 23 Aug 2024 20:33:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDC2FC4AF09; Fri, 23 Aug 2024 20:33:39 +0000 (UTC) Date: Fri, 23 Aug 2024 21:33:37 +0100 From: Simon Horman To: Karol Kolacinski Message-ID: <20240823203337.GH2164@kernel.org> References: <20240820102402.576985-8-karol.kolacinski@intel.com> <20240820102402.576985-11-karol.kolacinski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240820102402.576985-11-karol.kolacinski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724445221; bh=AUYPCHt3tYNY9yFLugWcI1QD2hn6lJfc/4jgQhr4Szg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VtZMp+jSxLRK32WyV/0NUGBkmuXlJfkzdQcMcR1VZ6k1cCZIKK9prg5wG7xi4I4aH RJY0atKWWJxxqo7kZTJvFhXx7DvKxXV5w/LW17Qw+CzIWBHoFPi3eB5/qmMbS/dw6V PCiOij8cESjSCC/qAy28Z4sP+hk/OcXMApjyGQyhGLpYthWjHlUiGjGvriZbLLlfTG v/1TkV8WzXvLx71y/ir/gDB1ccqJOuxIrNywrO4y1wRZSWo3r+2H5M1BownBQB7WUZ nIoxjnfFmYAhjx2EVWLV6VU+7zugTn32st5IsXF6EpZMVU66Nj4bsvZWDrGPyCoFfd Veyx4pptmJwqQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=VtZMp+jS Subject: Re: [Intel-wired-lan] [PATCH v7 iwl-next 3/6] ice: Implement PTP support for E830 devices X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Greenwalt , Michal Michalik , netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org, Milena Olech Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Aug 20, 2024 at 12:21:50PM +0200, Karol Kolacinski wrote: > From: Michal Michalik > > Add specific functions and definitions for E830 devices to enable > PTP support. > Introduce new PHY model ICE_PHY_E830. > E830 devices support direct write to GLTSYN_ registers without shadow > registers and 64 bit read of PHC time. > > Reviewed-by: Przemek Kitszel > Co-developed-by: Milena Olech > Signed-off-by: Milena Olech > Co-developed-by: Paul Greenwalt > Signed-off-by: Paul Greenwalt > Signed-off-by: Michal Michalik > Co-developed-by: Karol Kolacinski > Signed-off-by: Karol Kolacinski ... > diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c ... > @@ -1405,10 +1416,11 @@ void ice_ptp_link_change(struct ice_pf *pf, u8 port, bool linkup) > > switch (hw->mac_type) { > case ICE_MAC_E810: > - /* Do not reconfigure E810 PHY */ > + case ICE_MAC_E830: > + /* Do not reconfigure E810 or E830 PHY */ > return; > - case ICE_MAC_GENERIC_3K_E825: > case ICE_MAC_GENERIC: > + case ICE_MAC_GENERIC_3K_E825: > ice_ptp_port_phy_restart(ptp_port); > return; > default: The re-ordering of ICE_MAC_GENERIC_3K_E825 does not feel like it belongs in this patch. Perhaps it can be squashed into the earlier patch in the series that adds the code that is being shuffled here? ... > @@ -3271,10 +3285,8 @@ static int ice_ptp_init_port(struct ice_pf *pf, struct ice_ptp_port *ptp_port) > mutex_init(&ptp_port->ps_lock); > > switch (hw->mac_type) { > - case ICE_MAC_GENERIC_3K_E825: > - return ice_ptp_init_tx_eth56g(pf, &ptp_port->tx, > - ptp_port->port_num); > case ICE_MAC_E810: > + case ICE_MAC_E830: > return ice_ptp_init_tx_e810(pf, &ptp_port->tx); > case ICE_MAC_GENERIC: > kthread_init_delayed_work(&ptp_port->ov_work, > @@ -3282,6 +3294,9 @@ static int ice_ptp_init_port(struct ice_pf *pf, struct ice_ptp_port *ptp_port) > > return ice_ptp_init_tx_e82x(pf, &ptp_port->tx, > ptp_port->port_num); > + case ICE_MAC_GENERIC_3K_E825: > + return ice_ptp_init_tx_eth56g(pf, &ptp_port->tx, > + ptp_port->port_num); > default: > return -ENODEV; > } Ditto. ...