From: Manoj Vishwanathan <manojvishy@google.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org,
Manoj Vishwanathan <manojvishy@google.com>,
linux-kernel@vger.kernel.org,
google-lan-reviews@googlegroups.com
Subject: [Intel-wired-lan] [[PATCH v2 iwl-next] v2 0/4]
Date: Mon, 26 Aug 2024 18:10:28 +0000 [thread overview]
Message-ID: <20240826181032.3042222-1-manojvishy@google.com> (raw)
IDPF Virtchnl: Enhance error reporting & fix locking/workqueue issues
This patch series addresses several IDPF virtchnl issues:
* Improved error reporting for better diagnostics.
* Fixed locking sequence in virtchnl message handling to avoid potential race conditions.
* Converted idpf workqueues to unbound to prevent virtchnl processing delays under heavy load.
Previously, CPU-bound kworkers for virtchnl processing could be starved,
leading to transaction timeouts and connection failures.
This was particularly problematic when IRQ traffic and user space processes contended for the same CPU.
By making the workqueues unbound, we ensure virtchnl processing is not tied to a specific CPU,
improving responsiveness even under high system load.
---
V2:
- Dropped patch from Willem
- RCS/RCT variable naming
- Improved commit message on feddback
v1: https://lore.kernel.org/netdev/20240813182747.1770032-2-manojvishy@google.com/T/
David Decotigny (1):
idpf: address an rtnl lock splat in tx timeout recovery path
Manoj Vishwanathan (2):
idpf: Acquire the lock before accessing the xn->salt
idpf: add more info during virtchnl transaction time out
Marco Leogrande (1):
idpf: convert workqueues to unbound
drivers/net/ethernet/intel/idpf/idpf_main.c | 15 ++++++++++-----
drivers/net/ethernet/intel/idpf/idpf_txrx.c | 14 +++++++++++++-
drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 12 +++++++-----
3 files changed, 30 insertions(+), 11 deletions(-)
--
2.46.0.295.g3b9ea8a38a-goog
next reply other threads:[~2024-08-26 18:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 18:10 Manoj Vishwanathan [this message]
2024-08-26 18:10 ` [Intel-wired-lan] [[PATCH v2 iwl-next] v2 1/4] idpf: address an rtnl lock splat in tx timeout recovery path Manoj Vishwanathan
2024-08-28 21:28 ` Jacob Keller
2024-08-26 18:10 ` [Intel-wired-lan] [[PATCH v2 iwl-next] v2 2/4] idpf: Acquire the lock before accessing the xn->salt Manoj Vishwanathan
2024-08-28 21:29 ` Jacob Keller
2024-08-30 6:04 ` Przemek Kitszel
2024-08-30 21:31 ` Keller, Jacob E
2024-08-29 15:54 ` Linga, Pavan Kumar
2024-08-26 18:10 ` [Intel-wired-lan] [[PATCH v2 iwl-next] v2 3/4] idpf: convert workqueues to unbound Manoj Vishwanathan
2024-08-28 22:02 ` Jacob Keller
2024-08-29 16:02 ` Linga, Pavan Kumar
2024-08-26 18:10 ` [Intel-wired-lan] [[PATCH v2 iwl-next] v2 4/4] idpf: add more info during virtchnl transaction time out Manoj Vishwanathan
2024-08-28 22:03 ` Jacob Keller
2024-08-29 16:07 ` Linga, Pavan Kumar
2024-08-29 20:11 ` [Intel-wired-lan] [[PATCH v2 iwl-next] v2 0/4] Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826181032.3042222-1-manojvishy@google.com \
--to=manojvishy@google.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=google-lan-reviews@googlegroups.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox