From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7423FCA101B for ; Fri, 30 Aug 2024 23:42:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0E586846AC; Fri, 30 Aug 2024 23:42:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 0CsPtlcChp2y; Fri, 30 Aug 2024 23:42:51 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 74DE4846B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1725061371; bh=pszuPJQhFLcXBbvSnp0dN0RGPizWatEDnWhRvgFzoF4=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=I2I2iNGPdVFxjPd4BVcDyiHtVkkJEJn7D+0TIOX0FiiTnGprZ1BumUPmm7C+Ztb6R WAZB1hER7/D4XRab95HexnKrCrIYQ6FcepNqJw7KTlGCvidIvYVRKAgwYnplq+Y+y+ 6Uo1U/DMVule81/C4VuA84JyqJOFtWADNXIGEUELpW3l3yYb1RmZYe6hQtnobvarSv M/SnI0qq5QwcAdfl/B8u3rVYWLpcNWK3Ayhymn59ZuKraj0GDBgYiu9Fs8I0BeUGrY Y8ejwxh0GLq7zBUFdy0Sdcm3upLwLHQpweT1hPVSIl4LJcDeL3U3s5Jl92Hkg5pn4u 5Y+0fmKHYnbIQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 74DE4846B0; Fri, 30 Aug 2024 23:42:51 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 80F0C1BF20F for ; Fri, 30 Aug 2024 23:42:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7ABC460708 for ; Fri, 30 Aug 2024 23:42:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id MCdDSWJLFDFF for ; Fri, 30 Aug 2024 23:42:50 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org C004E606F3 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C004E606F3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp3.osuosl.org (Postfix) with ESMTPS id C004E606F3 for ; Fri, 30 Aug 2024 23:42:49 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 23B5FA44676; Fri, 30 Aug 2024 23:42:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A9E9C4CEC7; Fri, 30 Aug 2024 23:42:47 +0000 (UTC) Date: Fri, 30 Aug 2024 16:42:46 -0700 From: Jakub Kicinski To: Paolo Abeni Message-ID: <20240830164246.73649979@kernel.org> In-Reply-To: <20240830113900.4c5c9b2a@kernel.org> References: <53077d35a1183d5c1110076a07d73940bb2a55f3.1724944117.git.pabeni@redhat.com> <20240829182019.105962f6@kernel.org> <57ef8eb8-9534-4061-ba6c-4dadaf790c45@redhat.com> <20240830113900.4c5c9b2a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725061367; bh=gdoQctlXEsRYR0UYWAtrxA9rkf2AKKcV7usYOpNoZW8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jzJxGk5EgXVF/4YzZAbWkp4cI8uutZDyvdWX3VinL6NCtYZII/+/tmshm+Mp4Ns4w Y2TYqer6ie2duPaH+IINwnFKXqjB6AYa+areqb4Y3QnNvO1NC5kyYX0xcmi/+J3XMj LG87KQW33qnBCaU3ewnxPuEQtCkUR9nJmzOas/9KFj3O9m8PKgLNmAtPxXMWCSsa5W c/LBl/4XTjkXmJ73ub6WA2B7qvf5747M55Bsqwt0fiEyr+ouEjA7WalkBcub4gZogf ifmmm3UYfNL/ABuzFs2XImOMSY3G+I/exPDUthmBzlNl1OH8GYJLdLaBaecnjSiKuj A4G9DhHuyf79Q== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=jzJxGk5E Subject: Re: [Intel-wired-lan] [PATCH v5 net-next 02/12] net-shapers: implement NL get operation X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , netdev@vger.kernel.org, John Fastabend , Jamal Hadi Salim , edumazet@google.com, Madhu Chittim , anthony.l.nguyen@intel.com, Simon Horman , Sridhar Samudrala , Donald Hunter , intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, Sunil Kovvuri Goutham Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 30 Aug 2024 11:39:00 -0700 Jakub Kicinski wrote: > > There is a misunderstanding. This helper will be used in a following > > patch (7/12) with a different 'type' argument: > > NET_SHAPER_A_BINDING_IFINDEX. I've put a note in the commit message, but > > was unintentionally dropped in one of the recent refactors. I'll add > > that note back. > > What I'm saying is that if you want to prep the ground for more > "binding" types you should also add: > > if (type != ...IFINDEX) { > /* other binding types are TBD */ > return -EINVAL; > } Ah, the part I missed is that there are two different types for ifindex: NET_SHAPER_A_IFINDEX NET_SHAPER_A_CAPABILITIES_IFINDEX Got it now.