From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20AB5CD4F4C for ; Thu, 5 Sep 2024 01:03:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BCDB140B9E; Thu, 5 Sep 2024 01:03:37 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ogeYt5sXXePY; Thu, 5 Sep 2024 01:03:35 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6654340B57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1725498215; bh=He/j/R9ukZGte7HLKjuUofXyAApQ5u7KYcQrnvHmyK8=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=aXVKohld5NBWC1KLHrfPHa/DEP7onTwFqq5Om+qkGmL7wujcQa6YzpHPchJgq2/5L dZjZN8u/+xR2VMVI/FGKLTqxqPONioD5kwInDRAHCgCqRyhlaTg+5a+cw07XJcyCpZ GfqxSlWOj/O08S/Kx9CM7c+mCkg/6N3vN4z4fF8yANkP3CjORa9oZeq3HyPOYgPJln HyprZAxu9Zg4ocrcu+y5HkCbZSOqUuAxZopOvlztT2Lq6cItus1su4TTeAj+wZKj31 JfhE0rBkLGtugnqHoKlI5wIFkG01owErlJx7WL6mCEv5fHm914m2yEW89oBbEHaWbY UFPzYW9Pas6yg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 6654340B57; Thu, 5 Sep 2024 01:03:35 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 444551BF263 for ; Thu, 5 Sep 2024 01:03:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 31380605FF for ; Thu, 5 Sep 2024 01:03:34 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id HWH6uFifJiXA for ; Thu, 5 Sep 2024 01:03:33 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 6D533600B8 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6D533600B8 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6D533600B8 for ; Thu, 5 Sep 2024 01:03:33 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0F2B9A41FD8; Thu, 5 Sep 2024 01:03:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C2D2C4CEC9; Thu, 5 Sep 2024 01:03:31 +0000 (UTC) Date: Wed, 4 Sep 2024 18:03:30 -0700 From: Jakub Kicinski To: Paolo Abeni Message-ID: <20240904180330.522b07c5@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725498211; bh=mBo1M+6e6dT1/Ok93GvGsN3bfzsU8Icz47GwhvHuvU8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HyjXFFLcxwLxMxQSpWyDJZuCU3rWXCn6VSOZhWX8fuGmKzor/qw7slbuia/oROApn iOEe2JZ1VM7LJEyKTSyhEVe27jb0nPW/Yyw3vgfmQ8v9qld8Q2W13m2eyEqDdXI8ci 32jM68GNUoM74G2DpA0Tnut20KpocyxedHX8alyNwdbuoNIK8UXdvHeIAKHt55IVQp qOuAQoGF2WiC5iIGoSVtPVflDgdKCpP1mKgsyPPxeaVewaeZQ7CzggmcoGvzFZKF5B EQ6Z/6F0bvMCtFb2ylmkKwoO/gv2LfSvcPvpVKyzEKbtiNXOtF9do/WQwpoYNKJVJm oBnUQYXduV89Q== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=HyjXFFLc Subject: Re: [Intel-wired-lan] [PATCH v6 net-next 02/15] netlink: spec: add shaper YAML spec X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , netdev@vger.kernel.org, John Fastabend , Jamal Hadi Salim , edumazet@google.com, Madhu Chittim , anthony.l.nguyen@intel.com, Simon Horman , Sridhar Samudrala , Donald Hunter , intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, Sunil Kovvuri Goutham Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 4 Sep 2024 15:53:34 +0200 Paolo Abeni wrote: > +doc: | > + Networking HW rate limiting configuration. > + > + This API allows configuring HW shapers available on the network > + devices at different levels (queues, network device) and allows > + arbitrary manipulation of the scheduling tree of the involved > + shapers. > + > + Each @shaper is identified within the given device, by an @handle, > + comprising both a @scope and an @id. > + > + Depending on the @scope value, the shapers are attached to specific > + HW objects (queues, devices) or, for @node scope, represent a > + scheduling group, that can be placed in an arbitrary location of > + the scheduling tree. > + > + Shapers can be created with two different operations: the @set > + operation, to create and update a single "attached" shaper, and > + the @group operation, to create and update a scheduling > + group. Only the @group operation can create @node scope shapers > + > + Existing shapers can be deleted /reset via the @delete operation. nit: space before the / ? > + name: bw-min > + type: uint > + doc: Minimum Guaranteed bandwidth for the given shaper. I think I asked to remove "Minimum"? Both "guaranteed" and "minimum" express the fact that we can't go lower, so it's a bit of a pleonasm. > + - > + name: node > + type: nest > + nested-attributes: node-info > + doc: | > + Describes the node shaper for a @group operation. > + Differently from @leaves and @shaper allow specifying > + the shaper parent handle, too. Parent handle is inside node scope? Why are leaves outside and parent inside? Both should be at the same scope, preferably main scope. > + - > + name: shaper > + type: nest > + nested-attributes: info > + doc: | > + Describes a single shaper for a @set operation. Why does this level of nesting exist? With the exception of ifindex all attributes for SET are nested inside this..