From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50670CD5BCB for ; Thu, 5 Sep 2024 15:05:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id EB0FA8126E; Thu, 5 Sep 2024 15:05:09 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5M2EW28lzMj3; Thu, 5 Sep 2024 15:05:09 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5D2A381204 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1725548709; bh=gEkC1zeGEeDpIlIt3lyYdl8Z6wRVbCzkwM1X2a5/Zpo=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=wl5jT+RYARgHbdj+4p8KoO7hdWCGsQfnacK5fOuESE0ZTYcEwEKsNcg0ChV1e2nVH RVt+3C9AyVT+RBt6yM/3VCjcMoMXivnWfY/XhCdfLJeLTsGaKzdfDH8J4gyYy7wFqT Urx/pLxmihpUN7Oq5nZs4scc02QZawiDN3za8MKC8N5X4CK/+685KgXP8pWr38FKE/ EDrXIdzHNWgJD9cQhDpvNVLhH3PadJTVlaCRSX2A4Dh9jV7CuNcj5QHGM6DuxsOVYA uwG73YHWVpfEImp1PcIxZ0OWT84LVlXUA2O8IhguXZ/goOaNPKNk7lVhh0pvpGgDkD g/XH848MgS1wA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 5D2A381204; Thu, 5 Sep 2024 15:05:09 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E41A91BF3D4 for ; Thu, 5 Sep 2024 15:05:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id CCBE28125A for ; Thu, 5 Sep 2024 15:05:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id l8RWSrkyOfmg for ; Thu, 5 Sep 2024 15:05:05 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org A3C7980CC9 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A3C7980CC9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id A3C7980CC9 for ; Thu, 5 Sep 2024 15:05:05 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 959545C5CFB; Thu, 5 Sep 2024 15:05:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B540C4CEC3; Thu, 5 Sep 2024 15:05:03 +0000 (UTC) Date: Thu, 5 Sep 2024 08:05:02 -0700 From: Jakub Kicinski To: Paolo Abeni Message-ID: <20240905080502.3246e040@kernel.org> In-Reply-To: References: <20240904180330.522b07c5@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725548703; bh=Ld8KTi3QDI3VDWXO6dPONOX6HZLHeHYM7DMRcCRDWfQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bxbGl6YiK5528f0iedkMc3CPab1WUFRuvkqkHVX96+Zgh5LxTYJAeda1dHTja1IYX Gm/euAa4fXmj0fJLGdu/e4Qt/L+MuVqG8q5yXMs5ohEpu+P039EeXwrrluWiIuZPqW Fn9SmZdx3Q0NJMkAPlsLr0PfgmN11LYsJK4RdptjDIVssru1zNI8lXDM+YliuVmcYt lM4tLHEWDzKbK+N7YX+WO/pMLPUCZhDKOjGYr64YyiCTM7gj6M86e6AnSPHDS4vks+ DAw6Hu8sO9SQW5XhlmiYqK4RrtEXgdl7PD9md7Zu1yVhODbJcD6UDzIdxaYUQI6Bh/ DHXIehKSrOgVQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bxbGl6Yi Subject: Re: [Intel-wired-lan] [PATCH v6 net-next 02/15] netlink: spec: add shaper YAML spec X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , netdev@vger.kernel.org, John Fastabend , Jamal Hadi Salim , edumazet@google.com, Madhu Chittim , anthony.l.nguyen@intel.com, Simon Horman , Sridhar Samudrala , Donald Hunter , intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, Sunil Kovvuri Goutham Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 5 Sep 2024 16:51:00 +0200 Paolo Abeni wrote: > On 9/5/24 03:03, Jakub Kicinski wrote: > > On Wed, 4 Sep 2024 15:53:34 +0200 Paolo Abeni wrote: > >> + - > >> + name: node > >> + type: nest > >> + nested-attributes: node-info > >> + doc: | > >> + Describes the node shaper for a @group operation. > >> + Differently from @leaves and @shaper allow specifying > >> + the shaper parent handle, too. > > > > Parent handle is inside node scope? Why are leaves outside and parent > > inside? Both should be at the same scope, preferably main scope. > > The group() op receives as arguments, in the main scope: > > ifindex > node > leaves > > 'parent' is a nested attribute for 'node', exactly as 'handle'. We need > to specify both to identify the 'node' itself (via the 'handle') and to > specify where in the hierarchy the 'node' will be located (via the > 'parent'). Do I read correctly that you would prefer: > > ifindex > node_handle > node_parent > leaves I don't see example uses in the cover letter or the test so there's a good chance I'm missing something, but... why node_parent? The only thing you need to know about the parent is its handle, so just "parent", right? Also why node_handle? Just "handle", and other attrs of the node can live in the main scope. Unless you have a strong reason to do this to simplify the code - "from netlink perspective" it looks like unnecessary nesting. The operation arguments describe the node, there's no need to nest things in another layer.