From: Joe Damato <jdamato@fastly.com>
To: netdev@vger.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Joe Damato <jdamato@fastly.com>,
open list <linux-kernel@vger.kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Eric Dumazet <edumazet@google.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: [Intel-wired-lan] [RFC net-next 0/1] idpf: Don't hardcode napi_struct size
Date: Wed, 25 Sep 2024 18:00:16 +0000 [thread overview]
Message-ID: <20240925180017.82891-1-jdamato@fastly.com> (raw)
Greetings:
While working on an RFC which adds fields to napi_struct [1], I got a
warning from the kernel test robot about tripping an assertion in idpf
which seems to hardcode the size of napi_struct. The assertion was
triggered after applying patch 3 from the RFC [2].
I'm submitting this as an RFC so the Intel folks have time to take a
look and request changes, but I plan to submit this next week when
net-next reopens.
I did not want to the include this change in my RFC v4 because I wanted
to keep the review of that RFC focused on the in core work instead, so I
was hoping Intel would be OK to merge this (or a change which
accomplishes the same thing).
Please note: I do not have this hardware and thus have only compile
tested this.
Thanks,
Joe
[1]: https://lore.kernel.org/netdev/20240912100738.16567-1-jdamato@fastly.com/
[2]: https://lore.kernel.org/netdev/20240912100738.16567-6-jdamato@fastly.com/
Joe Damato (1):
idpf: Don't hard code napi_struct size
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
--
2.25.1
next reply other threads:[~2024-09-25 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 18:00 Joe Damato [this message]
2024-09-25 18:00 ` [Intel-wired-lan] [RFC net-next 1/1] idpf: Don't hard code napi_struct size Joe Damato
2024-09-25 20:33 ` Simon Horman
2024-09-30 12:33 ` Alexander Lobakin
2024-09-30 12:38 ` Alexander Lobakin
2024-09-30 13:10 ` Przemek Kitszel
2024-09-30 22:17 ` Joe Damato
2024-10-01 13:14 ` Alexander Lobakin
2024-10-01 14:44 ` Joe Damato
2024-10-02 17:17 ` Jakub Kicinski
2024-10-03 13:35 ` Alexander Lobakin
2024-10-03 15:46 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925180017.82891-1-jdamato@fastly.com \
--to=jdamato@fastly.com \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox