From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D2FECEB2E0 for ; Wed, 2 Oct 2024 17:17:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B628A41061; Wed, 2 Oct 2024 17:17:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 9hTVQqXp5aca; Wed, 2 Oct 2024 17:17:33 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7756C4043F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1727889453; bh=aNjF/nH5qxitY3E9vNWYPzr7Uc7Xsz8h0q7T62K3lKU=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=aYnzhwLlDuLp0LFVn27J3vAmxb3ZhyLQl/z2GcODhiq6oyWYXdG0BOzUmQlT6N0tg qR1WAMdfJmMMLwotxuYVyYzeFslCCDDsOhFWrFO7IHWLyzFiAwZ/sqt3LL0LVYHYWh 7cSXDO/+VRww02imojvzYdlLVAAyXN73uCY8xf4AcEgbSY/zBH5p5HfwPX2kygnsxB I3yodrJPtudu1HQ6FC0iIkXLGIKUnb/Tj8khVwsIll10IoXKBmDiXIw1cjmBahQ3uQ GRjDZZ2FvRYNEXpgMeRvURGzvwrEd31hSya2y+X8CTpX9P0/e/Sd1xiOJze/v6Enfo dzIAHzsyY5Yow== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 7756C4043F; Wed, 2 Oct 2024 17:17:33 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 3F5A11BF83E for ; Wed, 2 Oct 2024 17:17:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2DDE881760 for ; Wed, 2 Oct 2024 17:17:31 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Dq0Vd47sJV4R for ; Wed, 2 Oct 2024 17:17:30 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 799298175E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 799298175E Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp1.osuosl.org (Postfix) with ESMTPS id 799298175E for ; Wed, 2 Oct 2024 17:17:30 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id ACADCA4276E; Wed, 2 Oct 2024 17:17:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 576E4C4CEC2; Wed, 2 Oct 2024 17:17:28 +0000 (UTC) Date: Wed, 2 Oct 2024 10:17:27 -0700 From: Jakub Kicinski To: Alexander Lobakin , Przemek Kitszel Message-ID: <20241002101727.349fc146@kernel.org> In-Reply-To: References: <20240925180017.82891-1-jdamato@fastly.com> <20240925180017.82891-2-jdamato@fastly.com> <6a440baa-fd9b-4d00-a15e-1cdbfce52168@intel.com> <9f86b27c-8d5c-4df9-8d8c-91edb01b0b79@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727889448; bh=pfIEXJMb4PrK/x6Ayj1gPI5EQfPIRYz2z5v24LdJmEA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qzEnYJ9CkvJ8iZ4ixy2eyCWweBM9CPz5GeO+p2AgtBUNPETZ6/3NISG/9dC2KI1OY UtwAOkVXxti8ogfSILyF16Jvf/ToKHgA1de0pg7voPLqDgeSkeG77c9u1oVjLXJAk1 DsE2bEBwdFm1/EAo7jhlT/fjOT54ScBLPcmr/RIM0QGWOb2LYpNYLE1lFpV6nBxTAf nv3gBJiehRQNktWr9HRujEXZiH4Tbq3hPaDt9Z2kdwSWcMtVkmQeg7/ngel3QRVNxG F6rGxf6gNyw0cVBru74re6uWB2oBF5dHk9+RNEyIN4zzuY6UvONcoOoRf2fbquNsX5 J7Ud/KXCYedCQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=qzEnYJ9C Subject: Re: [Intel-wired-lan] [RFC net-next 1/1] idpf: Don't hard code napi_struct size X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Joe Damato , open list , Eric Dumazet , Tony Nguyen , Simon Horman , "moderated list:INTEL ETHERNET DRIVERS" , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 1 Oct 2024 07:44:36 -0700 Joe Damato wrote: > > But if you change any core API, let's say rename a field used in several > > drivers, you anyway need to adjust the affected drivers. > > Sorry, but that's a totally different argument. > > There are obvious cases where touching certain parts of core would > require changes to drivers, yes. I agree on that if I change an API > or a struct field name, or remove an enum, then this affects drivers > which must be updated. +1 I fully agree with Joe. Drivers asserting the size of core structures is both undue burden on core changes and pointless. The former is subjective, as for the latter: most core structures will contain cold / slow path data, usually at the end. If you care about performance of anything that follows a core struct you need to align the next field yourself. IDK how you want to fit this into your magic macros but complex nested types should be neither ro, rw nor cold. They are separate.