From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00A63CF34D9 for ; Fri, 4 Oct 2024 00:32:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AB3B460640; Fri, 4 Oct 2024 00:32:14 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WpT-xTtlT6Iw; Fri, 4 Oct 2024 00:32:12 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CA56E60609 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1728001932; bh=j9oGV6Cw5iu98mINIxSNPzzHTiULchRXBmFSgXmv8L0=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=jMfWqDZzmRozNsd9srUqJDjXPGmf+Z/jgzwfwhyEyh5/DV5bg+tzWZPVRGQy6Bqkv tBk3XEZRROx6ONPdsI8IuQq82zH5BFUJZIwzfzFeFGPZkyZ7n5pKJRax7/BVJIzfaN gX+rr8yxcwezKz1sXzeffHqwwdH+Mfq0AhUFeKFB4Rnc1ovGgjdonDGai3QTate3ti SmvSHZCbY1cwP3b7rs5Eh+CTNUaoS5z0L7/v/4CNpeBegRbQ+IzxLKd6Ac8tmIgbG7 swnqbLjxJpIX8V24MxjIQNcHbPRLJqyCo7LMNZZA7dNNPgoTH5W+F9dkz9Qx3ptnMW n98taxiavByGg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id CA56E60609; Fri, 4 Oct 2024 00:32:12 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 50C981BF982 for ; Fri, 4 Oct 2024 00:32:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4B1A440B24 for ; Fri, 4 Oct 2024 00:32:12 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DsuKXE7zWV67 for ; Fri, 4 Oct 2024 00:32:11 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 77887407A6 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 77887407A6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 77887407A6 for ; Fri, 4 Oct 2024 00:32:11 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1DB7F5C5C9B; Fri, 4 Oct 2024 00:32:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B001C4CEC5; Fri, 4 Oct 2024 00:32:09 +0000 (UTC) Date: Thu, 3 Oct 2024 17:32:08 -0700 From: Jakub Kicinski To: Joe Damato Message-ID: <20241003173208.553f0cfc@kernel.org> In-Reply-To: <20240930162422.288995-2-jdamato@fastly.com> References: <20240930162422.288995-1-jdamato@fastly.com> <20240930162422.288995-2-jdamato@fastly.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728001930; bh=0euF5hnFLXpDZPkAgzy4pr7Yli5RFu5Rd+Pthg74fUY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HZxU6//0Q6wgdA8SCfIYM4w3FUtPHKOnF7Q6lO49wvmA7FnPexajJiDruNaBdCNLl Zu6U0fB6vEAuOrw4oVNtid9tmYJk0vMJOCivFj6GYcT64r1YS4yAA0RKJ9t4dyuzmv CVzML6RdjaTAy2nqtDtMdPPDb1Ex4z/gqaWUNZzUx6cJwxRmi4DIl/shBM1dyYhYkV adJx4gEL5RUYJs6lFHAHCBw5itQWa+aMeEpaaTKHeaJSmfEReIoxqUWI34aRlSBIZS sGMFyfyxBE9+E60Ea37u2LJdOgeDpTkQ953NKBAf7bs+DmGqPrI8VJNpdhXzZFpeW7 DQJ6lGXhFbpMQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=HZxU6//0 Subject: Re: [Intel-wired-lan] [net-next v2 1/1] idpf: Don't hard code napi_struct size X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, open list , Alexander Lobakin , Eric Dumazet , Tony Nguyen , Simon Horman , Przemek Kitszel , "moderated list:INTEL ETHERNET DRIVERS" , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 30 Sep 2024 16:24:22 +0000 Joe Damato wrote: > The sizeof(struct napi_struct) can change. Don't hardcode the size to > 400 bytes and instead use "sizeof(struct napi_struct)". > > While fixing this, also move other calculations into compile time > defines. Anticipating v3 with smaller diff based on Olek's suggestion so: pw-bot: cr