From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87C1DCF042B for ; Wed, 9 Oct 2024 00:14:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2260181196; Wed, 9 Oct 2024 00:14:12 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 19P3_QuroEJE; Wed, 9 Oct 2024 00:14:11 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 65ED881197 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1728432851; bh=Twh0CAL7l58wLDNeygKwtnTU/6uRMqH2dV0D4xJVuCw=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=3oRaQnxxBbtS4xAKY8MwVjusgDQK1K2e+GNkG+UYAulyEH8wgdDHivQ7Hlc5ulm7u Hv9dqUg/DD3Fw80V+oF+QZF7Lwa3UHPovOX+DoD/4eMzyopEUZ0Z6oqIeUNAHsyT1G 0dCwFQDakV1sKZrpye6uhrNNZisdmj+JfZoU4hxwvN5aB0wUisQDsOHrbEsyL6AXr6 RRBTRM15zCBEaM5cri3xPhes6wkOrwXK8Gve0DmoEJyC236bh7O28hXFNRlmmltZ2Z 9JgA4ugac4FOfg7Xv1N1V1JryZ/Wil8scaRPQIVW1DhFpfoLyEZ8+3D1je7bSI5yXB a+SEZp/bx9Fzw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 65ED881197; Wed, 9 Oct 2024 00:14:11 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D27281BF47F for ; Wed, 9 Oct 2024 00:14:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BB1AF405EF for ; Wed, 9 Oct 2024 00:14:09 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id D7JUiz8DqkSK for ; Wed, 9 Oct 2024 00:14:09 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org D305A405ED DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D305A405ED Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp4.osuosl.org (Postfix) with ESMTPS id D305A405ED for ; Wed, 9 Oct 2024 00:14:08 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 866EBA43876; Wed, 9 Oct 2024 00:13:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30D8DC4CED4; Wed, 9 Oct 2024 00:14:06 +0000 (UTC) Date: Tue, 8 Oct 2024 17:14:05 -0700 From: Jakub Kicinski To: Paolo Abeni Message-ID: <20241008171405.42e8890e@kernel.org> In-Reply-To: <72241d8f846c67b7201f0293956ef6db6bbbf176.1727704215.git.pabeni@redhat.com> References: <72241d8f846c67b7201f0293956ef6db6bbbf176.1727704215.git.pabeni@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728432846; bh=vCkuvxHqKBdleT2a8rkQv03dvvsEFnflHm/7wJjAlKg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gb+RpNKX9gwa3wLmraNzkHZmQCjeLhk/iz4c4dssyTKlfdgr297c6M29zH/NkEz/G LC4gM0wM3clnCwWHl95ESLVIulyDN2X7IXRo6iLUc+I4ix9Ginh+S9a1rdrbMJ3vEf 1ogDcACRkf4vjM3+VErNTO5M6AOOTqWrHbMSqz48rPftK6CkbDTCE7uR3BNKTqpPe6 LAdVf2t14ADIVaSm/rsC0KogBG0SSqIfuUIpgk3V4UiZQMYU41ueM6HIXPZoWbeNSS hA8YRzO+KoUHgW0aIu8EVZ/p/FJAXeH+Ptow6Spw0owhIO77KpolFkQilnZNPu0QB9 ufgfHYy5E+wrw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=gb+RpNKX Subject: Re: [Intel-wired-lan] [PATCH v8 net-next 02/15] netlink: spec: add shaper YAML spec X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , netdev@vger.kernel.org, John Fastabend , Jamal Hadi Salim , edumazet@google.com, Madhu Chittim , anthony.l.nguyen@intel.com, Simon Horman , Sridhar Samudrala , Donald Hunter , intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, Sunil Kovvuri Goutham , Stanislav Fomichev Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 30 Sep 2024 15:53:49 +0200 Paolo Abeni wrote: > + name: group > + doc: | > + Create or update a scheduling group, attaching the specified > + @leaves shapers under the specified node identified by @handle, > + creating the latter, if needed. This line is unnecessary? The first line already says "create or update" so no need to say again that the node will be created? > + The @leaves shapers scope must be @queue and the node shaper > + scope must be either @node or @netdev. > + When the node shaper has @node scope, if the @handle @id is not > + specified, a new shaper of such scope is created, otherwise the > + specified node must already exist. > + The @parent handle for the node shaper is optional in most cases. > + For newly created node scope shaper, the node parent is set by > + default to the parent linked to the @leaves before the @group > + operation. If, prior to the grouping operation, the @leaves > + have different parents, the node shaper @parent must be explicitly > + set. How about: The @parent handle for a new node shaper defaults to the parent of all the leaves, provided all the leaves share the same parent. Otherwise @parent handle must be specified. > + The user can optionally provide shaping attributes for the node > + shaper. > + The operation is atomic, on failure no change is applied to > + the device shaping configuration, otherwise the @node shaper > + full identifier, comprising @binding and @handle, is provided > + as the reply. We should also mention that if the node already exists the group operation will _add_ leaves to it, rather than recreating it with the provided set of leaves. Right? My intuition was that the node will get the specified set of leaves and the other leaves get deleted. The current behavior is fine, but needs to be documented.