From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FCCAD10BFC for ; Sat, 26 Oct 2024 15:38:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0FB0A606C0; Sat, 26 Oct 2024 15:38:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id JrAI7ZTJc0aH; Sat, 26 Oct 2024 15:38:20 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 729FF60667 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1729957100; bh=Lhv8zOozUzECyBqHYrdrDM0YBrvFUiG1KCPIuMa45NM=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=j3yXAL87wyrzyta00gF+4FWXpvl5K1pqGnXyKL+6a5+cRUHOG0kpPbeNYHT/NrQ7a fnirGe73kQA5ZWTOQHLcUa2UmI3x4AsA5bwSP9yEnP/1/bkpLydccEE2A0GZ6E65kZ M8h33uutb9Yr9owDQlGdA2jK8KYxqWWIkhrgTtWR9jpxcqW5IetsLGNTzmYK4Cc4Gk 5ShlTexhEtVBpnOmh4UTYYEXGO9ZMWE7DvetLvJ+/B+BbOUqXxtXy3EzHKF2pbkD42 pqqhAKgjnj97rOs1eZ3/5EG6JcwuzQ7qJ1bZrZd8+qJupHcuC55s9QH3LYnKWZWthv 8zrR3msh9jRlA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 729FF60667; Sat, 26 Oct 2024 15:38:20 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 93F915C1E for ; Sat, 26 Oct 2024 15:38:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 74EDF406D3 for ; Sat, 26 Oct 2024 15:38:18 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6iZHsKk7KuVV for ; Sat, 26 Oct 2024 15:38:17 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 89BEA40356 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 89BEA40356 Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp4.osuosl.org (Postfix) with ESMTPS id 89BEA40356 for ; Sat, 26 Oct 2024 15:38:17 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 27D72A40B28; Sat, 26 Oct 2024 15:36:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24343C4CEC6; Sat, 26 Oct 2024 15:38:11 +0000 (UTC) Date: Sat, 26 Oct 2024 16:38:10 +0100 From: Simon Horman To: Yue Haibing Message-ID: <20241026153810.GN1507976@kernel.org> References: <20241026041249.1267664-1-yuehaibing@huawei.com> <20241026041249.1267664-5-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241026041249.1267664-5-yuehaibing@huawei.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729957096; bh=WoFOQrFDbt2BycOyxn0Rx5XH/N5keHBSRn4+P/slL3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kZialk5IA7F8jwSiHW3amfsbfcZQEOLS3YLnu3MDowfEfxUfJYvx4ybNKAOJAgNkp StTtJ7ELKCJlvZxR+7fzw1/UMbAOEGoEtDPOtJbSnGfH+X7J3/tAFUkDp+XuMPgmIK Dw20FZCCTOG0b/yUqmA10j/RHIZr3qj5Ig529JpVChUtrhmVT4Q+Hs+/hxwGSX1nYc NrdAc6L1y6LI9nn/UFAQsfteG9zM+hZ854RQo/OiI65c1C5kd6JkN8I04gC9JItjJp ZRAI6DiKkQ3XffMQTakCBtsW8eyjwVSnXoODEVH8WQkb+0d9SsHCmFqcpOxSebqi0R FfaWzy5qtYUig== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=kZialk5I Subject: Re: [Intel-wired-lan] [PATCH v4 net-next 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexander.h.duyck@intel.com, andre.guedes@intel.com, maciej.fijalkowski@intel.com, hawk@kernel.org, daniel@iogearbox.net, jithu.joseph@intel.com, przemyslaw.kitszel@intel.com, john.fastabend@gmail.com, ast@kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, jacob.e.keller@intel.com, kuba@kernel.org, bpf@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net, vedang.patel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, Oct 26, 2024 at 12:12:49PM +0800, Yue Haibing wrote: > ixgbevf_run_xdp() converts customed xdp action to a negative error code > with the sk_buff pointer type which be checked with IS_ERR in > ixgbevf_clean_rx_irq(). Remove this error pointer handing instead use > plain int return value. > > Fixes: c7aec59657b6 ("ixgbevf: Add XDP support for pass and drop actions") > Reviewed-by: Jacob Keller > Reviewed-by: Maciej Fijalkowski > Signed-off-by: Yue Haibing Reviewed-by: Simon Horman