From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AE85E67801 for ; Sat, 2 Nov 2024 15:10:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 331B360639; Sat, 2 Nov 2024 15:10:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5-Z43Kiv5NBQ; Sat, 2 Nov 2024 15:10:41 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8A7EB60857 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1730560241; bh=C2d7saqPvm8uuREUBszHzZgcVT1oS3UeMXMZ2CfR0Ss=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=5e24/GbNVv0Waq3EWI9w9eZCn52ODBf3oLhSQ1KpCnGI81QiglIfKqmi1Bc4P1tz0 GhPuE0OKXRfWR9fiUtZnV4JJCKm7jxxPuQC+mn9OqP3Ke2KeRDhRfmYVv2rcJFZnOz 3cwoV+dNUbZbe9Kd/I+yQzAPBtpwbN0YzU+5GhAPRnhUapZGUfgcH0yUi5FIbAD3MO TYTw3/Q5kXU3QEIpmbthCf4oU3hHzauukc5fR3oAED32PSSI4S14OPtfWfEE6D48kl i3Dl5oJjpW4MJfLdqsyLR5DBstgGkfOnUD4G5Ceo49ZFIoN/waWCnm48mCxzLP4lKU Tarqf+DQTviMg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 8A7EB60857; Sat, 2 Nov 2024 15:10:41 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id CB8AA27E1 for ; Sat, 2 Nov 2024 15:10:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BA5588134F for ; Sat, 2 Nov 2024 15:10:39 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Cym_cbWcGtqB for ; Sat, 2 Nov 2024 15:10:39 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 168A982053 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 168A982053 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 168A982053 for ; Sat, 2 Nov 2024 15:10:38 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7E33E5C435C; Sat, 2 Nov 2024 15:09:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B2D1C4CEC3; Sat, 2 Nov 2024 15:10:36 +0000 (UTC) Date: Sat, 2 Nov 2024 15:10:33 +0000 From: Simon Horman To: Grzegorz Nitka Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, Karol Kolacinski , Arkadiusz Kubalewski Message-ID: <20241102151033.GP1838431@kernel.org> References: <20241028204543.606371-1-grzegorz.nitka@intel.com> <20241028204543.606371-3-grzegorz.nitka@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241028204543.606371-3-grzegorz.nitka@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730560238; bh=BRzbZbvrsonkgSCIr2qVQooEeByYk+usY3bS4Qx8zQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K6+oBM5cE0qJwqVV0nahfYdSTaZElo0JurFanzJjXGeFn5ccVxPrTrPrxlU90cYrF 30camoDKYiuGPLnhULPXCGPlcUgeB+gEoFaEh6pI0EKBRbpl420m/TFqSn9MF2DIrv a3GnbH+ZySPAqktmDDRhM2UNtJtDsH+QYCw94XsHlsHcB5lxD0aAAqKcuhtG3Y8UpK lsBCpXCKXzqzBdFUYMeGDcI+PHIjEKHl4kLve7P7Mh/SK3Q5ZZ7lLU7S/UyPUfVHGb SksoXeH+/MI1wAq7750kDgUyuU1rlsjS5DTCWRLojEr2Q46U+HeQaTh/SOR43PzxIH Fmz9jW3BnK8qQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=K6+oBM5c Subject: Re: [Intel-wired-lan] [PATCH v3 iwl-net 2/4] ice: Fix quad registers read on E825 X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Oct 28, 2024 at 09:45:41PM +0100, Grzegorz Nitka wrote: > From: Karol Kolacinski > > Quad registers are read/written incorrectly. E825 devices always use > quad 0 address and differentiate between the PHYs by changing SBQ > destination device (phy_0 or phy_0_peer). > > Add helpers for reading/writing PTP registers shared per quad and use > correct quad address and SBQ destination device based on port. > > Rename rmn_0 to phy_0 and remove rmn_1 and rmn_2 as E82X HW does not > support it. Rename eth56g_phy_1 to phy_0_peer. > > Fixes: 7cab44f1c35f ("ice: Introduce ETH56G PHY model for E825C products") > Reviewed-by: Arkadiusz Kubalewski > Signed-off-by: Karol Kolacinski > --- > V2 -> V3: Replaced lower/upper_32_bits calls with lower/upper_16_bits > V1 -> V2: Fixed kdoc issues > > drivers/net/ethernet/intel/ice/ice_common.c | 2 +- > .../net/ethernet/intel/ice/ice_ptp_consts.h | 75 ++---- > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 237 +++++++++++------- > drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 37 ++- > drivers/net/ethernet/intel/ice/ice_sbq_cmd.h | 7 +- > drivers/net/ethernet/intel/ice/ice_type.h | 1 - > 6 files changed, 177 insertions(+), 182 deletions(-) This patch seems to mix bug fixes and cleanup. Which leads to a rather large patch - larger than is desirable for stable IMHO. Could we consider a more minimal fix for iwl-net. And then follow-up with clean-ups for iwl? ...